From: "Eli Zaretskii" <eliz@elta.co.il>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:doco] mention gdbarch_obstack_zalloc in per-module data
Date: Mon, 16 Feb 2004 09:28:00 -0000 [thread overview]
Message-ID: <3405-Mon16Feb2004112915+0200-eliz@elta.co.il> (raw)
In-Reply-To: <402FC215.3020906@gnu.org> (message from Andrew Cagney on Sun, 15 Feb 2004 14:01:41 -0500)
> Date: Sun, 15 Feb 2004 14:01:41 -0500
> From: Andrew Cagney <cagney@gnu.org>
>
> Per my e-mail to markk, this updates the doco to reflect current reality.
>
> ok?
Yes, but...
> +Any memory required by the @var{init} function should be allocated using
> +@var{gdbarch_obstack_zalloc}.
`gdbarch_obstack_zalloc' is not a parameter, but a true literal
symbol, so it should be in @code, not in @var.
> @deftypefun void set_gdbarch_data (struct gdbarch *@var{gdbarch}, struct gdbarch_data *handle, void *@var{pointer})
`handle' should be in @var here, I think.
> +Set the uninitialized (NULL) data-pointer corresponding to @var{handle}
> +to the non-NULL @var{pointer} value.
Both `NULL's should be in @code.
Also, is it guaranteed that uninitialized pointers have a NULL value?
In general, that's not true, but perhaps in the context of gdbarch it
is, I just don't know.
Thanks.
next prev parent reply other threads:[~2004-02-16 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-15 19:01 Andrew Cagney
2004-02-16 9:28 ` Eli Zaretskii [this message]
2004-02-16 18:13 ` Andrew Cagney
2004-02-26 20:51 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3405-Mon16Feb2004112915+0200-eliz@elta.co.il \
--to=eliz@elta.co.il \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox