From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73957 invoked by alias); 9 Jan 2020 19:50:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73815 invoked by uid 89); 9 Jan 2020 19:50:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=excellent, HX-Received:4d8d X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2020 19:50:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578599428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GADyOhhRpjuMUzTrBxvR4bau5+5voAmurBJv4xaWbA4=; b=OGaDRs7ywYyJwP/UVw+bvkAN+efWzSt/1Fg4EUfeS8zihnlH5OwdRYkJMkTlSL6g/JXFGs WjxqzGCyIpOe9c/uAmBjgXjl7d8VHCRXj5qoROh41X5+m6JBCxlCP5LX9K6468s2nCA+zf lzOCDzpBUIWPhSD8jnoaGBFaqPlTx5Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-WtQo7BTnO96NVDcF2Xnvkg-1; Thu, 09 Jan 2020 14:50:27 -0500 Received: by mail-wr1-f70.google.com with SMTP id k18so3294596wrw.9 for ; Thu, 09 Jan 2020 11:50:27 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id e12sm9320375wrn.56.2020.01.09.11.50.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2020 11:50:25 -0800 (PST) Subject: Re: [PATCH v2 00/24] Multi-target support To: John Baldwin , gdb-patches@sourceware.org References: <20191017225026.30496-1-palves@redhat.com> <20a1459c-e705-99e9-9277-51cec32b28c5@FreeBSD.org> From: Pedro Alves Message-ID: <33f04418-380c-8a56-b80e-82c7139b9cd1@redhat.com> Date: Thu, 09 Jan 2020 19:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20a1459c-e705-99e9-9277-51cec32b28c5@FreeBSD.org> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00220.txt.bz2 On 1/9/20 7:31 PM, John Baldwin wrote: > On 10/29/19 12:13 PM, Pedro Alves wrote: >> For bsd-kvm.c, I _think_ that the only change necessary to keep things >> building would be this: >> >> --- a/gdb/bsd-kvm.c >> +++ b/gdb/bsd-kvm.c >> @@ -136,7 +136,7 @@ bsd_kvm_target_open (const char *arg, int from_tty) >> core_kd = temp_kd; >> push_target (&bsd_kvm_ops); >> >> - add_thread_silent (bsd_kvm_ptid); >> + add_thread_silent (&bsd_kvm_ops, bsd_kvm_ptid); >> inferior_ptid = bsd_kvm_ptid; >> >> Right? See updated patch below. > > Ok, this works for me. Excellent! I think I'll be merging this soon, just need to address Aktemur's latest comments. Thanks, Pedro Alves