From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69728 invoked by alias); 9 May 2017 12:21:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69691 invoked by uid 89); 9 May 2017 12:21:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-PHP-Originating-Script:rcube.php, transfer, Transfer X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 May 2017 12:21:52 +0000 Received: by simark.ca (Postfix, from userid 33) id CD0AE1E4A4; Tue, 9 May 2017 08:21:53 -0400 (EDT) To: Tim Wiederhake Subject: Re: [PATCH v3 02/12] btrace: Transfer ownership of pointers. X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 09 May 2017 12:21:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com In-Reply-To: <1494312929-22749-3-git-send-email-tim.wiederhake@intel.com> References: <1494312929-22749-1-git-send-email-tim.wiederhake@intel.com> <1494312929-22749-3-git-send-email-tim.wiederhake@intel.com> Message-ID: <33e1fd97a5b1e4d0d7c660bd06872780@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00208.txt.bz2 On 2017-05-09 02:55, Tim Wiederhake wrote: > Directly insert new btrace_function pointers into the vector and have > the > vector own these pointers. This allows us to later retrieve these > objects by > their number directly after creation whereas at the moment we have to > wait > until the vector is fully populated. > > This requires to pull btrace_thread_info through different functions > but > cleans up the code for freeing the trace. LGTM.