From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +3UHK6Nszmnp/AMAWB0awg (envelope-from ) for ; Thu, 02 Apr 2026 09:18:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 9AA411E04F; Thu, 02 Apr 2026 09:18:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EF8F31E04F for ; Thu, 02 Apr 2026 09:18:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id F15864BA2E0A for ; Thu, 2 Apr 2026 13:18:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F15864BA2E0A Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 6B88D4BA2E0A for ; Thu, 2 Apr 2026 13:18:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B88D4BA2E0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B88D4BA2E0A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775135881; cv=none; b=gxfG7uT+IaJFtojHXwoq16kAvj3y7/K3JXrFTpLsclkJ3d3Ltl/6SpcRdbX7iSu09SRRV/LNJsqsuWNteKhvZD9g1WP0CgC9RzHmJvY+pRcH3LnWFH8IBRAxOzHXjXUw0rKuvtrjaQcMxrFhw3iizdUpCcMvMYtodHrfG5dELAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775135881; c=relaxed/simple; bh=sq5DlUSwTDpCQ3nLElfs9ggfTKczwKbrjWSykhK17Wo=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=wZQUimb8gWRj6lwo03Rxi5QTqq2DtR23hjMct6mx1pgW1LIxKUPu4Seji8XH9VKyTXVPc0Enrv0TrnKEcUORjEBkoCsjnVXzLyflqtBs7cmX7V6hkjXvPwGtMIjisCV4rCtAg6+geYumkcSdziy9JKQ4kdthewCM7opG1bfbmC0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B88D4BA2E0A Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4853e1ce427so10106925e9.3 for ; Thu, 02 Apr 2026 06:18:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775135880; x=1775740680; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XRv/6Gwq33KxV8Y+wvLgeYnXHbI+neANW6Xi7ZctkFk=; b=AJ5b/jCa0f4LfKUHQUe5KOnJiWpP0i0I60vQc2vN0k54u/oLY3lSenoV/RT2uKni8J xt2mk6FSH/lk1zOisRSI62cW7R03XXsOgCLxR7MFGfjgWnLnnnhufXxaHiDqQIOFVAMZ 57mnyu+s+KjINmfccUPUUGuXbBFXCVch8eIE6qeej45bKYcVV1gKeP1ZZmCWWi7AJd1I v9Q6Xdin3iSRqW7VrkXVH3tHHq13tz/HrRIn+1fCp1CSRK/ww4LBb7jzyanT7M73soEb gEiH6XqIeWAnxtkIpRy2iyXUS/8jACN1kbQFrCUiS71WCwTYrNPDQ3GWKBTlWa3XnLNA UgOA== X-Gm-Message-State: AOJu0Yz57kReFc3nOSZkeX5lTBQ2EFLVfvqOVmmiFYwNzvPuzZWhYCJn 7FCqTrFHtKQbKHfgdzEeWrmdYD3xl0K49b5cDXrfD5wRT4QXHtJ5nQMC0F9FQgNc X-Gm-Gg: ATEYQzzDRPWdROM4vdyibPMugc6jRYMxb8w8UaVy4hub8SyjhakRvOg+09P8fIbDBhu Mpw193UqxPwk8EG3M96UuTDMNgTB6IA/VwTpzUAR+NnZoGg+9hmGFkSEQKhNT8wnbhRWA+b5/tl pa6BCzk/ajLhTjj6FYkxUiYZTHxplUehWkSxDZhp9reMO5lhTG57mlLw5os9zwfasEdDiSD+iZY V0we2hj24dToFkvJT48y2K/D3YVTGpmuELUyyQO5dSbD8snnpWFqd01+oA7xjd7Yynj919/AZUu QW1huKqq9Jk11fVHG1pbKVrirS7bZwNuI8MEd8PpEUanLfhvkDYtWoolRwY2vimWfFJdQVj7lRZ ICb615LvbKHcCP/jLbaF3thmxVszNDPSdacSgpI6Unlj0KltO9njvQuVs+M2y/2PSQWNGNJqrWU 0XDwTO+umjl0hBxpL1iQXWOuPBg8i/psu/IXO3f0FrF1t+6TwWdXMry0ts1BQ8nnsftg== X-Received: by 2002:a05:600c:45c5:b0:483:6d42:25c6 with SMTP id 5b1f17b1804b1-48883592213mr126547975e9.23.1775135880029; Thu, 02 Apr 2026 06:18:00 -0700 (PDT) Received: from ?IPV6:2001:8a0:fac8:3000:6330:d983:4e81:3a5e? ([2001:8a0:fac8:3000:6330:d983:4e81:3a5e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c536a7fsm158516705e9.1.2026.04.02.06.17.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 06:17:59 -0700 (PDT) Message-ID: <33c57dbd-fd34-47c0-95a3-e20848ed3828@palves.net> Date: Thu, 2 Apr 2026 14:17:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/47] infrun: Remove unnecessary currently_stepping call To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-4-pedro@palves.net> <20250521124410.08b8489e@f41-zbm-amd> From: Pedro Alves Content-Language: en-US In-Reply-To: <20250521124410.08b8489e@f41-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-05-21 20:44, Kevin Buettner wrote: > On Mon, 19 May 2025 14:22:24 +0100 > Pedro Alves wrote: > >> There's one unnecessary check for currently_stepping in >> handle_signal_stop that can be removed. It is unnecessary because >> currently_stepping is only ever called if >> ecs->event_thread->control.trap_expected is true, and then if it is >> true, then currently_stepping always returns true too. > > After looking at the definition of currently_stepping(), I agree > with your reasoning (and your patch). > > Approved-by: Kevin Buettner > Thank you, now merged.