From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id afl3MEmsuGkPriwAWB0awg (envelope-from ) for ; Mon, 16 Mar 2026 21:20:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1773710409; bh=uwxc8GwlA6UdRvXx17SaMZH33iQmnD5kLsyVZgtElPo=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VGF5ybiIOWBZRnkim0uMVg34WP3qOSkT0d7aLBcLSPvggUqLxa3gnCq++lKk9ZeMW Cp5WdeI2X4l6VV5O9PBSCvudS7VoHQf877n2v8M48UmRPYDED3UCPVLh0Nk9tya+uF z7W7Nn2jt7ee1U197zEM73gM5AiZHEti5+1g9wKo= Received: by simark.ca (Postfix, from userid 112) id C1ECC1E0BC; Mon, 16 Mar 2026 21:20:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Vgh9r5fg; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9F6C61E04F for ; Mon, 16 Mar 2026 21:20:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 205DD4BB58F2 for ; Tue, 17 Mar 2026 01:20:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 205DD4BB58F2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Vgh9r5fg Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9A4ED4BB58F9 for ; Tue, 17 Mar 2026 01:19:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A4ED4BB58F9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A4ED4BB58F9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773710382; cv=none; b=SdngFLaQA+Dq+DLJLdsG6oedcO5slL256ajhTRR6cMYrxT/W1IilSn3UqDqeT5mJK02RsYzc52tetv5iV6LOq+ftcDdZWjJys4c3Q1MK88ZUivYsKkX/Q72PoYtfYm09foHsZ3U8jrfdziooYv49A11ZulcewLd91Y4ZpNAqYiQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773710382; c=relaxed/simple; bh=uwxc8GwlA6UdRvXx17SaMZH33iQmnD5kLsyVZgtElPo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dvXa7YZRjgDgmX11Ji0DGBLkcGooGwP/kf9lxQTCLF8CBg7t7k/FqXDN2aQ4Hr1Dvwz4IUmHIP9hN3GsQc9m6EZ2OOSyBX3eAFQWqgBWjpuIc43U5c9v9l+M6eC2xEp7bNkA9wD+qDG2sbvIZDw8WHf5I42EJqaB22zcZXkEJyc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A4ED4BB58F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1773710381; bh=uwxc8GwlA6UdRvXx17SaMZH33iQmnD5kLsyVZgtElPo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Vgh9r5fgcspCij2P/PkudqnIywDAUiUFndHJTNMtLrsbAGsutx8PmVTDbgsg0h92z EYpwYLOAdO/9CcF39kqeq+Gaflmw4JwGFbIeOWCnhR4TENHTJDFP/wsM0LoMY0gogT iEXEtf2WH8DEqGmpC6JjGq+iPGzhateSQ0nYl5Ms= Received: by simark.ca (Postfix) id 66BEA1E04F; Mon, 16 Mar 2026 21:19:40 -0400 (EDT) Message-ID: <33b1b794-d592-45e7-9bb7-53a4a9c45607@simark.ca> Date: Mon, 16 Mar 2026 21:19:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [SH] Check FPSCR.PR for fldi0, fldi1 insns in simulator To: Oleg Endo , gdb-patches@sourceware.org References: <016918b6653a40835d2272c3c37d05b0d7e470b6.camel@gmail.com> <6eb50919-75d8-4725-9afa-e241e4cabab6@simark.ca> <9855a27b-78f6-4d4a-b0f6-04fefcaf7a49@simark.ca> <94f77e9bfecf923cfca8caa5427de7604ebe2fd7.camel@gmail.com> From: Simon Marchi Content-Language: en-US In-Reply-To: <94f77e9bfecf923cfca8caa5427de7604ebe2fd7.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-03-16 21:18, Oleg Endo wrote: > On Wed, 2026-03-11 at 10:39 -0400, Simon Marchi wrote: >> >> Ok, well since we're in "undefined behavior" territory we could argue >> that the current sim behavior is fine. But I think the patch is still >> good, traping is a more useful behavior to catch something you don't >> want to happen. > > Yes, the current sim behavior is not wrong per se. But like you said, > having it trap is more useful for sim's main purpose -- pre-verifying code. > > >>>> The patch LGTM, but I am not a maintainer of the sim, so: >>>> >>>> Reviewed-By: Simon Marchi >>>> >>>> One note, please put the relevant information (the body of your email) >>>> into the commit log itself). >>> >>> Yeah, sure I can expand the comment of the commit. Updated patch/commit >>> attached. >> >> I would give it a week for Andrew or Mike to review and approve, but >> otherwise I would feel comfortable merging it. >> > > Alright. Last time I've checked I had write access. I can commit & push it > myself. Just let me know. Yes, please go ahead. Simon