From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57034 invoked by alias); 20 Feb 2019 02:16:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56252 invoked by uid 89); 20 Feb 2019 02:16:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=pm, UD:p.m, p.m X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Feb 2019 02:16:37 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x1K2GKvd026327 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Feb 2019 21:16:24 -0500 Received: from [10.0.0.178] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EB0AD1E077; Tue, 19 Feb 2019 21:16:19 -0500 (EST) Subject: Re: [PATCH] Fix error message and use-after-free on errors in nested source files To: Kevin Buettner , gdb-patches@sourceware.org Cc: Simon Marchi References: <20190218234640.25664-1-simon.marchi@polymtl.ca> <20190219153729.35348891@f29-4.lan> <7eed7ae3-6f2a-285b-1270-6006d524e87a@ericsson.com> <20190219165130.67e94f6a@f29-4.lan> From: Simon Marchi Message-ID: <3385e948-564c-4f75-1a77-b488869a1819@polymtl.ca> Date: Wed, 20 Feb 2019 02:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190219165130.67e94f6a@f29-4.lan> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00322.txt.bz2 On 2019-02-19 6:51 p.m., Kevin Buettner wrote: > On Tue, 19 Feb 2019 23:24:01 +0000 > Simon Marchi wrote: > >>> Did you mean to remove gdb_exit above? If so, why? >> >> Yes, many tests have a gdb_exit at the end. I believe this is not necessary (though it doesn't hurt) >> because it's done anyway after the execution of the test. So it has become an automatism to remove >> it if I am modifying that area of the tests. I can leave it there if you prefer. > > Thanks for the explanation. > >> Thanks for the review, here's the updated version. I also fixed the title, >> where it should read "sourced" instead of "source". > > LGTM. > > Kevin > Thanks, I pushed it. Simon