From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8mBoAV62o2hunQYAWB0awg (envelope-from ) for ; Mon, 18 Aug 2025 19:25:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=SyEY+e8i; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EA6311E048; Mon, 18 Aug 2025 19:25:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 942931E048 for ; Mon, 18 Aug 2025 19:25:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3845F385743A for ; Mon, 18 Aug 2025 23:25:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3845F385743A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=SyEY+e8i Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 7E9583857B8F for ; Mon, 18 Aug 2025 23:24:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E9583857B8F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7E9583857B8F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755559484; cv=none; b=dGd8eRecR4O1K/ZbgW2n2+H4jRw+bxTsLk0TS63F46za6hd8Hslu34WUKpf68UFP+dMuWf9FHoTlKh2/OGxd3ZkIZQk0tCnOAm9+23Y5tDz9ZIcfoHmLC8r282yZ081/xujWMdnVGw2EssPXnLbihcmK8+KSNJWLsveYTAn5xdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755559484; c=relaxed/simple; bh=n6d3ZjHLfQotzWXcwgMAK6DeIk0E4htDg5nHcRjM0rQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nq5BOZHFwdJsAKglq6pPtIc4xtwQSfA6JeK/hGcMv+aseB7us0NXkAxFae2ZZJNfe+QSMsxVJlDVohzh8pdnMj2z7z0PKZOpbYQF3KiQSH0ERvkqsIAJvwA1x55t8b7i8MsT//vPoat2G6vFegEogepPZ4kxMLmUlO/c3SH3rDs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7E9583857B8F Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-45a1b05a59fso36243325e9.1 for ; Mon, 18 Aug 2025 16:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755559483; x=1756164283; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bpxAZ9zf+EmEE2SxIxX/lz+G3sSRwhC/JLmmqYR8iyU=; b=SyEY+e8ivPiQyRIAgBmEB6JHWkISVhk2bq8s7hh1W98EcfeGmSIc2/v4pukLO/NIhY 0WouH8scJhn6bhAiYevAqOglj3NxfJs/GZ1LxjbLvC3aEmBThY0UjpEc4sMk1Zp2L5iD odc/Fg5BBpwjn4Jr36L1KQJsMbqaoNxVlh8fTFWRw6oWr+iEitsSfubaryl2WbDOEXa+ GZ6I7p3tny7q3+5yWZSAiZxnw9aHcA5NiJqJ6AADHPAXV+y2qTd1FmH3VlEUHozQfXeo TtsLF02+WOXh2VaWBaU+tPXfSfOxd1ldRbmUClJOtlSJvC8a3bRjV3wUYFR2/KU7vboT zbBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755559483; x=1756164283; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bpxAZ9zf+EmEE2SxIxX/lz+G3sSRwhC/JLmmqYR8iyU=; b=VviD8AmmJAB9xBKJwC9SBGYvBg1mqIihNo9hAmtFxf6HN/trmf59CeRK5cVTwX1cET 9FbM4PQgrQNxA1fytc/wnLPSTOl/8Cr8tuUp7dBw4HgYEWWoVxEMy5joSnAYgIACH5EQ tvY4nDNdgZ6n1/Jd+fmtNB/uyIwP+RUnc2Qvx1YQBLrwAwWELytjcny22RUvs5BmcU5b +m3T/MI8ijTbBIMEpqHjGypDIy66aeNkoyO9EwlU6ublPj+vRCLhiXirn7fG9VIChUX0 O16VldnGSRrHZ2nECYKQ5MNpYAniIf+k0LiVsU4JG8vycx/a6ziklFGnuSFpnMvFIeln USCQ== X-Gm-Message-State: AOJu0Ywz4JgCfXui4D+2k5/DBVdBdxqDKPrspzhteJxAuVMxpRu9gYPg Eog2AOs/7k9+WvDGxSSSODucM4Q2wVglSn8KsFT189jCZ75wwynk/u+P7ZrosXGr X-Gm-Gg: ASbGncu+5Fk1nFTSnECmqG73ZZgzwxhpZOXAofy3QhwLDZzTPDyX+LXeF9vungyIT5Z j4gdUcGot0xshj1shipUgBhwimQT80+SEjke6tb2AxN+z4Co4F5ApJLTL3FjyDP5I1sEobYPHI1 /qyT+6S1gjDjPFYmoemilPD3NWCjzx14qdVFEcfnSQFy08fVW2cRD7gvE/PhIabCGrqDHKO3rvQ Q2Qbr7X0CcTmNd43t6zCih84dVcW4biuEJ0g/mq6//eieBCH3b8ZIarI1b+xLdZUZrzqRR7/Po3 9lNgU6hR6GwNjgEjoolunAphpMGFdpC+0vRcmGViQKC+9P9x4xUC+zQvF2bz8K/xFNd4TmUk7dB GRdmijUbfa49x4eXYSsp293SNqPLsP4sM3l4fjHcuX/xAug== X-Google-Smtp-Source: AGHT+IHYbhTKIg5xFzT59t/ghwkGQyPI7qH7nlB34TFSBsbBzNKqjVPPEDK6JXjBgnx5DVLcm+nyjw== X-Received: by 2002:a05:600c:c8d:b0:453:2066:4a26 with SMTP id 5b1f17b1804b1-45b43df3c5bmr2962375e9.16.1755559483182; Mon, 18 Aug 2025 16:24:43 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a209c25a1sm160705305e9.22.2025.08.18.16.24.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 16:24:42 -0700 (PDT) Message-ID: <335c9e3c-12ca-417c-a6f7-c7d208268797@gmail.com> Date: Tue, 19 Aug 2025 00:24:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: rename gdbarch_software_single_step -> gdbarch_get_next_pcs To: Kevin Buettner , Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi References: <20250814201418.164267-1-simon.marchi@efficios.com> <20250815200908.131101fa@f41-zbm-amd> Content-Language: en-US From: Luis In-Reply-To: <20250815200908.131101fa@f41-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/16/25 04:09, Kevin Buettner wrote: > On Thu, 14 Aug 2025 16:14:17 -0400 > Simon Marchi wrote: > >> From: Simon Marchi >> To: gdb-patches@sourceware.org >> Cc: Simon Marchi >> Subject: [PATCH] gdb: rename gdbarch_software_single_step -> >> gdbarch_get_next_pcs Date: Thu, 14 Aug 2025 16:14:17 -0400 >> >> From: Simon Marchi >> >> I spotted this while reviewing a patch adding a new >> gdbarch_software_single_step implementation. I find the name >> "software_single_step" a bit misleading or unclear. It makes it sounds >> as if the function executed a single step. In reality, this function >> returns the possible next PCs for current instructions. >> >> We have a similar concept in GDBserver: >> linux_process_target::low_get_next_pcs. I like that name, it's clear >> and straight to the point. >> >> Rename gdbarch_software_single_step to gdbarch_get_next_pcs. I find >> this name more indicative of what happens. >> >> There is some code for ARM shared between GDB and GDBserver to implement >> both sides, also called "get next pcs", so I think it all fits well >> together. >> >> Tested by rebuilding. > > This one makes sense to me too. > > Approved-by: Kevin Buettner > Agreed. The naming has confused me in the past as well.