On 22-05-2020 22:12, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> +# This test-case uses the cp_test_ptype_class cache (by means of the ibid
> Tom> +# argument), so initialize and finalize the cache.
> Tom> +init_cp_test_ptype_class_cache
> Tom> +
> Tom>  do_tests
> Tom> +
> Tom> +finish_cp_test_ptype_class_cache
> 
> If the users always have to do this init/test/finish thing, then maybe
> some kind of wrapper proc would be more appropriate.
> 

Done.

> Also, it's more robust to use 'catch' to ensure that the cleanup is
> always run.
> 

Done.

> However, is the finish bit needed?  If the init proc cleans up all the
> state, then it seems unnecessary.

Agreed, strictly speaking it's unnecessary, it's just a cleanup.

Thanks,
- Tom