From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34091 invoked by alias); 16 Jan 2018 15:30:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33977 invoked by uid 89); 16 Jan 2018 15:30:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:sk:EUR03-A, H*RU:sk:EUR03-A, H*r:sk:EUR03-A X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jan 2018 15:30:05 +0000 Received: from ESESSHC019.ericsson.se (Unknown_Domain [153.88.183.75]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 91.0A.14322.A7A1E5A5; Tue, 16 Jan 2018 16:30:02 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.75) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 16 Jan 2018 16:29:14 +0100 Received: from [100.94.230.5] (129.192.64.65) by DBXPR07MB319.eurprd07.prod.outlook.com (2a01:111:e400:941d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.9; Tue, 16 Jan 2018 15:29:12 +0000 Subject: Re: [RFA 4/6] Change dwarf2_cu::method_info to be a std::vector To: Tom Tromey , References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-5-tom@tromey.com> From: Simon Marchi Message-ID: <32a00426-ccdd-858f-85d7-3a2faab54d7f@ericsson.com> Date: Tue, 16 Jan 2018 15:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180106002621.21099-5-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0401CA0045.namprd04.prod.outlook.com (2603:10b6:803:2a::31) To DBXPR07MB319.eurprd07.prod.outlook.com (2a01:111:e400:941d::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad3f0e0b-2c08-4652-55a7-08d55cf5e5a6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020);SRVR:DBXPR07MB319; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;3:YfFgLuci5Nd4HJ8Z6cz6oNMdAiYPrfKQO70uK7L7J48JBYbZbqC38L0pFPqkNcRLS0ZbuETifrblYxVuyC5cA8qqZGRhk+AwGJ16EDcfxHY/f1b5hH/8kD2cZL9ir0OOth9LLwcdH6to+IN6cihNwpeMzyUVAW5ure8BpVBlXFCTa/B6fOWNnqF9wyksSF5ATU2/7J2SN4aKZkxjkTzN9uLe1+HKfWaeq7pN9+dCgouldZ6Yqi000F5e3y07Vx7Z;25:PnUbB0NpP3asGdMXQY51pUCwcZRMTGSXWyme/BhRhApJO0ZCl1QVEK/CldS/AGM7lKbJCl1EhO3k3vJgZ8eoabtTaoUfvW1wZqLQuLypg1lc8axUSW+DQgGbNI3HO76YFkbKoNDiCyDCkh3+kaaXYWIzjUm2NFbaS97BYKDQxFx4E0r6v8PdbqziePwEJftkrIpkCOlsPEcI91aOhdIVcZIJATr087Um0zHPe5aPGd5HHSRqE1AB04N3n+9FIgzzSp+VdPwBUvrAW+z6XlN009rT4sOoGQsTdq+ZrZBANJLcw5sCJM7lfwxFKXXEMOkbUmuESmQjePw8/6cx2Q1K0g==;31:/neXtZQb40F+H3+YQiFCijmdo23ZldKxCX1xRJvuFgtmAWPwx0GmXW1wL7UyrrGcEESNeHoCL30kfuYuAUddnAAEoSIIK/8ixcZHGUaosBGzfwSry0rtV/ZcWFszVvOUmABUxwoPDjJRc8TNbbkhWOp4N+l8j0ZJd0hTezTSURBwUb4W6NC7fHMY9pz2EioW4rezeyCY+dt8Qn6t6ztAwSfk7xeZIjd1MoIMPAquYZs= X-MS-TrafficTypeDiagnostic: DBXPR07MB319: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;20:QLScwByeJOkXUE3v/uy0g+aYxL4v45RoI+1jQNJQ2JUdpHVwhQRuqYyRyxtC6uHFnPS8Mcv+2Jao3QEIT+2G80zb1dPVKfclTRE8Mb0e4iLKBIpDt26VEFneLOOhTvE7Fvu5Hc5EvGl6F20aZl+0nakE9H7zzikkMlPbYL8UW4er5c17RmD5z/NgbDoqHjXtFt2Lk9G9Zz5FRdZg4Ozw2s9ZZVE8xOFW+YYoAoEBW5vRgrv+RbxeJFWh6HztSFdDnwH4LknKRi8SN2Bd+QTdyxiLfyQCq54vZsqjtudawHuIQFw6YlAgVB1ny3n3KKdHx2WuDNbrmtFChXoiUdpXEhICaJA9T1Ve0Ocy2zYfW0u2a60zCHsz/rIoPUx2Ee+bWNlugTpitMbS13j25WSg6j4RlwaJ9d7iFqGf7iWunfL+srjiCnHdXkf+qhbj0LI0D3cjp8u/R4TKaX8T7zPkpmn40TAe1b8TzoCJLjHwvLaoo5xWPpwdneh1ywmlJb+0;4:G7niF2MDrT8wZg7czhJ7luD7L0kAzVbs1Cmio0fLCDEfvxcxISp+7iZJP9c9uhRfv+EEWqcsJYnJKpe5ygIYCzKnBp5PX8cRZYK3ka8BmtYXIPuyQQLa6Piiw6tVBHYtBWsOU2lqWHRQ7QJPN3evg7Dft64RwH5vcLbDGfhbqOEVKvBfIlh47Ym4KLV10epY8cREer2WXMR33kGOdB1xvHyTPUlR3hjCD62VoxA8JYlJ8C05N0sjZWTizBn2bhWWEtZOsGWKQJLARyJPAi5HjQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231023)(2400036)(944501161)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011);SRVR:DBXPR07MB319;BCL:0;PCL:0;RULEID:(100000803126)(100110400120);SRVR:DBXPR07MB319; X-Forefront-PRVS: 0554B1F54F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6049001)(346002)(39860400002)(376002)(366004)(39380400002)(396003)(24454002)(199004)(189003)(377424004)(230700001)(31696002)(16526018)(25786009)(64126003)(68736007)(26005)(49976009)(47776003)(65956001)(65806001)(66066001)(305945005)(6246003)(3846002)(7736002)(6116002)(31686004)(83506002)(478600001)(36756003)(50466002)(86362001)(5660300001)(105586002)(65826007)(16576012)(52146003)(52116002)(2486003)(6486002)(81156014)(59450400001)(8676002)(229853002)(316002)(106356001)(58126008)(8936002)(2906002)(53936002)(81166006)(76176011)(53546011)(23676004)(386003)(97736004)(2950100002)(6666003)(78286006)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB319;H:[100.94.230.5];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMTk7MjM6RXQxNmUycm9lTjJNSnhud3BvZk1kRFVLa2hk?= =?utf-8?B?VjRPaDMyL00yY291ajF4MWJPOWpXblVDRWtNdE1ySDI3T0IvK3JZenhpZDAz?= =?utf-8?B?ZmFTWlMxK01XMVhsU3hoNGVhRWJQRTVOanNQK2F1Qys1Y0VlcTlPUnBmYU1K?= =?utf-8?B?cTg5NjdETXJjTlBoNjExQlZjZWlWQ01WZGtMNy9DM2VkSFdYU3R0UDRyWS80?= =?utf-8?B?cXFPSGZIcG5Od0tkeUVXYXpoTVp3aE92dG0zZXBhRGViUWRMc3JYRW12K0d4?= =?utf-8?B?clJZbUZhelFOcTJwUjF0TFZUWEVZWmVaN20vR3RQZXoxQ2hRM3I4c1E1bVh2?= =?utf-8?B?MXg1VC8yY2tKUXlOWFhmckdROFRLNWJCdHFMZnpWdXMrNHJaMnVxamNnKzlD?= =?utf-8?B?TTFQeVdTd3FtU0UxbFpSTWMwY2dCazJsQjloQS85S2dqODBWZSt3S2FKZ2tZ?= =?utf-8?B?Qi9adE54MU1sUVlUdTJXQzFSbGJ1VlBYTmxFS2wrWFZZWHA1cXZKblUxSVBF?= =?utf-8?B?bm5yakdLdzBsQ0FUd0VIQ2hpaWpxRG9LeFU0dzVLbnZHSUQwb2tZblNKVFJJ?= =?utf-8?B?MHp3YkpNNW0veFdSRlhTb2F0cDhXWmluV2pJWUZlYWwzZ3JnZzdZc0s1ajRW?= =?utf-8?B?dDUrYzhWemJ2UkdLVkJYb0ZCb1ZrQXdGU2Z4c3A5UnpWbmoyd1RTU04zVmNJ?= =?utf-8?B?c2h6U0tMUFFLZ3llVitETlNnQ09sUU52eHR3aWsxbWJ3Rm1vMW1QQWdLN05h?= =?utf-8?B?TFpTTzVDKzZpSFFkWDdPYUdzK1NWSHhXZHM5cThOcTRFeDB2Sjc4aEtjMHZs?= =?utf-8?B?Y2NYcWxEZ0VMVS9OLzFGYUFrOFNsQUVUU1JZUEdnYy9VTWFXejBMdWdBSnU5?= =?utf-8?B?RGE5QWYxMlUzSitwbEpHeFNLM2FwVnhXN3FmcWRKTVNVUk8xVHJ3MkY5UG5M?= =?utf-8?B?MjdRNGdENmZFV3Y2ajR2Q0RReXFuRWw0UUJRd1FpUzBsQlAxYVZON3h2Nncr?= =?utf-8?B?YmlMSWV4L3lsOHRRNlRCQ2Q3V21mWlN1aGcxNWtFbkVnM2hhelFnVkd0M3Z6?= =?utf-8?B?YmtGdlNyM2twTFl6OERVZmZVbHh0VVRUeUpxV0twYzJGazd0ZTU5dHEyUk51?= =?utf-8?B?b1VRdTdVYlBkYnMzR1F5bjFVTXpFc3NXeCtUTDYyNWRqSzRMYXVyd254aUNo?= =?utf-8?B?bUU3V2VOMXhTQ2piUzdrR0tkZVB3czhJRjZLOXhscHUxdEZEYXZma3VsQmFT?= =?utf-8?B?VkhhNWZ5NFpqK25OTnJ5US9FZ1N5aHNWRFFIVitoeHlkL1NJNG5Sckcrd3Yv?= =?utf-8?B?OUZHbUNKbGovWDhScUlLNlUwelBMdVBSNm9Rd28yNVhUcnU5RzFidkNXRm5Q?= =?utf-8?B?THRJdGs4bFR3YWFtd0Iya0E4MFZyblFhbmkranA0eVZIdEN2Q2VDblVORXE3?= =?utf-8?B?VzhGRXRzalF4U3l3N25wQ3JQWURxUWEwbmNrajVJQWc1NUhOUU4rL1hpWEs2?= =?utf-8?B?UDQ3VlhYUVphMUwwcUZ0V0w3Ny9OYWRTV2ErbTlzaWcvUy9pK0JQT3A4Nm1O?= =?utf-8?B?ZmViVmdycytPbSsxMjJwM2JyWS91Ulhnbm9pSy9rRnRLa2lqSHhEYjlRQ01Y?= =?utf-8?B?SnovRGUwOERrWXFBdUV0MW1YcnFramozdkhOVTV6R2M2SUFUSi9maXdqaHMx?= =?utf-8?B?NHh2d3JyM1dwMGwwcGdNQmh2dktsVGhvTFpPaDNNN0NUakpWUGJSTityZWlD?= =?utf-8?B?Rkl2dU12d2gxYXUya2xzRjJIdGlPdkM0RHMreGsyQkp6NWZZeUhCL2FYYW1D?= =?utf-8?B?djhWT1BYeUhKUzB3NWFyNXlhL05rcmNVMmlSL2NkaDV1NnQxNTY0SFBrSU1R?= =?utf-8?B?U0xHeUVVeHZqaGM5MVY0czJOZlQ4ZW5RVlBxcGdqejliQzFOTXVsdk1kREhr?= =?utf-8?B?cnpIZnFwcjFYcGE5cXJZSE5NMHRiWHBWdEZjdUNLdFpkUTZMUlhteEV6a0Vj?= =?utf-8?B?UzZ1dmZYNWRBdEZERnlEVi9sQ0ZKUTRHNEpBPT0=?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;6:hyNlfkXFGiKWNolYrnZuM3rQi5chx4UdC740vXllP0pFtC13sWVn7+IvpjVbSvy55B3SUnVWmixk7qgugUJwPgMvAj8L/cBExG35bZ5afHCP1f9qZpOdx+HCWF7qhwqk03PxkU6LDA6npBFS1yqpXBSOyu3JkjkX0AQmoyzLxSOa+R8FOaYKD93LuwtImqq0n63Oia04n9NUesbIDyKxNhBRRLvy2eCmK0tcm65HFJ7/q20Gtnnnpjmmidogl9uuX4zm4MoxSebjXpFAx8qSrvNezaB9zuy6jlDgg9/Jn7Mj41tsb7v3nNvbHc/ZUHLf6gRs1RKYdlUJY/XX/07/cX+rz8jdv5ZGTDN/UnNhFRY=;5:1ZndFGpyS043BvkLV22JFyhFH+lPNcBBCCYPYeU8hQWHU2HtmKWmVg5RqHSLW2sjEgB+1bn6FYAd5GufJsouYZZVFoyDU5K++cHdVfckgkydbSCWlB4mmCCI6wANGbGS+HbOsvCW3dH26QOmQdCs4T4aMygAxxPMa88lvfXlGrM=;24:5w3Hd43BpPpjmVczOJ7ZmsGF0eqeRGix4d1qPHFsjsHgkEe0UEezB5HFrDPQHWdSGXoY/yJmqZQLEmyIFVrc8zEYQc7SiMxibXYsrJ/g3sg=;7:U1iylYkZPGY/aEPuce5q6/L16usldsVpbde6mY4NOc6s1bkIuTVzX6tEwQ+4w8RpjzhhVjgs6fZHS931pQmYcHdAv0evACg9CnOb5L7DxDFMRBNTw2rFwGZ19hxF9oE2Y9fWomfQtXKLQI1rRFpbI/OTa2YU1Qa1z2s02pLXZGVwbxYJdhnyxcsGVf+bXTk9bmhDqY801oc78Wr/l9U0Z9ksakPDuPByj1jRiYCjZSiTIADSXi0NFmLuBnmdDIyq SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2018 15:29:12.0225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad3f0e0b-2c08-4652-55a7-08d55cf5e5a6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB319 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00299.txt.bz2 On 2018-01-05 07:26 PM, Tom Tromey wrote: > This changes the type of dwarf2_cu::method_info and fixes up the uses. > In order to remove cleanups from process_full_comp_unit and > process_full_type_unit, psymtab_include_file_name also had to be > changed to avoid leaving dangling cleanups. That seems ok, but I don't completely understand what's happening. Can you clarify how process_full_comp_unit/process_full_type_unit are related to psymtab_include_file_name? I don't see how the later gets called by the formers. Simon