From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24738 invoked by alias); 6 Dec 2004 03:45:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24709 invoked from network); 6 Dec 2004 03:45:43 -0000 Received: from unknown (HELO marvin.codito.net) (203.197.88.2) by sourceware.org with SMTP; 6 Dec 2004 03:45:43 -0000 Received: from webmail.codito.com (localhost [127.0.0.1]) by marvin.codito.net (8.13.1/8.13.1/Debian-17) with ESMTP id iB643kfW014467; Mon, 6 Dec 2004 09:33:48 +0530 Received: from 203.212.198.34 (SquirrelMail authenticated user ramana.radhakrishnan); by webmail.codito.com with HTTP; Mon, 6 Dec 2004 09:33:48 +0530 (IST) Message-ID: <32820.203.212.198.34.1102305828.squirrel@webmail.codito.com> In-Reply-To: <20041205191152.GA20357@nevyn.them.org> References: <41B35793.5010602@codito.com> <20041205191152.GA20357@nevyn.them.org> Date: Mon, 06 Dec 2004 03:51:00 -0000 Subject: Re: [PATCH] Fix for PR exp/1821 From: "Ramana Radhakrishnan" To: "Daniel Jacobowitz" Cc: "Ramana Radhakrishnan" , gdb-patches@sources.redhat.com, cagney@gnu.org Reply-To: ramana.radhakrishnan@codito.com User-Agent: SquirrelMail/1.4.3a MIME-Version: 1.0 Content-Type: multipart/mixed;boundary="----=_20041206093348_92010" X-SW-Source: 2004-12/txt/msg00151.txt.bz2 ------=_20041206093348_92010 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Content-length: 628 Hi Daniel, > > Yes, this is OK, with a couple of formatting corrections (see below). > Do you think you could add a testcase for this problem? Corrected the formatting errors and added a testcase for this. gdb.base/gdb1821.c / gdb1821.exp . Ok to commit ? regards Ramana ChangeLog: 2004-12-06 Ramana Radhakrishnan PR exp/1821 * cp_valprint.c(cp_print_value_fields): Include language.h . Pass current_language to fprintf_symbol_filtered * testsuite/gdb.base/gdb1821.c: New test file * testsuite/gdb.base/gdb1821.exp: New test file ---- Ramana Radhakrishnan Codito Technologies ------=_20041206093348_92010 Content-Type: application/octet-stream; name="gdb1821patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="gdb1821patch" Content-length: 5499 LS0tIC9kZXYvbnVsbAkyMDAzLTA5LTE1IDE5OjEwOjQ3LjAwMDAwMDAwMCAr MDUzMAorKysgdGVzdHN1aXRlL2dkYi5iYXNlL2dkYjE4MjEuZXhwCTIwMDQt MTItMDYgMDk6MDc6NDYuOTI1MTgyMTA0ICswNTMwCkBAIC0wLDAgKzEsNDkg QEAKKyMgQ29weXJpZ2h0IDIwMDMgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u LCBJbmMuCisKKyMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlv dSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKyMgaXQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z ZSBhcyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRh dGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IKKyMg KGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyMgCisjIFRo aXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0 IHdpbGwgYmUgdXNlZnVsLAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7 IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJD SEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBP U0UuICBTZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZv ciBtb3JlIGRldGFpbHMuCisjIAorIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2 ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQor IyBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbTsgaWYgbm90LCB3cml0ZSB0byB0 aGUgRnJlZSBTb2Z0d2FyZQorIyBGb3VuZGF0aW9uLCBJbmMuLCA1OSBUZW1w bGUgUGxhY2UgLSBTdWl0ZSAzMzAsIEJvc3RvbiwgTUEgMDIxMTEtMTMwNywg VVNBLiAgCisKKyMgVGVzdHMgZm9yIFBSIGdkYi8xODIxLgorIyAyMDA0LTEy LTA2ICBSYW1hbmEgUmFkaGFrcmlzaG5hbiA8cmFtYW5hLnJhZGhha3Jpc2hu YW5AY29kaXRvLmNvbT4KKworIyBUaGlzIGZpbGUgaXMgcGFydCBvZiB0aGUg Z2RiIHRlc3RzdWl0ZS4KKworaWYgJHRyYWNlbGV2ZWwgdGhlbiB7CisgICAg ICAgIHN0cmFjZSAkdHJhY2VsZXZlbAorICAgICAgICB9CisKKyMKKyMgdGVz dCBydW5uaW5nIHByb2dyYW1zCisjCitzZXQgcHJtc19pZCAwCitzZXQgYnVn X2lkIDAKKworc2V0IHRlc3RmaWxlICJnZGIxODIxIgorc2V0IHNyY2ZpbGUg JHt0ZXN0ZmlsZX0uYworc2V0IGJpbmZpbGUgJHtvYmpkaXJ9LyR7c3ViZGly fS8ke3Rlc3RmaWxlfQorCitpZiAgeyBbZ2RiX2NvbXBpbGUgIiR7c3JjZGly fS8ke3N1YmRpcn0vJHtzcmNmaWxlfSIgIiR7YmluZmlsZX0iIGV4ZWN1dGFi bGUge2RlYnVnfV0gIT0gIiIgfSB7CisgICAgIGdkYl9zdXBwcmVzc19lbnRp cmVfZmlsZSAiVGVzdGNhc2UgY29tcGlsZSBmYWlsZWQsIHNvIGFsbCB0ZXN0 cyBpbiB0aGlzIGZpbGUgd2lsbCBhdXRvbWF0aWNhbGx5IGZhaWwuIgorfQor CitnZGJfZXhpdAorZ2RiX3N0YXJ0CitnZGJfbG9hZCAke2JpbmZpbGV9CisK K2lmICFbcnVudG8gbWFpbl0gdGhlbiB7CisgICAgcGVycm9yICJjb3VsZG4n dCBydW4gdG8gYnJlYWtwb2ludCIKKyAgICBjb250aW51ZQorfSAKK2dkYl90 ZXN0ICJwcmludCAveCBiYXIiICJ7eF9fMCA9IDB4MCwgeV9fMCA9IDB4MCwg el9fMSA9IDB4MH0iIAorCi0tLSAvZGV2L251bGwJMjAwMy0wOS0xNSAxOTox MDo0Ny4wMDAwMDAwMDAgKzA1MzAKKysrIHRlc3RzdWl0ZS9nZGIuYmFzZS9n ZGIxODIxLmMJMjAwNC0xMi0wNiAwOTowODo0NS42NDQyNTU0NDggKzA1MzAK QEAgLTAsMCArMSwyNSBAQAorLyogVGVzdCBwcmludGluZyBvZiBzdHJ1Y3R1 cmUgbWVtYmVyIG5hbWVzIGluIGdkYi4gUFIgZXhwLzE4MjEKKworICAgQ29w eXJpZ2h0IDIwMDQsIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgor CisgICBUaGlzIGZpbGUgaXMgcGFydCBvZiBHREIuCisKKyAgIFRoaXMgcHJv Z3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IgbW9kaWZ5CisgICBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQor ICAgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNp b24gMiBvZiB0aGUgTGljZW5zZSwgb3IKKyAgIChhdCB5b3VyIG9wdGlvbikg YW55IGxhdGVyIHZlcnNpb24uCisKKyAgIFRoaXMgcHJvZ3JhbSBpcyBkaXN0 cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAor ICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhl IGltcGxpZWQgd2FycmFudHkgb2YKKyAgIE1FUkNIQU5UQUJJTElUWSBvciBG SVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyAg IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMu CisKKyAgIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhl IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisgICBhbG9uZyB3aXRoIHRo aXMgcHJvZ3JhbTsgaWYgbm90LCB3cml0ZSB0byB0aGUgRnJlZSBTb2Z0d2Fy ZQorICAgRm91bmRhdGlvbiwgSW5jLiwgNTkgVGVtcGxlIFBsYWNlIC0gU3Vp dGUgMzMwLAorICAgQm9zdG9uLCBNQSAwMjExMS0xMzA3LCBVU0EuICAqLwor CitzdHJ1Y3QgZm9vIHsgZG91YmxlIHhfXzAsIHlfXzAsIHpfXzE7IH0gYmFy OworCisKK2ludCBtYWluKHZvaWQpIHsgcmV0dXJuIDA7IH0KLS0tIGNwLXZh bHByaW50LmMufjEuMjcufgkyMDA0LTEyLTA2IDAyOjI2OjMxLjAwMDAwMDAw MCArMDUzMAorKysgY3AtdmFscHJpbnQuYwkyMDA0LTEyLTA2IDA4OjM5OjI5 LjQ4NzIzMTg5NiArMDUzMApAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1ZGUg InRhcmdldC5oIgogI2luY2x1ZGUgImNwLWFiaS5oIgogI2luY2x1ZGUgInZh bHByaW50LmgiCisjaW5jbHVkZSAibGFuZ3VhZ2UuaCIKIAogaW50IHZ0Ymxw cmludDsJCQkvKiBDb250cm9scyBwcmludGluZyBvZiB2dGJsJ3MgKi8KIGlu dCBvYmplY3RwcmludDsJCS8qIENvbnRyb2xzIGxvb2tpbmcgdXAgYW4gb2Jq ZWN0J3MgZGVyaXZlZCB0eXBlCkBAIC0zMTcsMTEgKzMxOCwxMSBAQAogCSAg ICAgIGlmIChUWVBFX0ZJRUxEX1NUQVRJQyAodHlwZSwgaSkpCiAJCWZwdXRz X2ZpbHRlcmVkICgic3RhdGljICIsIHN0cmVhbSk7CiAJICAgICAgZnByaW50 Zl9zeW1ib2xfZmlsdGVyZWQgKHN0cmVhbSwgVFlQRV9GSUVMRF9OQU1FICh0 eXBlLCBpKSwKLQkJCQkgICAgICAgbGFuZ3VhZ2VfY3BsdXMsCisJCQkJICAg ICAgIGN1cnJlbnRfbGFuZ3VhZ2UtPmxhX2xhbmd1YWdlLAogCQkJCSAgICAg ICBETUdMX1BBUkFNUyB8IERNR0xfQU5TSSk7CiAJICAgICAgZnB1dHNfZmls dGVyZWQgKCJcIiBcIiIsIHN0cmVhbSk7CiAJICAgICAgZnByaW50Zl9zeW1i b2xfZmlsdGVyZWQgKHN0cmVhbSwgVFlQRV9GSUVMRF9OQU1FICh0eXBlLCBp KSwKLQkJCQkgICAgICAgbGFuZ3VhZ2VfY3BsdXMsCisJCQkJICAgICAgIGN1 cnJlbnRfbGFuZ3VhZ2UtPmxhX2xhbmd1YWdlLAogCQkJCSAgICAgICBETUdM X1BBUkFNUyB8IERNR0xfQU5TSSk7CiAJICAgICAgZnB1dHNfZmlsdGVyZWQg KCJcIikgXCIiLCBzdHJlYW0pOwogCSAgICB9CkBAIC0zMzIsNyArMzMzLDcg QEAKIAkgICAgICBpZiAoVFlQRV9GSUVMRF9TVEFUSUMgKHR5cGUsIGkpKQog CQlmcHV0c19maWx0ZXJlZCAoInN0YXRpYyAiLCBzdHJlYW0pOwogCSAgICAg IGZwcmludGZfc3ltYm9sX2ZpbHRlcmVkIChzdHJlYW0sIFRZUEVfRklFTERf TkFNRSAodHlwZSwgaSksCi0JCQkJICAgICAgIGxhbmd1YWdlX2NwbHVzLAor CQkJCSAgICAgICBjdXJyZW50X2xhbmd1YWdlLT5sYV9sYW5ndWFnZSAsCiAJ CQkJICAgICAgIERNR0xfUEFSQU1TIHwgRE1HTF9BTlNJKTsKIAkgICAgICBh bm5vdGF0ZV9maWVsZF9uYW1lX2VuZCAoKTsKIAkgICAgICAvKiBkbyBub3Qg cHJpbnQgbGVhZGluZyAnPScgaW4gY2FzZSBvZiBhbm9ueW1vdXMgdW5pb25z ICovCg== ------=_20041206093348_92010--