Re: [PATCH] Various Windows support changes

Christopher Faylor
2004-04-20T16:35:09Z

On Mon, Apr 19, 2004 at 04:37:00PM -0700, Keith Rollin wrote:
>Hello,
>
>These patches add some features and fix some bugs in gdb when running under Windows. The enclosed archive the following files requested by the gdb CONTRIBUTING file:
>
> CHANGES: a description of the changes provided by the patch
> ChangeLog: a detailed list of changes in ChangeLog format
> gdb-6.0.diff: the patch

There is a lot of good work here and most of it looks worthwhile.

A few points:

1) It is a fairly large patch involving a few distinct fixes.
It is much easier to review and install one patch which addresses
one problem than it is to review one gigantic patch which addresses
n problems. Would you consider sending this as multiple patches?

2) Please don't send compressed patches here. Just send your patch
and ChangeLog as plain text.

3) Please send patches against CVS rather than a gdb release.
Patches generated against CVS are more likely to apply cleanly.
As it turns out, your patch installed ok with the exception of
your change to version.in. However, it is always a little more
comforting to see a patch apply without the fuzz and offset warnings
from patch.

4) It doesn't look like Palm has an assignment with the FSF.
Jim? Can you send him an assignment form?

5) The ChangeLog is a little non-standard.
Please use capitalization and present tense, i.e., "Add TEMP and TMP" rather
than "added TEMP and TEMP".

I do appreciate all of the work that went into this patch. The only
real stumbling block here is the lack of an FSF assignment.

cgf