Re: [PATCH] Various Windows support changes

Keith Rollin
2004-04-21T20:43:23Z

Christopher,

Thanks for the reply. My responses are below:

At 12:35 PM -0400 4/20/04, Christopher Faylor wrote:
>1) It is a fairly large patch involving a few distinct fixes.
> It is much easier to review and install one patch which addresses
> one problem than it is to review one gigantic patch which addresses
> n problems. Would you consider sending this as multiple patches?

I remember reading that recommendation in the CONTRIBUTE document,
but it wasn't clear to me how to provide multiple patches. I don't
know how to create them -- how do I separate my changes?

>2) Please don't send compressed patches here. Just send your patch
> and ChangeLog as plain text.

OK. The CONTRIBUTE document said "We accept patches as ... gzipped
text", so I thought what I did was OK.

>3) Please send patches against CVS rather than a gdb release.
> Patches generated against CVS are more likely to apply cleanly.
> As it turns out, your patch installed ok with the exception of
> your change to version.in. However, it is always a little more
> comforting to see a patch apply without the fuzz and offset warnings
> from patch.

I was leery of sending in patches against gdb 6.0, especially when
6.1 had just been released. However, I've never used CVS, and so
don't know how to perform what you ask. If needed, of course, I
could learn.

>4) It doesn't look like Palm has an assignment with the FSF.
> Jim? Can you send him an assignment form?

The CONTRIBUTE document said that I could get a form from some cited
web site, but I was unable to actually find the form. In lieu of
that, the CONTRIBUTE document said that such a form was not necessary
for small fixes, for which I'd hoped my changes qualified. If not,
I'll look for Jim to send me an assignment form.

>5) The ChangeLog is a little non-standard.
> Please use capitalization and present tense, i.e., "Add TEMP and
>TMP" rather
> than "added TEMP and TEMP".

Thanks. I'll keep that in mind.

>I do appreciate all of the work that went into this patch. The only
>real stumbling block here is the lack of an FSF assignment.

At this point, it's not clear to me if your points above are advice
for any subsequent submissions, or if I need to address them for this
submission. You noted that you'd already applied the patch, so I'm
thinking the former. But if the latter, then let me know and I'll
tweak things.

In either case, I'll look for the assignment for to arrive and get it
back to you. I'll assume that instructions on what to do with the
form after I'm done with it will come with the form.