From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110293 invoked by alias); 25 Aug 2017 10:44:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110275 invoked by uid 89); 25 Aug 2017 10:44:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:484 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Aug 2017 10:44:31 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8EE4DC059741; Fri, 25 Aug 2017 10:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8EE4DC059741 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9602C7B9CF; Fri, 25 Aug 2017 10:44:28 +0000 (UTC) Subject: Re: [PATCH v2] break gdb build on 32-bit host with ADI support To: Simon Marchi References: <1503624784-124602-1-git-send-email-weimin.pan@oracle.com> Cc: Weimin Pan , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <324d58a9-bb58-881c-ea21-88177244ca97@redhat.com> Date: Fri, 25 Aug 2017 10:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00487.txt.bz2 On 08/25/2017 11:33 AM, Simon Marchi wrote: > Since it's not trivial, I would suggest putting this operation in its > own function and adding a unit-test for it. Definitely agreed with a unit-test. I suggest splitting the sign extension fix to a follow up patch, so that we can restore --enable-targets=all builds/bots quickly. The rest of the patch LGTM, though we're missing a ChangeLog entry. Thanks, Pedro Alves