From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed 0/2] Fix test-cp-name-parser build
Date: Tue, 12 Mar 2019 17:23:00 -0000 [thread overview]
Message-ID: <322a3b37-e134-e6e7-92b5-aa900c337fc6@redhat.com> (raw)
In-Reply-To: <87k1h43to0.fsf@tromey.com>
On 03/12/2019 05:10 PM, Tom Tromey wrote:
> Pedro> I'm pondering what could we do to avoid these kinds of regressions.
> Pedro> We could make the buildbot always build these utilities too. Maybe
> Pedro> even better, add some testsuite testcase that smoke-tests
> Pedro> test-cp-name-parser.
>
> We could migrate this to use the unit test framework and just not have a
> separate executable.
Oh that might be even better, indeed.
I recall using the executable for quick experimentation when I was
working on the wildmatching stuff, but I think hacking in a unit
test for experimentation would have worked well enough too.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-03-12 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 17:03 Pedro Alves
2019-03-12 17:03 ` [pushed 2/2] Fix test-cp-name-parser build, parser_fprintf undefined Pedro Alves
2019-03-12 17:03 ` [pushed 1/2] Fix test-cp-name-parser build, unused variable Pedro Alves
2019-03-12 17:10 ` [pushed 0/2] Fix test-cp-name-parser build Tom Tromey
2019-03-12 17:23 ` Pedro Alves [this message]
2019-03-12 17:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=322a3b37-e134-e6e7-92b5-aa900c337fc6@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox