From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21966 invoked by alias); 21 Nov 2012 15:39:33 -0000 Received: (qmail 21841 invoked by uid 22791); 21 Nov 2012 15:39:30 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mailout3.samsung.com (HELO mailout3.samsung.com) (203.254.224.33) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Nov 2012 15:39:25 +0000 Received: from epcpsbge2.samsung.com (epcpsbge2 [203.254.230.12]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MDU00M5AGTJ2XB0@mailout3.samsung.com> for gdb-patches@sourceware.org; Thu, 22 Nov 2012 00:39:22 +0900 (KST) Received: from epcpsbge2.samsung.com ( [172.20.52.123]) by epcpsbge2.samsung.com (EPCPMTA) with SMTP id D2.F0.13663.AA5FCA05; Thu, 22 Nov 2012 00:39:22 +0900 (KST) Received: from epextmailer03 ( [203.254.219.153]) by epcpsbge2.samsung.com (EPCPMTA) with SMTP id B2.F0.13663.AA5FCA05; Thu, 22 Nov 2012 00:39:22 +0900 (KST) Date: Wed, 21 Nov 2012 15:39:00 -0000 From: KARTHIKVENKATESH BHAT Subject: Re: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary To: Pedro Alves , Mark Kettenis Cc: "gdb-patches@sourceware.org" Reply-to: kv.bhat@samsung.com MIME-version: 1.0 X-MTR: 20121121151521142@kv.bhat Msgkey: 20121121151521142@kv.bhat X-EPLocale: en_US.windows-1252 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20121121151521142@kv.bhat X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N Content-transfer-encoding: base64 Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <32244670.52091353512361480.JavaMail.weblogic@epml02> DLP-Filter: Pass X-CFilter-Loop: Reflected Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00568.txt.bz2 VGhhbmtzIFBlZHJvL01hcmsuIEFwcG9sb2dpZXMgZm9yIHRoZSBidWlsZCBi cmVhay4gSSdtIGEgYml0IG5ldyB0byBHREIgY29tbXVuaXR5IHdpbGwgdGFr ZSBjYXJlIG9mIGl0IGZyb20gbmV4dCB0aW1lLg0KSSBoYXZlIGZpeGVkIHRo ZSB3YXJuaW5nIHJlc3VsdGluZyBpbiBlcnJvciBhbmQgbW9kaWZpZWQgdGhl IGluZGVudGF0aW9uIC0NCkxldCBtZSBhbHNvIHRyeSB0byBleHBsYWluIHRo ZSBmaXggYSBiaXQgbW9yZS4gDQoNCkluZGV4OiBDaGFuZ2VMb2cNCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2Ri L0NoYW5nZUxvZyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTQ4NDkNCmRp ZmYgLXUgLXAgLXIxLjE0ODQ5IENoYW5nZUxvZw0KLS0tIENoYW5nZUxvZwky MSBOb3YgMjAxMiAxNDowOTowMyAtMDAwMAkxLjE0ODQ5DQorKysgQ2hhbmdl TG9nCTIxIE5vdiAyMDEyIDE1OjExOjQ3IC0wMDAwDQpAQCAtMSwzICsxLDkg QEANCisyMDEyLTExLTIwICBLYXJ0aGlrIEJoYXQgIDxrdi5iaGF0QHNhbXN1 bmcuY29tPg0KKw0KKwkqIGkzODYtdGRlcC5jIChpMzg2X3NraXBfcHJvbG9n dWUpOiBTZWUgaWYgd2UNCisJY2FuIGRldGVybWluZSB0aGUgZW5kIG9mIHRo ZSBwcm9sb2d1ZSB2aWEgdGhlIHN5bWJvbCB0YWJsZS4NCisJSWYgc28gdXNl IHRoZSBzYW1lIGluc3RlYWQgb2YgZ29pbmcgdGhyb3VnaCBwcm9sb2d1ZSBp bnN0cnVjdGlvbnMuDQorDQogMjAxMi0xMS0yMSAgWWFvIFFpICA8eWFvQGNv ZGVzb3VyY2VyeS5jb20+DQogDQogCVBSIHRkZXAvNzQzOA0KSW5kZXg6IGkz ODYtdGRlcC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTog L2N2cy9zcmMvc3JjL2dkYi9pMzg2LXRkZXAuYyx2DQpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuMzY0DQpkaWZmIC11IC1wIC1yMS4zNjQgaTM4Ni10ZGVwLmMN Ci0tLSBpMzg2LXRkZXAuYwkyMSBOb3YgMjAxMiAxNDowOToxMCAtMDAwMAkx LjM2NA0KKysrIGkzODYtdGRlcC5jCTIxIE5vdiAyMDEyIDE1OjExOjQ4IC0w MDAwDQpAQCAtMTU4Miw2ICsxNTgyLDI3IEBAIGkzODZfc2tpcF9wcm9sb2d1 ZSAoc3RydWN0IGdkYmFyY2ggKmdkYmENCiAgIENPUkVfQUREUiBwYzsNCiAg IGdkYl9ieXRlIG9wOw0KICAgaW50IGk7DQorICBDT1JFX0FERFIgZnVuY19h ZGRyOw0KKw0KKyAgaWYgKGZpbmRfcGNfcGFydGlhbF9mdW5jdGlvbiAoc3Rh cnRfcGMsIE5VTEwsICZmdW5jX2FkZHIsIE5VTEwpKQ0KKyAgICB7DQorICAg ICAgQ09SRV9BRERSIHBvc3RfcHJvbG9ndWVfcGMNCisJPSBza2lwX3Byb2xv Z3VlX3VzaW5nX3NhbCAoZ2RiYXJjaCwgZnVuY19hZGRyKTsNCisgICAgICBz dHJ1Y3Qgc3ltdGFiICpzID0gZmluZF9wY19zeW10YWIgKGZ1bmNfYWRkcik7 DQorDQorICAgICAgLyogR0NDIGFuZCBjbGFuZyBhbHdheXMgZW1pdHMgYSBs aW5lIG5vdGUgYmVmb3JlIHRoZSBwcm9sb2d1ZSBhbmQgYW5vdGhlcg0KKwkg b25lIGFmdGVyLCBldmVuIGlmIHRoZSB0d28gYXJlIGF0IHRoZSBzYW1lIGFk ZHJlc3Mgb3Igb24gdGhlDQorCSBzYW1lIGxpbmUuICBUYWtlIGFkdmFudGFn ZSBvZiB0aGlzIHNvIHRoYXQgd2UgZG8gbm90IG5lZWQgdG8NCisJIGtub3cg ZXZlcnkgaW5zdHJ1Y3Rpb24gdGhhdCBtaWdodCBhcHBlYXIgaW4gdGhlIHBy b2xvZ3VlLiAgV2UNCisJIHdpbGwgaGF2ZSBwcm9kdWNlciBpbmZvcm1hdGlv biBmb3IgbW9zdCBiaW5hcmllczsgaWYgaXQgaXMNCisJIG1pc3NpbmcgKGUu Zy4gZm9yIC1nc3RhYnMpLCBhc3N1bWluZyB0aGUgR05VIHRvb2xzLiAgKi8N CisgICAgICBpZiAocG9zdF9wcm9sb2d1ZV9wYw0KKwkgICYmIChzID09IE5V TEwNCisJICAgICAgfHwgcy0+cHJvZHVjZXIgPT0gTlVMTA0KKwkgICAgICB8 fCBzdHJuY21wIChzLT5wcm9kdWNlciwgIkdOVSAiLCBzaXplb2YgKCJHTlUg IikgLSAxKSA9PSAwIA0KKwkgICAgICB8fCBzdHJuY21wIChzLT5wcm9kdWNl ciwgImNsYW5nICIsIHNpemVvZiAoImNsYW5nICIpIC0gMSkgPT0gMCkpDQor CXJldHVybiBtYXggKHN0YXJ0X3BjLCBwb3N0X3Byb2xvZ3VlX3BjKTsNCisg ICAgfQ0KIA0KICAgY2FjaGUubG9jYWxzID0gLTE7DQogICBwYyA9IGkzODZf YW5hbHl6ZV9wcm9sb2d1ZSAoZ2RiYXJjaCwgc3RhcnRfcGMsIDB4ZmZmZmZm ZmYsICZjYWNoZSk7DQoNCg0KSSB3YW50ZWQgdG8gYWRkIHRoaXMgcGF0Y2gg aW4gR0RCIHRvIGZpeCBhIHByb2JsZW0gd2hpY2ggd2UgYXJlIGN1cnJlbnRs eSBmYWNpbmcgd2hlbiB3ZSB1c2UgZ2RiIHdpdGggYmluYXJ5IGNvbXBpbGVk IHdpdGggY2xhbmcuDQpUaGUgcHJvYmxlbSBmYWNlZCBpcyBjbGFuZyBnZW5l cmF0ZXMgZnVuY3Rpb24gcHJvbG9ndWUgd2hpY2ggaXMgYSBiaXQgZGlmZmVy ZW50IGZyb20gdGhhdCBvZiBHQ0MgYXMgYSByZXN1bHQgd2hlbiB3ZSB0cnkg dG8gc2tpcCBwcm9sb2d1ZSBpbnN0cnVjdGlvbiBieSBpbnN0cnVjdGlvbiBp dCByZXN1bHRzIGluIGluY29ycmVjdCBwcm9sb2d1ZV9lbmQuDQoNClRoZXJl IGlzIG9uZSBtb3JlIG1ldGhvZCB0byBza2lwIHByb2xvZ3VlIHdoaWNoIGlz IHVzZWQgaW4gb3RoZXIgYXJjaGl0ZWN0dXJlcyBzdWNoIGFzIEFSTShhcm0t dGRlcC5jKSwgTUlQUyhtaXBzLXRkZXAuYykgZXRjLiBJbiB0aGlzIG1ldGhv ZCB3ZSB0cnkgdG8gZGV0ZXJtaW5lIHByb2xvZ3VlIGVuZCB2aWEgc3ltYm9s IHRhYmxlLg0KSWYgd2UgYXJlIHVuYWJsZSB0byBkbyB0aGlzIHdlIHRoZW4g d2UgZXhhbWluZSBpbnN0cnVjdGlvbiB0byBkZXRlcm1pbmUgcHJvbG9ndWUg ZW5kLg0KDQpBZGRlZCB0aGUgc2FtZSBmb3IgaTM4Ni4gSGVyZSB3ZSBhcmUg dHJ5aW5nIHRvIHNlZSBpZiB3ZSBjYW4gcmVzb2x2ZSBwcm9sb2d1ZSBlbmQg ZnJvbSBzeW1ib2wgdGFibGUuIA0KVGhpcyB3aWxsIGF2b2lkIGluc3RydWN0 aW9uIGJ5IGluc3RydWN0aW9uIGV4YW1pbmluZyB0byBkZXRlcm1pbmUgcHJv bG9ndWUgZW5kIGlmIHdlIGFyZSBhYmxlIHRvIGRldGVybWluZSBpdCB0aHJv dWdoIHN5bWJvbCB0YWJsZS4NCg0KVGhhbmtzDQoNCi0tLS0tLS0gT3JpZ2lu YWwgTWVzc2FnZSAtLS0tLS0tDQpTZW5kZXIgOiBQZWRybyBBbHZlczxwYWx2 ZXNAcmVkaGF0LmNvbT4NCkRhdGUgOiBOb3YgMjEsIDIwMTIgMjM6MTAgKEdN VCswOTowMCkNClRpdGxlIDogUmU6IFtQQVRDSF0gRml4IGZvciBpbmNvcmVj dCBicmVha3BvaW50IHNldCBpbiBjYXNlIG9mIGNsYW5nIGNvbXBpbGVkIGJp bmFyeQ0KDQpPbiAxMS8yMS8yMDEyIDAxOjIwIFBNLCBNYXJrIEtldHRlbmlz IHdyb3RlOg0KDQo+IFBsZWFzZSBiYWNrIGl0IG91dC4NCg0KU2luY2UgdGhp cyBicmVha2luZyB0aGUgYnVpbGQgSSB3ZW50IGFoZWFkIGFuZCByZXZlcnRl ZCBpdC4NCg0KLS0gDQpQZWRybyBBbHZlcw== >From gdb-patches-return-96131-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Nov 21 15:43:00 2012 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 31772 invoked by alias); 21 Nov 2012 15:42:59 -0000 Received: (qmail 31688 invoked by uid 22791); 21 Nov 2012 15:42:56 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MISSING_HEADERS,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Nov 2012 15:42:44 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qALFghji019179 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 Nov 2012 10:42:44 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qALFggw3017318 for ; Wed, 21 Nov 2012 10:42:43 -0500 Message-ID: <50ACF672.7060607@redhat.com> Date: Wed, 21 Nov 2012 15:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Rename breakpoints_changed to annotate_breakpoints_changed. References: <20121120175437.10351.80391.stgit@brno.lan> In-Reply-To: <20121120175437.10351.80391.stgit@brno.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2012-11/txt/msg00569.txt.bz2 Content-length: 820 On 11/20/2012 05:54 PM, Pedro Alves wrote: > This is the only extern function in annotate.c that doesn't have the > "annotate_" prefix. > > This function should probably be replaced by use of > observer_notify_breakpoint_modified, but meanwhile, FYI: The reason I'm looking at annotation code is that I made a change that puts software single-step breakpoints in the regular breakpoint chain, and then that triggers breakpoints-invalid annotations for each sss breakpoint that didn't happen before, and in turn that leads to the gdb.log getting filled up with useless notifications and the tests timing out. I had a small patch to handle this, but it turns out incomplete. Further looking at this issue, I've decided to go ahead and fully convert the breakpoints-invalid annotation to observers. -- Pedro Alves