From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11656 invoked by alias); 8 Dec 2017 12:22:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11646 invoked by uid 89); 8 Dec 2017 12:22:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 12:22:28 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 738A85F15B; Fri, 8 Dec 2017 12:22:27 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA72E18ECE; Fri, 8 Dec 2017 12:22:26 +0000 (UTC) Subject: Re: [PATCH 1/3] Clear non-significant bits of address on memory access To: Yao Qi , gdb-patches@sourceware.org References: <1512727471-30745-1-git-send-email-yao.qi@linaro.org> <1512727471-30745-2-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <31f27d40-a931-c996-09d5-f60f77ac6ca3@redhat.com> Date: Fri, 08 Dec 2017 12:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1512727471-30745-2-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00179.txt.bz2 On 12/08/2017 10:04 AM, Yao Qi wrote: > --- a/gdb/aarch64-linux-tdep.c > +++ b/gdb/aarch64-linux-tdep.c > @@ -1217,6 +1217,8 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > set_xml_syscall_file_name (gdbarch, "syscalls/aarch64-linux.xml"); > set_gdbarch_get_syscall_number (gdbarch, aarch64_linux_get_syscall_number); > > + set_gdbarch_significant_addr_bit (gdbarch, 56); > + I think adding the comment about "tag" here would be nice. The top bits of an address are known as the "tag" and are ignored by the kernel, the hardware, etc. and can be regarded as additional data associated with the address. */ set_gdbarch_significant_addr_bit (gdbarch, 56); BTW, since this is ignored by the hardware, should it be done in aarch64-tdep.c instead of just for Linux? Looks good to me otherwise. Thanks, Pedro Alves