From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: jimw@sifive.com, palmer@sifive.com, jhb@FreeBSD.org,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH 1/4] gdb/riscv: Make some target description functions constant
Date: Thu, 29 Nov 2018 16:50:00 -0000 [thread overview]
Message-ID: <31d92966588b71eefdd61411abbf3e196ad86e3f.1543509416.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1543509416.git.andrew.burgess@embecosm.com>
In-Reply-To: <cover.1543509416.git.andrew.burgess@embecosm.com>
Makes more of the interface related to fetching target descriptions
constant.
gdb/ChangeLog:
* arch/riscv.h (riscv_create_target_description): Make return type
const.
* arch/riscv.c (riscv_create_target_description): Likewise.
* riscv-tdep.c (riscv_find_default_target_description): Likewise.
---
gdb/ChangeLog | 7 +++++++
gdb/arch/riscv.c | 2 +-
gdb/arch/riscv.h | 2 +-
gdb/riscv-tdep.c | 2 +-
4 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/gdb/arch/riscv.c b/gdb/arch/riscv.c
index ca2238d5d70..cb715fabb1f 100644
--- a/gdb/arch/riscv.c
+++ b/gdb/arch/riscv.c
@@ -26,7 +26,7 @@
/* See arch/riscv.h. */
-target_desc *
+const target_desc *
riscv_create_target_description (struct riscv_gdbarch_features features)
{
target_desc *tdesc = allocate_target_description ();
diff --git a/gdb/arch/riscv.h b/gdb/arch/riscv.h
index 007944019a9..ec4d5f39525 100644
--- a/gdb/arch/riscv.h
+++ b/gdb/arch/riscv.h
@@ -58,7 +58,7 @@ struct riscv_gdbarch_features
/* Create and return a target description that is compatible with
FEATURES. */
-target_desc *riscv_create_target_description
+const target_desc *riscv_create_target_description
(struct riscv_gdbarch_features features);
#endif /* ARCH_RISCV_H */
diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
index 5965a594440..d66fe5c8793 100644
--- a/gdb/riscv-tdep.c
+++ b/gdb/riscv-tdep.c
@@ -2793,7 +2793,7 @@ static const struct frame_unwind riscv_frame_unwind =
specifically the bfd object being executed, to guide the selection of a
suitable default target description. */
-static struct target_desc *
+static const struct target_desc *
riscv_find_default_target_description (const struct gdbarch_info info)
{
struct riscv_gdbarch_features features;
--
2.14.5
next prev parent reply other threads:[~2018-11-29 16:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 22:50 [RFC] gdb/riscv: Add read_description method for riscv_linux_nat_target Andrew Burgess
2018-11-28 23:37 ` Jim Wilson
2018-11-29 2:23 ` Jim Wilson
2018-11-29 16:50 ` [PATCH 3/4] gdb/riscv: Create each unique target description only once Andrew Burgess
2018-11-29 18:12 ` Pedro Alves
2018-11-29 19:17 ` Andrew Burgess
2018-11-29 22:32 ` Andrew Burgess
2018-11-30 17:07 ` Pedro Alves
2018-11-29 16:50 ` [PATCH 4/4] gdb/riscv: Add read_description method for riscv_linux_nat_target Andrew Burgess
2018-11-29 22:22 ` Jim Wilson
2018-11-29 16:50 ` [PATCH 2/4] gdb/riscv: Add equality operators to riscv_gdb_features Andrew Burgess
2018-11-29 16:50 ` Andrew Burgess [this message]
2018-11-29 16:50 ` [PATCH 0/4] Re: gdb/riscv: Add read_description method for riscv_linux_nat_target Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31d92966588b71eefdd61411abbf3e196ad86e3f.1543509416.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=jimw@sifive.com \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox