From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11579 invoked by alias); 31 Mar 2017 13:35:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11564 invoked by uid 89); 31 Mar 2017 13:35:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Mar 2017 13:35:36 +0000 Received: by simark.ca (Postfix, from userid 33) id B1DFF1E9AB; Fri, 31 Mar 2017 09:35:35 -0400 (EDT) To: Pedro Alves Subject: Re: [PATCH] gdbserver: Suffix generated C files with -generated X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 31 Mar 2017 13:35:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: References: <20170330031410.2741-1-simon.marchi@polymtl.ca> <871c88f7fe38d2dbe72900a0561a38af@polymtl.ca> Message-ID: <31bcb2d7c1adc1c77a6c1eda58a88fb2@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00541.txt.bz2 On 2017-03-31 08:23, Pedro Alves wrote: > Hi Simon, > > On 03/30/2017 04:31 AM, Simon Marchi wrote: > >>> @@ -8252,7 +8252,7 @@ $as_echo "#define USE_LIBTHREAD_DB_DIRECTLY 1" >>> >>confdefs.h >>> fi >>> >>> if test "$srv_xmlfiles" != ""; then >>> - srv_xmlbuiltin="xml-builtin.o" >>> + srv_xmlbuiltin="xml-builtin-generated.o" >> >> Hmm actually we don't need to rename this, the other .o files are not >> named -generated. You can forget changes to configure/configure.ac (I >> removed them locally). > > I'm confused on what the result will be. The patch had this in > Makefile.in, > for example: > > - version.o \ > + version-generated.o \ > > Can you post the updated patch? Ah, yes, same mistake with that one. It probably shouldn't change as well (although it would still work). To explain the mistake, I first started changing the pattern to have: foo-generated.c -> foo-generated.o But then realized I would have to change everything in configure.srv, and that would be ugly. So I decided to add the "%.o: %-generated.c" and "%-ipa.o: %-generated.c" rules instead, which allows keeping the change to a minimum. I however forgot to change version-generated.o back to version.o and xml-builtin-generated.o to xml-builtin.o. It still works, because they get picked up by the "%.o: %.c" rule. I'll post the updated patch. Simon