On 7/30/21 7:50 PM, Simon Marchi wrote:
>> Thanks for the review, and the .debug_rnglists addition.
>>
>> I've added the .debug_rnglists addition here as well, and added testing
>> the complaint when doing gdb_load $lib1, in other words, the unrelocated
>> case (which was already passing before this patch).
> 
> Thanks, this LGTM.
> 
> Note, when merging in master, you can use the Co-Authored-By tag, since
> we don't have a ChangeLog file there.
> 

Ack.

I've updated the test-case to test the complaint both during partial
symtab reading and full symtab reading, and re-tested with a variety of
target board, which required additional updates, and ran into a problem
with .gdb_index, filed as PR28159 - "[gdb/symtab] gdb generates
.gdb_index with only empty hashtable entries, then fails to recognize it
as empty".

The test-case now contains an kfail for this.  I'll submit a patch shortly.

I'm planning to look over the commit message once more tomorrow, and
then commit.

Thanks,
- Tom