Re: [PATCH][gdb/testsuite] Don't abort testrun for invalid command in test-case

Tom de Vries
2020-06-17T14:14:26Z

On 6/16/20 2:47 PM, Pedro Alves wrote:
> On 6/11/20 11:55 PM, Tom de Vries wrote:
>
>> Hmm, what is the distinction between gdb_init and default_gdb_init?
>>
>> All the other uses in gdb.exp of pattern foo/default_foo have an
>> implementation:
>> ...
>> proc foo {} {
>> [default_foo]
>> }
>> ...
>> but gdb_init is much more than that. Why is that different?
>>
>
> I don't know. I guess it shouldn't. I guess people (including me) added to
> gdb_init over time without realizing they were breaking the pattern. Maybe nobody
> notices it because whatever is overriding gdb_init renames the original one and
> then calls it.

Hmm, thanks for the explanation. I feel we need to improve this
situation somehow, but I'm not sure yet how.

Thanks,
- Tom