From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 6C0A6388E805 for ; Tue, 16 Jun 2020 12:47:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6C0A6388E805 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-xTaUQ7WbN6aE6LCiN5kiqA-1; Tue, 16 Jun 2020 08:47:15 -0400 X-MC-Unique: xTaUQ7WbN6aE6LCiN5kiqA-1 Received: by mail-wr1-f71.google.com with SMTP id f5so175518wrv.22 for ; Tue, 16 Jun 2020 05:47:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MBuku3poJNLLSSkQGodkXq0RWcAi8es5lspDBuO8Gn0=; b=CEqNimi8+E/uWpwzNEEg4RhgCzhZmC5ROUL9WmBgRQfv2oeYpSVhmXH5zsuUTumqAs xju/LyViiBRq38Y9zsOPedXs329UcAE4eJr+Gao5unXQEdTPy0Mb0jL3/SDqeklNIdYr 6Kdy/O8p7bjtmcTI644u9mV6Oz0L3eGdkOR0GXE9yKN0bz3v2sl4bEJG0my1tCo4yzMh JoaXcJUNLoTVhD7rtdL8qd+RHv10Now8L7qDXbQvqUlKmlKIo0KvM5dVjL1Y7NqyH+JA /rd7/tw/rozQeeKZIRWkgfxptTYxOeyWsfNc2V9fag2Plkj+Wa4Fe8/vLRQJuVgrVyrI uERw== X-Gm-Message-State: AOAM531VCn2JB4POzVL8ha3OUAVRibzJEtCHpIkBCra5cwfPI2DLfjcH 55mDQn93iAzVDhuCO/PRQkQXUs1psCYfFFa3NIDE72yDMiPBKIxCUMn9H+sUtSN26fRqUUcXASi T13C5aS2B+X4mT3UZJ11CIQ== X-Received: by 2002:adf:9481:: with SMTP id 1mr2895023wrr.396.1592311634112; Tue, 16 Jun 2020 05:47:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLPw/yusBWA+XmLQm1kOiJPMlqfHC5qnjkySBckLdTZ4iJdBLXP1R3KRxV7ZNDOdphv6DgOg== X-Received: by 2002:adf:9481:: with SMTP id 1mr2895010wrr.396.1592311633941; Tue, 16 Jun 2020 05:47:13 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id u3sm27530990wrw.89.2020.06.16.05.47.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 05:47:13 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Don't abort testrun for invalid command in test-case To: Tom de Vries , gdb-patches@sourceware.org References: <20200611143522.GA19667@delia> <7d7ce523-b58c-a77d-15be-8091feb6389a@redhat.com> <18e36963-4f04-f871-33fb-89a5d1683bbd@suse.de> From: Pedro Alves Message-ID: <31b0b6f2-4930-f339-0245-3a328d0d2548@redhat.com> Date: Tue, 16 Jun 2020 13:47:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2020 12:47:18 -0000 On 6/11/20 11:55 PM, Tom de Vries wrote: > Hmm, what is the distinction between gdb_init and default_gdb_init? > > All the other uses in gdb.exp of pattern foo/default_foo have an > implementation: > ... > proc foo {} { > [default_foo] > } > ... > but gdb_init is much more than that. Why is that different? > I don't know. I guess it shouldn't. I guess people (including me) added to gdb_init over time without realizing they were breaking the pattern. Maybe nobody notices it because whatever is overriding gdb_init renames the original one and then calls it. Thanks, Pedro Alves