From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103960 invoked by alias); 16 Oct 2017 22:26:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103946 invoked by uid 89); 16 Oct 2017 22:26:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=expressly X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 22:26:02 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 87.29.07039.8F135E95; Tue, 17 Oct 2017 00:26:00 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 17 Oct 2017 00:25:59 +0200 Received: from [142.133.49.59] (192.75.88.130) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Mon, 16 Oct 2017 22:25:56 +0000 Subject: Re: [python] Allow explicit locations in breakpoints. To: Phil Muldoon , Keith Seitz , "gdb-patches@sourceware.org" References: <04ccc2c4-7827-eedc-d8db-a83a0167acb6@redhat.com> <58311250-9ab1-39d1-99b6-07478bc8c2ab@redhat.com> <4768c7ad-cc3d-5702-fa93-40e9760d4ee8@ericsson.com> <81f2b22a-ba79-cc7c-ee85-95d2d433a90e@ericsson.com> <1765bb88-8ab0-bdcd-8551-69f8dff3bcb9@redhat.com> From: Simon Marchi Message-ID: <31ad8fb7-0e20-13a5-45d1-c9fa67b76e27@ericsson.com> Date: Mon, 16 Oct 2017 22:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1765bb88-8ab0-bdcd-8551-69f8dff3bcb9@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR14CA0022.namprd14.prod.outlook.com (2603:10b6:300:ae::32) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b1c1b96-b231-42a9-c16d-08d514e4df9e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603219)(201703131423075)(201703031133081)(201702281549075);SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;3:VxHB/QXrVHg7V+c549+3EbGRIUH7X8oISgCC2kr9StUdOXAhIvKeKANC0GxT7kthPyQWWxue07Hu5pnOI5rMLoqvgiRbuD3K8/B6C+6SwEXefUFGbevXaOVZ+ixJlfCsci7jTykPhG7zBor6UXyk7KbqxhwBWv1dxsj11FuXhxB3JF22zL78O5cmvVS5HbGywwrqfQKQI4CuZ6trrp17/cR2vnxHrlaJ5v7rXPU2mJDQY7h3vVxiEiKltomwW/gZ;25:PWessnGIssf1CyL9lRVWhS02fVV+O49Ck4Cu5w8yLIwzPd4JiX31cvVsTumD63ZXfxSABh7Oy6DkeDMXeLwS4V6PTYtEObAhOAyO9gMmQPt9DGdGn8ipAGfJP/LBzWXjMdB7eAjQiemOppkovN0MeTecvq6vCdQUT9s9eEiPT9XIJDF4siLulJ3tWg18akEHXbColXwxMEKx4tHr8mwUSP42M+MW0dVzR1Ae8Cw8o2Roe7NON0T6mOjBTmUHuUeLeUuSx7ilTNNpZAfQ+Si5ZpGSB13hGyjnlfuNzDgIWQYufhSCgCRkVvKc+4tMyQzKZ6jAo5jm6UZM6Ns1rPqSu03phSLdh6BysR/SQQhIj8U=;31:EI3SbiXdzKfZXuA1dDlWaEm0+FTBG/2p3uvHRnxBFgKM4sKPCYtzZEWmprh8uKrPXGbpEem3Fh84j88zEwAFuFDY8KXIMzDHL7hhRuX9Qgo6y2T+pGHMmg50thvzWPTDJz9DTrv9YAaVOot4T49a3rCLV3aWcoManUxby+zFIVlkLbViDHzrsmzz9XmCILpMBAOMeGEEGx8TX0cg42GnPBOE4FuTUFqZ9m4WOMx8xbQ= X-MS-TrafficTypeDiagnostic: AMSPR07MB310: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;20:Ed4L80sUv4ljVovFs0BV36csBWdmNi6a5xYt0vaXe5K+APdqgzGfG6Lsc0ZjfDbgtW0cTh1q+Uguu0/iuoFDLPdPjRsMf0CvB2HR0pkwTL3cezoyNbH43VU1fHeuVYuhidkd6J6BDNArv+DNBYgNdibysJiAonHgXkJ7UUVLAoO7jCY9xJucoEiCpRNQ8DaJZ1bDW9Bct8XGT5vJzWfOp/LarlFs2XDBqrn339Eiv67AVX3o2aTum2rSn07/m2nqDIgj54MnZx0HWdeaUtRNCt9BkPc+D7cqEKEnMnqdCoGOsyaycdh0Wb3AJ0yVYNFXaEbA98QYUq5AM1dxduT90eUJY4OuDfssZKkfom8VFSj+NuutPwn4t/F6Y6GcevzH0HGSjyEnWfDY6jSxto3Y9LLDNYZ80wfQz2ghwXpU/N2PrnV3N2lGpcMfxzzNkm7sToQOwCgHtdizRSEoYld0pc3RDfvkKrH2iHEARFeMSiR9yIx+ZJhgavn5pQea8Nnc;4:Uk/HDXRCfETUxojdfjUOYpKGmdKspnL790tinmK7OcdX2Wb7GSLmciz7PUh/Q25nwspHA7CaZzAEKnytWOzbuQjR2iQ8L79Qf2u6BVLpzu3KdFHbxBtenmSY/7avrssX8ckIMHUFLM/rXAN9Xjs0BXNOWfSR+N/fATMqUHWMvW/MD/9KUobqTvPKtie8tuNqZx/JnnVHOhcop/n7XizMZ047sbDB3rrAsgtXkmfzKol2jUYcBDOINqDeC5X4fFsd X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB310;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB310; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(39860400002)(376002)(346002)(377454003)(199003)(24454002)(189002)(377424004)(65826007)(305945005)(5660300001)(68736007)(2501003)(47776003)(86362001)(66066001)(65806001)(31686004)(33646002)(31696002)(50466002)(189998001)(49976008)(106356001)(64126003)(105586002)(93886005)(65956001)(81166006)(8676002)(53546010)(478600001)(25786009)(81156014)(2906002)(7736002)(4001150100001)(230700001)(76176999)(50986999)(54356999)(97736004)(2950100002)(16526018)(23676002)(6666003)(6116002)(8936002)(83506001)(3846002)(229853002)(110136005)(101416001)(6486002)(58126008)(53936002)(316002)(6246003)(36756003)(16576012)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB310;H:[142.133.49.59];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTA7MjM6M0hneHFNRDVubmVTRnlIaGhuQUxhZWpURm85?= =?utf-8?B?L3piTmNEUmp0aDAvMmtpV3cyQXVmQ0JzLzVPWVZYYUlUb2hQUUlHQmJQclhZ?= =?utf-8?B?dGNTNmZQcEs1L3dKVW0xR1pidTdnN2NPYTErc0hIQ0owOW0rTE1TdnluMStz?= =?utf-8?B?T0JLZ0NQRndxeEt3T21GTDJTVGpoeFFjdE9ieXpSRjVSaHBpNWFwelVyNDVO?= =?utf-8?B?Z3dTL0htWW8rN1pFekxDLy9TNTB3dGh2aDV2Sk55eUNOUURDMzhZWTQ2Vjkr?= =?utf-8?B?N1p3VTdMKzlXVzZmTmRPb0kxMEhEYjVHOE1SNVJ1WGpSTS9xeWVOZEwyOXNj?= =?utf-8?B?R0Fqb1RlYndTYmdHWWRpT28zUThYZTF2Z1JVL0RoRUt1NlZ2RDNUVWtkWXht?= =?utf-8?B?RStBNFI5MHhOOVkydXgxSUdQTHNoeGNKQXVwV2t3YzhSZXZCZ3VpcHc5WFdz?= =?utf-8?B?WHFKZDR3azFkRlZsNDQ2YWR2VC91S08yNkdMMVR1NHJhQkxPb0NPREZTVVI3?= =?utf-8?B?YjJ6Q0w0RjhlZ3NiZ0s5YTRlR1R1UUcyVTVET1VleThxektHUTc0RUllbGwz?= =?utf-8?B?QnlaN3dEcncwYWhoMkdWL1lpU3ZDSVp4bHFBaEFuVy91bVhKY0lsanhMWDhp?= =?utf-8?B?azRyWkE2aTJDZlBDUEtMRlB3M2JBSmgyUDJ3VmdsK3lRMDJ0THQ0TlFSUUts?= =?utf-8?B?SnhoVnFUU3RPaHA4MExRaGYwNi9WZG1SSjdZcnB4V0N5N1FtUm1TN3N4cDc4?= =?utf-8?B?c3NJbzhoOXJqblhaeGhRS0x0b0FpbVRYSTd2eldNQ3lmUmgyVUErd2FWOWpK?= =?utf-8?B?TTBNMHpvclNWbysrelJ0QzBHcjlRK3ZlclUveDlYc0FCYUUrZWovTlVFclNi?= =?utf-8?B?dFZPRGZNMXBQQjJOK0tST3lOV0hSbHh4N3lDcWVxMlJoVUNNbWxucmNZQWRF?= =?utf-8?B?S0dYQUl5U0xRVHpSNWVJeDYzVGdHbWhqMXZTT0YxUUFYVGxrK2g3ajIrcjJT?= =?utf-8?B?dnZNbVVHaENYb2U3WWVITTVSUU0yOU1tSzNMWEh0UG9JNDZCbTdWTC9zK1Zw?= =?utf-8?B?MUNXZWxUMVZwNWo5MlBka0REWFA2ZXMwTllxWHBFWXdPOXk4VkR4Y3ZuYjkv?= =?utf-8?B?aEJ3Z3d1bXpzTVRNVElKVlozYkF1NzBpbGV3NFZGVCswL0J4RVIvYTVYRFZ0?= =?utf-8?B?a0RkbUpNODhkWmNGaG0rS3NRTHI0NkFYUkVhZUlpWFFZTlMwcmdtS1BqeU9h?= =?utf-8?B?N2x2RDRoZ0tFKzIvdlBHeUJrT0M2RkRFaW5hV3htL01MeDNFWDd4c3Q0cU1F?= =?utf-8?B?YnN2STV3cStybHJFMTNmQ09hRmd1R2RWSWlPQVl4OHdpS2YrNVpEYkNnSlZp?= =?utf-8?B?c1l1dUJpOWF1RXNkN242TkxTSVF2c3h0anFiUVM2OG1pczdqUG5hN1FCcWZO?= =?utf-8?B?aDR0L3lYSkIvTEliU2dndEZNM1hTMUl0UUNHZUp0RmgrdDkrZjRaa09zdHdN?= =?utf-8?B?MXJOZll2SkZFNkFKRk8wWDRva3BTUDFIQklNZ1VIeUkvZjBHSHZseENtNWpB?= =?utf-8?B?YU9SalB0RXFKSGt5ckU1NWdGV1czeWE3T3dJUnRLT1JKM2MrUmhLSGJJTkFk?= =?utf-8?B?cWtsVWI1WXYwVlBiRkVZbXVuUE9UV3F4ZHB4WExLSHM0OGpzc2EwV1U3L1VZ?= =?utf-8?B?cEM3VGlmREJoR1I5bUZKL0Yvd2ZaYjcwYlZlWGhXYWNwdzlzVkZMSEJlS0Fn?= =?utf-8?B?cWhLZlgrQXcrWTYva1M5RWtCelc5RjgyOGZHcTNWTGN4NFlIRlVwMDdrdEo5?= =?utf-8?B?MndlVzZYTGd1TkFNWUZITWV4SDBQN3FRWTZid1F0ZUs2M1JyanU1NTZRTTk2?= =?utf-8?B?Yk8zN2pHQ2NFOWtOOXM0U3dmbjc3VWc2NVowck51V2hwZkVvclVsM2NmWEJJ?= =?utf-8?B?VnZ1ZGsxNmVuejBianlEV3NBclFOSGFCL2wrVExNMWFGckRZMnhzUmhlQzhq?= =?utf-8?Q?ui3DN?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB310;6:qYqoBzKgU4eWQNYKbHbfP9mNP97+Zye5P5TcdC0T9OGf9M4cr3mQVKhZ1pl20FYeThUoW5p29xtG034Esglm4rAFO6ehv2JDXwBW1ZHOQA+vJ9lTRdxqbvp2DxMIGimFRPbiO0ODl3biP3DKLsPlohq+zZxA9BjbNIOmzvGI3aPt3z5L/hGy/aweEbzX6md57TcS6RApzxEo2avnI6WM9snQryqa7L1Wzm33uTGWzb++EO/k5F7AC8SULVyRoiVzOPZ86BQ9M5HcsKVoLvzGSg9PPTBa4B7laLMva99o6AaG8PbgYikL6IXhVSqi8ZT8R9hNnH0JWDjRaifxR/c6TQ==;5:XZv9vk78TM/EBBMhpLTcTqbzYALl5uRW1pDufBLbrWZQUbKsLATPSsx/V3bQYKV0B2rqNjHZypjnID5CL3vyfKvUQGaUInkXzCK8PIOlnDI60UpK38GgqCA9Tjqx+0lbYkvrNB21TH9yg2EIZOzXjg==;24:PDTGVdaaPza/9S4pPkFPbsAXZAlb0E34ub9R5ZSEZapD9BXvxYMvr6Z7cO8FJEH3CjGo9dgZMN38vgq2Yo/ZabqgdUDyv5GXO9AShZjGpU0=;7:K/nNnFRxewvBUQx/8iTbaJv5WKS5paELApxwn+yG9P8yoqg9tOczzxOCyxWnYjDfJ1lJmKoqocIbIYV51JbIwcwR2JaB7EnyLYUxiyQLATjOIsMhsZQzKXd8CHKUCjBAiN1b7YQDHtUe7JwR5Nsr2g1NtjP+yV9l3gignRGitxjacNt2j/2f6mWGaUdkFxrjEf8MpUEN+umdjenhyePqNZuu5KQSWpd1zJzgUFdIEg4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 22:25:56.8521 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00482.txt.bz2 On 2017-10-16 06:01 PM, Phil Muldoon wrote: > On 16/10/17 22:25, Simon Marchi wrote: > >> >>> For now, though, I'll add the keywords (as strings) in. This really >>> prompts me to think we should rewrite the gdb.Breakpoint constructor >>> to not use create_breakpoint and be more MI-like in the creation of >>> breakpoints. >> I'm not sure what you mean, MI uses create_breakpoint in mi_cmd_break_insert_1. >> >> Simon >> > Simon, > > My apologies, on reading back I see I was pretty vague. I meant to > create an explicit location using "new_explicit_location" function as > MI does in that function you mentioned instead of > "string_to_event_location". Keith mentioned it in the original email, > I think, and that "string_to_event_location" was designed expressly > for the command-line invocation. I wanted to see if Keith's comment > would work in a gdb.Breakpoint. The downside is, if we do that (use > new_explicit_location), we won't be able to accept explicit locations > in the spec keyword and only via specific line, function, source-file, > etc keyword based instantiation. I'll hack on the patch tomorrow and > try to decide which. I'll repost the patch soon. But why can't we support both modes? If "spec" is set, it's a CLI-like location, so you can feed it to string_to_event_location. If the keywords line/function/file are set (some of them), use them with new_explicit_location. If both spec and line/function/file are used, throw an error. Simon