Re: [PING][PATCH v2 PR gdb/21870] aarch64: Leftover uncleared debug registers

Pedro Alves
2019-02-13T11:40:11Z

On 02/12/2019 01:10 AM, Weimin Pan wrote:
> +clean_restart $testfile
> +
> +set test "run to exit"
> +gdb_test_multiple "run" "$test" {
> + -re "exited with code 01.*$gdb_prompt $" {
> + pass "$test"
> + }
> + -re "exited normally.*$gdb_prompt $" {
> + pass "$test"
> + }
> +}

A naked "run" command doesn't work when testing against
gdbserver with --target_board=native-gdbserver.

Is "run" important here? Could this use runto_main + "continue" instead?

Also, the comment at the top of the file says:

# This test checks that GDB does not alter watchpoints set by an inferior.
# It sets a watchpoint on memory then writes to the watched memory.
# It will exit with 1 if the watchpoint is not reached.

But I couldn't spot where that "exit with 1" happens in the .c file.
Also, when that happens, we're issuing a pass, as seen above.
Is that intended?

Thanks,
Pedro Alves