From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DA3BE3842427; Fri, 7 Aug 2020 16:00:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DA3BE3842427 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6A2681E4BC; Fri, 7 Aug 2020 12:00:30 -0400 (EDT) Subject: Re: FYI: git-hooks update on sourceware.org To: Joel Brobecker , gdb-patches@sourceware.org, binutils@sourceware.org References: <20200807154423.GB3362@adacore.com> <20200807155017.GC3362@adacore.com> From: Simon Marchi Message-ID: <31207ab5-403b-180f-e74f-9b6e8d1dc5a4@simark.ca> Date: Fri, 7 Aug 2020 12:00:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200807155017.GC3362@adacore.com> Content-Type: multipart/mixed; boundary="------------32233464930BC681755D63F7" Content-Language: en-US X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_FILL_THIS_FORM_SHORT autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 16:00:33 -0000 This is a multi-part message in MIME format. --------------32233464930BC681755D63F7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2020-08-07 11:50 a.m., Joel Brobecker wrote: >> These changes have been extensively tested, and we've been using >> the same version at AdaCore for over a week, now; but do let me >> know if you have any issues. > > Well, that didn't take long. Simon just emailed me about an error. > Apparently, the Python installed on sourceware.org doesn't have > the enum module installed. What version of Python are you using, is it really old? All the reasonably recent and supported Python versions ship with the enum module. > I will revert the update, and ask overseers to install it. See the attached file, it's a very simple script to reject commits with the author name/email munged by the mailing list. I don't think it will produce too many false positives. Simon --------------32233464930BC681755D63F7 Content-Type: text/x-python; charset=UTF-8; name="reject-via-ml.py" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="reject-via-ml.py" #!/usr/bin/env python3 import json import sys data = sys.stdin.read() data = json.loads(data) author_name = data["author_name"] author_email = data["author_email"] if " via " in author_name and "@sourceware.org" in author_email: print( "The author name ({}) and email address ({}) appear to have been munged by a mailing list.".format( author_name, author_email ) ) print("Please amend to the commit to put the proper author name and email address.") sys.exit(1) --------------32233464930BC681755D63F7--