RE: [PATCHv6 01/10] gdb: create_breakpoint: add asserts and additional comments

Aktemur, Tankut Baris
2023-12-05T07:40:02Z

On Saturday, December 2, 2023 11:42 AM, Andrew Burgess wrote:
> This commit extends the asserts on create_breakpoint (in the header
> file), and adds some additional assertions into the definition.
>
> The new assert confirms that when the thread and inferior information
> is going to be parsed from the extra_string, then the thread and
> inferior arguments should be -1. That is, the caller of
> create_breakpoint should not try to create a thread/inferior specific
> breakpoint by *both* specifying thread/inferior *and* asking to parse
> the extra_string, it's one or the other.
>
> There should be no user visible changes after this commit.
> ---
> gdb/breakpoint.c | 6 ++++++
> gdb/breakpoint.h | 16 ++++++++++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 699919e32b3..dd415ff42f0 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -9228,6 +9228,12 @@ create_breakpoint (struct gdbarch *gdbarch,
> gdb_assert (inferior == -1 || inferior > 0);
> gdb_assert (thread == -1 || inferior == -1);
>
> + /* If PARSE_EXTRA is true then the thread and inferior details will be
> + parsed from the EXTRA_STRING, the THREAD and INFERIOR arguments
^^^
Redundant space.

-Baris

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928