From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mGNIIPsIQ2g1WgMAWB0awg (envelope-from ) for ; Fri, 06 Jun 2025 11:27:55 -0400 Received: by simark.ca (Postfix, from userid 112) id 7F3321E11C; Fri, 6 Jun 2025 11:27:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 067C11E0C2 for ; Fri, 6 Jun 2025 11:27:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A82A8385772F for ; Fri, 6 Jun 2025 15:27:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A82A8385772F Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id A3FA63858C50 for ; Fri, 6 Jun 2025 15:27:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3FA63858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A3FA63858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749223642; cv=none; b=CJbYoHdtxEzNB/KntWD28pEGj2qzKgt/u+0kXy2hVL3C3qglgVCw3lsIcKHyEbAFONzsHCPo0j20LfcSFw72E4PXm8TdlXUp+GEe0VqlUPZmJyG1nSESRWMFsxy/vkeWBaPpwVMolKPbTzFHR46C4aaRYEb/eLe5xm8kTlDHIh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749223642; c=relaxed/simple; bh=tiyxJzgTh9/PiS5yfZcIacv963+CxC+/bBCpxnbxgQg=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=OsiGU8A9O1FhbGKdiPDSPesJeOEiEGGl9b5cophxCTjxc38A8IYQ1jpiA1ZWbeKHuy7n9tplCBJ9h4eEji+wp1LsEUQo3f66vEyxTLuQ8BHwQfnxszHg4vDEG7d9LEWE9WjiKZsT0rr9ivl/rTBqy/rOMT2+HcRQJeES7fO7dY8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3FA63858C50 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43edecbfb94so25782025e9.1 for ; Fri, 06 Jun 2025 08:27:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749223641; x=1749828441; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=prpOBd5ywRbvgS+9VTkQ1j2BoJjb2jgxY2HYSLT3BCg=; b=CWKJNKoCm0zFbMnmV6iP9mRnuBqfGsF6MqFZ7qrHPw9W4LkeUAIQqg74XIoyRd/e/7 Wjz9SQU7wCPAG39VtQdyz+qC6AmcglVa/S+fcmVVZ1wkXxBIHDYqNZTjrz41ywF1GVWw mdKUK+UPerg79gXKY0tMcgiicnh734Urtoi8AohG1BASHkvvUD7ViY7iFxJeurXQK4lK 5Eh0F6exAgRok6K4MTBJMbymFcuUZa2hni6UnFBqdkPmBefHjVF55O1eSUC192XuC0C9 WcBdwoNdcmvcK7rORaWvXyqHNLX0Xs8cdrEaHpqd5g4HR6wf6m352ITb0MRnd6ROArz4 JF4w== X-Forwarded-Encrypted: i=1; AJvYcCVYgAIVwyfV7x2gb/BSs/4t1LrDxKxPqNUupYJCWjEfKRXGOY1NeyBK9VuMVLn+s0W30Wn7XC7aWbxqIA==@sourceware.org X-Gm-Message-State: AOJu0Yzs3qvqrewqcpnU/mTk6YANfeI6X5pAhdVTHq2kcAz/C3NWzV3G 5vvOBcm6tLPLVcc8h1+gx18mfo1eIfB7CqcdiFmnBtB6TKJrKESx2+Vf X-Gm-Gg: ASbGncsnH5xAF0PQnwNCw4xtFMZRMePJH3Z/XBqN+93U4hGNGH3F1zn6/eZSVn84hQB db6OLYxjhoceji3FQldl9FK6Eso16kYRSLpiYmJHGJvjWjgHgbz5Dixj4XzG72FjjalHKEXM4Ah vSHKo71ZXez5kDwnW3Vf7fL2Y0zY5FUDy2c0BIl19JFbjiruLdU4Gp9AbN7ZY0HFiBAxSYnLW1o T6RktAkc9sFmkNKJ+4ZoSftWcR9bvcGEcRcYLHupavCFqf/bGD+ckqsZ00y6kBjGk82pv9OsRAL RCt7+oTD1Alm2pZCFx06/uJ2aXAbhDebjM5Ftf9G4tjhV+1znqRqvU89K8Uqh9neqw9BKtpdenl iTAf+m4iftHBM+Qa/ X-Google-Smtp-Source: AGHT+IEI//lGaMYWf7T/sbNH0XqYLvEwotj82AweaqbP7NBsna2tUI8htp5GWrJ2CHkzHuFQmSqfHw== X-Received: by 2002:a05:600c:a00e:b0:43d:ac5:11e8 with SMTP id 5b1f17b1804b1-452013d7e0emr38237265e9.21.1749223641422; Fri, 06 Jun 2025 08:27:21 -0700 (PDT) Received: from ?IPV6:2001:8a0:facf:2b00:77f6:647:8d2f:f905? ([2001:8a0:facf:2b00:77f6:647:8d2f:f905]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452137281b0sm27947465e9.29.2025.06.06.08.27.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 08:27:20 -0700 (PDT) Message-ID: <3111debd-c02c-4254-8ecf-0b0de2fea808@palves.net> Date: Fri, 6 Jun 2025 16:27:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Don't call WaitForSingleObject with INFINITE arg From: Pedro Alves To: Tom de Vries , gdb-patches@sourceware.org References: <20250605150330.26246-1-tdevries@suse.de> <4311a30a-51cc-4054-8219-48f895bd962f@suse.de> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-06-06 16:14, Pedro Alves wrote: > On 2025-06-06 08:12, Tom de Vries wrote: > >> FWIW, I've ran the testsuite again, and got stuck this time at gdb.base/catch-fork-kill.exp.  In this case, the problem didn't seem to be gdb, but lingering test execs.  After killing those manually using "kill -9", the test-case finished. >> >> The hang can be fixed by adding a missing "require supports_catch_syscall". >> >> I was wondering, I saw you mention "I've got another series of patches to improve such tests and skip others, and that's what I've been testing with".  Do you have similar fixes in that series?  If so, can you submit them, or share them in a branch? >> > > For fork-related tests, I added allow_fork_tests to be used with require, and > sprinkled that throughout. There is no way currently for the debugger to be notified > of forks and execs. There is no protocol between debugger and Cygwin for that. > So all fork tests fail. > > So for gdb.base/catch-fork-kill.exp in particular, that's what I did: > > diff --git a/gdb/testsuite/gdb.base/catch-fork-kill.exp b/gdb/testsuite/gdb.base/catch-fork-kill.exp > index 0fd853b9085..224a8dfec89 100644 > --- a/gdb/testsuite/gdb.base/catch-fork-kill.exp > +++ b/gdb/testsuite/gdb.base/catch-fork-kill.exp > @@ -32,6 +32,8 @@ > > standard_testfile > > +require allow_fork_tests > > OK, I've sent that patch now: https://inbox.sourceware.org/gdb-patches/20250606152500.947489-1-pedro@palves.net/T/#u Pedro Alves