From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108027 invoked by alias); 21 Jun 2019 16:32:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107777 invoked by uid 89); 21 Jun 2019 16:32:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jun 2019 16:32:13 +0000 Received: by mail-wr1-f68.google.com with SMTP id n9so7250769wru.0 for ; Fri, 21 Jun 2019 09:32:13 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id f12sm6116624wrg.5.2019.06.21.09.32.10 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 21 Jun 2019 09:32:10 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Compile index-cache.c with -Wl,--build-id To: Tom de Vries , gdb-patches@sourceware.org References: <20190621152742.GA20230@delia> <62bf83ef-0c18-12a8-bfb0-8f3f28fa84ba@suse.de> Cc: Simon Marchi From: Pedro Alves Message-ID: <31086b56-cffc-140a-bb5c-fc22151ba379@redhat.com> Date: Fri, 21 Jun 2019 16:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <62bf83ef-0c18-12a8-bfb0-8f3f28fa84ba@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-06/txt/msg00433.txt.bz2 On 6/21/19 4:54 PM, Tom de Vries wrote: > On 21-06-19 17:47, Pedro Alves wrote: >> On 6/21/19 4:27 PM, Tom de Vries wrote: >>> Hi, >>> >>> When building gdb using a combined gcc/binutils-gdb build and running >>> gdb.base/index-cache.exp we get: >>> ... >>> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one file was created >>> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: couldn't get executable build id >>> FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: check index-cache stats >>> ... >>> >>> With "set debug index-cache on" we get: >>> ... >>> (gdb) file index-cache >>> Reading symbols from index-cache... >>> index cache: objfile index-cache has no build id >>> ... >>> >>> The problem is that the vanilla toolchain does not add a build-id, which is >>> required for the index-cache functionality. >> >> What is "vanilla" here? A non-combined gcc/build-gdb build? >> Or is "combined gcc/build-gdb build" irrelevant here, and >> "vanilla" means "no-distro-patches build"? > > The latter. OK. Please tweak the commit log in that direction then. The fix LGTM too. Thanks, Pedro Alves