From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68177 invoked by alias); 13 Jul 2019 05:45:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68160 invoked by uid 89); 13 Jul 2019 05:45:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1300, HX-Spam-Relays-External:sk:!192.16, H*RU:sk:!192.16 X-HELO: mail-wm1-f41.google.com Received: from mail-wm1-f41.google.com (HELO mail-wm1-f41.google.com) (209.85.128.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 Jul 2019 05:45:50 +0000 Received: by mail-wm1-f41.google.com with SMTP id w9so10509729wmd.1 for ; Fri, 12 Jul 2019 22:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:user-agent:in-reply-to:references:mime-version :content-transfer-encoding:subject:to:cc:from:message-id; bh=reHBaORXWoqTQZQCkCtBks8RONVbg1Uf/YZ2ZkU6Z5Q=; b=f8g3qDKT5fhMxiV0q8d6TdKhbr9PAtxLciUBSTLof/mICYMiKeFmOFd4jQVc9TOo9I 7unz4t2PDON0xUOw/oCCKOqPrFd09LSc5mjEOX/wBagTQuHdb9hY1DSdy4oiL9rXpWSR w4/+31VrS6VNTOB2k4ULBQvBY6SS4ajEFWXZGn/fakOUQgsz0Iyvm9At7g7D7E+wV7bR TjEjXzSlADFY56K54eeQ43is1M1pKPkL87cuDnARpAkJdRc9CcQmlGKXoFhlUecBWELe YE6XLSmQQ94vYoNoWbx7MoRXVvKPIN6sWKvmjSdvF94eePjHS57DDMUgJfMFp/0JaHpU Dnyg== Return-Path: Received: from [192.168.178.32] (x5f75635e.dyn.telefonica.de. [95.117.99.94]) by smtp.gmail.com with ESMTPSA id s12sm9478686wmh.34.2019.07.12.22.45.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jul 2019 22:45:46 -0700 (PDT) Date: Sat, 13 Jul 2019 05:45:00 -0000 User-Agent: K-9 Mail for Android In-Reply-To: <20190712231256.21418-1-brobecker@adacore.com> References: <20190712231256.21418-1-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [RFA] adjust src-release following the renaming of gdb/common/ to gdb/gdbsupport/ To: gcc-patches@gcc.gnu.org,Joel Brobecker CC: gdb-patches@sourceware.org,Sergio Durigan Junior ,Tom Tromey From: Richard Biener Message-ID: <309BEDEC-E175-41EB-B44F-16EBDC2E7AD4@gmail.com> X-SW-Source: 2019-07/txt/msg00350.txt.bz2 On July 13, 2019 1:12:56 AM GMT+02:00, Joel Brobecker wrote: >Hello, > >A recent change renamed the common/ directory into gdbsupport/ in gdb. >This causes problems in the getver function in the src-release script >which doesn't find the create-version.sh script anymore. As a result, >it falls back on using the version.in file verbatim, meaning that >the "DATE" placeholder doesn't get replaced with the snapshot date, >and the "-git" suffix doesn't get stripped. More precisely, we get >snapshots called "gdb-8.3.50-DATE-git.tar" instead of (e.g.) >"gdb-8.3-20190712.tar". > >For those who have been getting snapshots from sourceware, this is also >why recent snapshots are missing. > >This commit fixes the issue by adding support for this situation. >I left the support for $tool/common/create-version.sh, because >the sim still uses that directory structure. > >ChangeLog: > > * src-release (getver): If $tool/gdbsupport/create-version.sh > exists, use that to determine the version number. > >Tested on x86_64-linux, by running the src-release script with "gdb" >as the argument, and verifying that the name of the tarball is now >correct. > >OK to push? Ok.=20 Richard.=20 > >Thanks!