From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5689 invoked by alias); 8 Oct 2003 18:21:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5666 invoked from network); 8 Oct 2003 18:20:59 -0000 Received: from unknown (HELO gollum.inter.net.il) (192.114.186.22) by sources.redhat.com with SMTP; 8 Oct 2003 18:20:59 -0000 Received: from zaretski ([80.230.148.47]) by gollum.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id BOV20208; Wed, 8 Oct 2003 20:02:35 +0200 (IST) Date: Wed, 08 Oct 2003 18:21:00 -0000 From: "Eli Zaretskii" To: Daniel Jacobowitz Message-Id: <3099-Wed08Oct2003195835+0200-eliz@elta.co.il> CC: gdb-patches@sources.redhat.com In-reply-to: <20031008170233.GA9013@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 8 Oct 2003 13:02:33 -0400) Subject: Re: RFA: Breakpoint infrastructure cleanups [1/8] - define impl_breakpoint Reply-to: Eli Zaretskii References: <20031008170233.GA9013@nevyn.them.org> X-SW-Source: 2003-10/txt/msg00231.txt.bz2 > Date: Wed, 8 Oct 2003 13:02:33 -0400 > From: Daniel Jacobowitz > + > +enum impl_bptype > +{ > + impl_bp_software_breakpoint, > + impl_bp_hardware_breakpoint, > + impl_bp_hardware_watchpoint, > + impl_bp_other /* Miscellaneous... */ > +}; Why did you decide to leave the subclasses of hardware watchpoints (read, access, and write) in the parent structure, instead of moving that distinction here? That seems like you are spreading related information between several places instead of having it in a single place.