From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 131001 invoked by alias); 10 Feb 2017 19:08:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130983 invoked by uid 89); 10 Feb 2017 19:08:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=H*MI:sk:f52c182, H*i:sk:f52c182, Hx-languages-length:1896, H*f:sk:f52c182 X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Feb 2017 19:08:08 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by (Symantec Mail Security) with SMTP id 87.E2.29577.69F0E985; Fri, 10 Feb 2017 20:08:06 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Feb 2017 20:08:04 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.238] (192.75.88.130) by DB4PR07MB393.eurprd07.prod.outlook.com (10.141.236.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.5; Fri, 10 Feb 2017 19:07:58 +0000 Subject: Re: [PATCH] Don't send queries to the MI interpreter To: Pedro Alves , Simon Marchi References: <20170210163650.10334-1-simon.marchi@ericsson.com> <89904751-7015-b272-98c1-33e786f7c356@redhat.com> <85ae4ad9-acdc-c9ba-6606-a7ac2abc7e2e@redhat.com> <0d8bd42f-5964-1ac7-414a-754540db2e95@redhat.com> CC: From: Simon Marchi Message-ID: <306c8a78-81e4-a2e2-a2ec-78081dbee1d2@ericsson.com> Date: Fri, 10 Feb 2017 19:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR10CA0015.namprd10.prod.outlook.com (10.172.48.25) To DB4PR07MB393.eurprd07.prod.outlook.com (10.141.236.16) X-MS-Office365-Filtering-Correlation-Id: c369d411-aa0b-4f22-9898-08d451e8212b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB4PR07MB393; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB393;3:UcUoq0t+XlRAtzg1CUwnMVn7po7AxNPQhE46dU+ljGK7eahSQtU3Bzm+b+Xmk8w3sXfIN0JvjeEGKg5A3S/y35cYtJQVLJKtBlLTwf807gNrQRGovqOZmaVHIl3PrOJG2F9lw/erk+f7VgbbyO/GSk8h5A+bWoKWOX2nuGLr+vgX5GBCgzl2gfTOSk5WkVXpllo7CZJcp8A4MaBlT+RrF9PID/SE8UXFJTpXvyWaIbR2oFSF34FGZNPyME4lq29HNFHRGOm9yAHMbu3NY2DXYA==;25:213de8kgm4j3gTYEdGd80hj/X1KiIiTAYDBeVpWRUX+vZjwPJ9R2rsEqYKtrMFLPKS7b9uzvx1pQ76l6sEtnJ6M0nH5dfH4+7c+BG1LhQ2GloG/+a8gyXsRjFzMJb7hnmmBcveuGuKDOt4r1vWZwK5Kj3OwdJKGmpjNYW0nlhzJ2VvlWuIEa66rByDVN/yGySvrYH3sj9DMrquvot+4No9yzxsdcIWC/Na7FCIebXgFlPR/2wwYrnYWTDlOL3Aw5wa1rSMvkCWGa81CAjfcx9HKUNrBgi2N+TQOy5s78BNLptowcmhdKe7BOr01NBBIsQcbNn+8IntZz0vqvLUBONooN090NXSJ9Oue91FRJtfm/sCBLW/vcLXiXHMzdAytexGHTS2u+vf93ZHvaOfCpGhbVbsCD+iiPxJO1FwM3ZpLPuHcEZDJV1liavevT06h7OkteHuOjQwvc2gHR+upbRQ== X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB393;31:RhtOBM+xdl/EuBAeEJL3eHdiHT9tOU53o5+36eBfxvwFlX5mP5WEJ+qSmXTbeRnLZ+QILHz5ktoLpQIVLH9Fk3354oZoOYvJeRdOqo2+6L/CpKcp9/+QiT3G3YIP4jtC/4KfNsetVV5zTJ23SngafEhoNPcf/ZrlI39TG0BmKFzL1EggEUJJj0M8RfXQK/1f7SxpdoAD1HJeAnVQ8e/0vy44j/scwJZVw+uOOy+WZdfh6ik2VSdGnIWKvwEGfPiV7kZSaqMVhLFGsvCIhbF4MUsfcEoiqtOpcZnDpcyWyaw=;20:WPLJmDfeFIbRv9w2EAzfoq1NhcDBXEWKkAHlIE9jO1vvKAKVQrFynAkrOYj0yjiGaN9cgZ4wjKpuZHg1vwsn7RoOCPBRyle09kxmOAaiHvzKWblJ4zPuLzXeYPg4+WZ/IuioVE4AaMixjShgyrOrnHrSOva7g/vDf8LtjjgT7zwfUhwZYWtusiTHXNndD+o0QEZnjVJRVzEOAlQNrM6s8OIMqm66J6ES6tCYk2/RJqySidw6JeI+RzTfMZgAlcfb+yfVUVCexFploMOiY8Csh7jiTNh+Z67+0RnFfPe97e9AtTW3g6fxorWq67ptR8A3qODtj/KmM/7O5VWtG8g6uH94b8NuPyEu7QVN+/DkiKuS01cI00ll5M79ojEw1mksAE8WGdsq7tVIl/wrFs9/P+JLi5woCb1UDc40s2x0rQDI+ZIsXRocLWz8aCqlqe/u4+cS7lpzNV216d25/f/U/4No7BrlZbWm0s8fzuH+KgMWtPClMiZavcSNDYJ1Zumy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(20161123558025)(6042181)(6072148);SRVR:DB4PR07MB393;BCL:0;PCL:0;RULEID:;SRVR:DB4PR07MB393; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB393;4:+Tu9Vt2qNNSMO6yIiO7rPIWJgVhG1rMisFkJlM44CnseuLhOi7FYsG11RW0s7MuP8XxtKwXPuTt9eL2SVwLD5c3x4x3bvNlyuKR10TZlQ2EtrZoaUphqTkplEt3lOjM3uiRqu9L4iAOkpCEtMeBMHZ19Aehrd9za8vNt2A/Ag8Gm2K+2eCa9IvU/kk7anXetY956DI0wAMExiLTZP4fDU42C0peKijtq0oiRnnIieSklExGHuTR3hfmltDN3iQgNONHkChkPYoLXo7pl4x7qZUl4n/TsDdS2zKV7Jgkp+a24QbgUxilYWimcmUWZyFH/AZw1ORdQP+Gu5HA7+XLEqk8b1ZSgL7iTgzjBeLSsK7KGhtyn5Itemra8oYFeJ65XMqdcx2duNS8mdF6jq6gB5OAgwzqQpklR9hUjuJUOcFQb/lzqjAxM2iLNU0nOoKZ3yjHxRL4s5sosV5DLyG8XeF8i3S+io29GjULzu96lWAjJS1VdC1oZzCzDX8frAw/4I1qdGkh6p8cRRMyugyNnVZuT8Vk7f/1xcXldjGMyglZ44Pk/pSZa6gDkxZIqkHxNxFQ0tX+4dbbuv6BAx4UouX1ipmscBSpcmh3mbrQKfvo+slaadtVEYYqeawzl2dVG/WlK0Z1ixL6nAeBiR7SmLTe1M5tZSt+wjjHQvCRAL+o= X-Forefront-PRVS: 0214EB3F68 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(377454003)(189002)(24454002)(199003)(52314003)(377424004)(4326007)(6306002)(92566002)(229853002)(3846002)(6246003)(4001350100001)(38730400002)(50466002)(50986999)(53546003)(33646002)(54356999)(6116002)(36756003)(81166006)(230700001)(93886004)(83506001)(106356001)(5660300001)(305945005)(65806001)(47776003)(7736002)(66066001)(65956001)(8676002)(86362001)(2950100002)(68736007)(81156014)(105586002)(31686004)(42186005)(23746002)(25786008)(53936002)(64126003)(97736004)(90366009)(6486002)(31696002)(76176999)(65826007)(2906002)(189998001)(101416001)(6666003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB393;H:[142.133.48.238];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB4PR07MB393;23:YD/8Brl0ZYvusBi5Y66hqpW6cN54l8eXFKl9gN?= =?Windows-1252?Q?NDUHcpX6tKraRA0J4GgwsPCtzrNDMCaFWcdIzsJj/BJD9Foe9OIUcgf+?= =?Windows-1252?Q?A5FBjWH8yi1Kw0AeYZ/ZC84JxznIPwOK0pstyHvGjewFy2Y6AnOC1tvS?= =?Windows-1252?Q?JdtdOq4NpActdl6AqqZfZf/PCEG4stfts6Cg6/dOXb7AxKotLS6k98HP?= =?Windows-1252?Q?h4oEtbR4c3myYZwPFNUogsGL5C85eqvEO++dsa7li0kX0qGVY9j+/+20?= =?Windows-1252?Q?ytMgn32nd2Y0DgdSTCPntJQiuVOlKve4ceg1IDGezOj+lVBPamI2oIOU?= =?Windows-1252?Q?gNx8DR6beojrt2aE3RE1Ss/ZUelJEqJWZ/8Ugri70wB28n3CB69BPqeb?= =?Windows-1252?Q?HHEPQuwREbXlRTss97g6ZUIz5b453Ox5TrSESFUen17890k2m9Mjv77E?= =?Windows-1252?Q?0Nn84Z9GbjUSBT/gmNgyHGpcIqOUEYIa4JxttL5btlwLO2beu9gbbhIJ?= =?Windows-1252?Q?29gold2bSuKs9haGyx4K0hSGjwejHVwaBV0nt39XDCntHA1ktbsUFyuo?= =?Windows-1252?Q?DDUsBEFYkJxJsUC++Hwp+npRxTGY9v8VXgYKrRYwz+UyWvcBFV0FimPu?= =?Windows-1252?Q?b6gSqllIKJyxOd+V5mtEYfTHzLDKYFXV5yDMOd7+RU6cwD7CHIJmd+jd?= =?Windows-1252?Q?PrUmfM8d45W08ZnqpkxNCgvXpKEh4gTDAZDGnOHEZWiaf5rBd3hpAESg?= =?Windows-1252?Q?oKArUbIYILX/cxTEotOPCmJmgKd+PmlpIB2EJDkGPtkffOpKot2lYrqz?= =?Windows-1252?Q?FHf2H1p9+XU7iXli/yhw9jo8cukiM52pAH0AeXj+MfkU94E6iponr0z0?= =?Windows-1252?Q?nPDeu0CVT3im6yfEFJQbAixR3lPgXcfFpRCwf+tbnEM6Y8Aj2ak9m88C?= =?Windows-1252?Q?UjGcyVOPr62kqPyIeQ/uMEEM/QiuXHp2MQJOulCUJXx0wU13Ux+WY/Ng?= =?Windows-1252?Q?ZSd73Td6a94BGwxWLuf/3evKVgu2Bd3JWNmvUigCGoRekydDJs5nY5vZ?= =?Windows-1252?Q?YNlkfaer/PsCA+Nx6t90YSCfZtcaJPlf+bnUwJauR5eO+Gx4Bx2JiOHe?= =?Windows-1252?Q?RicuyxfMSaZL/g1O4RoxKKzEkSwNEDD3gjGSmfAddqFkaRhrGxunrZu3?= =?Windows-1252?Q?Y5BTFFfM/9ab4915XrqLkDx8aLn5gODoBs+bdDVR+FlQPAdglgfKwhDw?= =?Windows-1252?Q?P62oU3IvW7Ox0YMEgCJ0/rs7zNQlAfALWUMG7wMHH339e+LrzVLd/aq5?= =?Windows-1252?Q?WTYuZcDO+tPwuTDmV0m7sYsapRe/Q+IbEf4Cz/5iZ66nbXLOy7hrJjvl?= =?Windows-1252?Q?XIsE++vM2FNrk+jKRoQwLllfIB1QfF0nZaZ63p84vag7MgGsISCTmdfS?= =?Windows-1252?Q?rnuSI/Fh+7CESOBkVjczT/cf2hgz+MIfi1UfQkXIX9nL1wjlcanD3Yb3?= =?Windows-1252?Q?YRuGf7oI9tzFHSKqkBCn8o+Jr5?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB393;6:whizuE8R667kxW7y3HicUt2awX5neBxMVyDfznDVDAX+7PHDA2K/nNwe5FP7iz6ZQSNpIuGYOZPxHfRCljtYM9Da5qFMQK/Aas7MQMTKd3OnuTnquf0bBGQL8pNGJGYUf9kJqmY8/V0cQJAfaiAl7wEabqHQqcS63eOmcwWeFHU7/Wv5qiUkBK54+jK1K06kPqVNyXZDhJi7/5mo33qLBF1PL/BTPxNv/K+gT3AKASQp1C365Fs0pYNYYiOsHVvRn6VZaIxKrRqrXQ+fGzr04GjAQ9Y9kWdwSdiq2fwWXG2bJC1D6p1IxLPqBCF0LvPHqK2aWIz7v3/mn/ol03PfmfwE09Tx6XeWgwa+6ihpJa4Gn5gdJWJzWawpAo97xZO/SuuyvNVA2+P1Weo6AJeZKA==;5:Lvkeds1PDuhESJ7DGA3GdPFNlig0pvf67/awOOVh8ogzR+El2hWy1VioN/miplQsk4XP5iGB38y1XTPm4VoJWyeu+3KZORCrGxXHVHij+gN+zcsHGZVmqULmRdlv7+Uzj3PvaoPnVPKGdCUoGiZGZA==;24:lha0xYJ1t8dLfjejpAIWpnNfkFbicEbl9Il05Pn80uDmlPcOy/BFc0UrT0CIN3byPKm/dXeRTdea69XaZqa/x2djtpiadC9XI7rBHb7bTK4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB393;7:N+dQgLUdWs4lfgIzl81wpj1ptaerOEvXEGE/RfHMs/qgYJLCoWJvDkcFs6OOeayNjSpLfK0HcKZneRpMdLX7KIL2G3/OLfM1vSrTHs4JdP8IswZKjcRsLMnBGh21L5AimUpA5eRcMQHRrH+PHfNYos+YMCUdmPUUAeMSLjPVxTy105I3TM6Ly7V02FP78DtjQKOj8CEV+Ux+OcqKeme/aECUeAES2UCA8GUtyle3RKfQ8eQWGKo508KxsE45gw05Mp6JDUgdqkKfDLX4SXhaghYc7p9pwLQcMqiRO9B7d/WaWOEzx0vAVmwUe6vam9lvpPqe5LmC7AJoJmbQlr8oj62KRy1M2jem1MmUi90NMwyepGHLYvIgJr6CuxBNg7yuyU3wkLSqV6Aw5YZ3YO3vSGnRoW5N8GVFKakLPPC37WydT9TdzZYHg2reQxpdlksqA7uLrkbcSb1Z5y3jTvFbno353PZS87g+xQeOoEsLBMNT56gjSdhYji6JT/0iLhUdZsC28BJqUQhYyRpBKUTjnA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2017 19:07:58.6225 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB393 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00273.txt.bz2 On 17-02-10 01:36 PM, Pedro Alves wrote: > On 02/10/2017 06:07 PM, Pedro Alves wrote: >> On 02/10/2017 05:44 PM, Pedro Alves wrote: >> >>> OK, I found the branch. Pushed here now: >>> >>> https://github.com/palves/gdb/commits/palves/console-pagination >> >> And re-reading the branch again, I noticed this hunk: >> >> @@ -1255,7 +1258,9 @@ defaulted_query (const char *ctlstr, const char defchar, va_list args) >> way, important error messages don't get lost when talking to GDB >> over a pipe. */ >> if (current_ui->instream != current_ui->stdin_stream >> - || !input_interactive_p (current_ui)) >> + || !input_interactive_p (current_ui) >> + /* We can't handle nested queries. */ >> + || current_ui != main_ui) >> { >> old_chain = make_cleanup_restore_target_terminal (); >> >> @@ -2045,36 +2050,48 @@ begin_line (void) >> } >> } >> >> This is similar to your patch, but it handles something your >> version doesn't, I think. That is the case of handling the secondary >> channel being a CLI interpreter, not an MI one, and that UI >> having been started on a terminal. > > So with with all the rationale I've thrown out, and idea > that we shouldn't see a query anyway, and considering that > real MI commands shouldn't really query anyway (nobody sees > the query output), it may be actually impossible to find > a way to this with MI on the secondary channel, that will > remain stable going forward. Hmm. I'm not sure I understand this part: > it may be actually impossible to find > a way to this with MI on the secondary channel, that will > remain stable going forward. > So how about using the hunk shown above, which should handle > your case as well, and while at it write a test that > uses CLI in the secondary UI instead, making sure a query > is auto-answered in that UI? > > Thanks, > Pedro Alves > That's fine with me.