From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157470-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 117578 invoked by alias); 11 Jul 2019 13:36:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 117569 invoked by uid 89); 11 Jul 2019 13:36:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=
X-HELO: mail-wm1-f53.google.com
Received: from mail-wm1-f53.google.com (HELO mail-wm1-f53.google.com) (209.85.128.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 13:36:27 +0000
Received: by mail-wm1-f53.google.com with SMTP id s3so5732455wms.2        for <gdb-patches@sourceware.org>; Thu, 11 Jul 2019 06:36:26 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id c78sm6288759wmd.16.2019.07.11.06.36.23        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Thu, 11 Jul 2019 06:36:24 -0700 (PDT)
Subject: Re: [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
References: <cover.1562850845.git.andrew.burgess@embecosm.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <306a840c-719a-0398-26cd-34142ba05167@redhat.com>
Date: Thu, 11 Jul 2019 13:36:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <cover.1562850845.git.andrew.burgess@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-07/txt/msg00298.txt.bz2

On 7/11/19 2:20 PM, Andrew Burgess wrote:
> Additional use of the gdb::options framework.
> 
> --
> 
> Andrew Burgess (2):
>   gdb: Allow quoting around string options in the gdb::option framework

Ahaha, that didn't take long.  Thanks for doing this.  LGTM.

>   gdb: Make use of gdb::option framework for some info commands

This LGTM to me too, but, I was surprised to find this doesn't add
completers at the same time?

Thanks,
Pedro Alves