From: Simon Marchi <simon.marchi@ericsson.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] mi: Add launch-type={run,attach} in =thread-group-started
Date: Tue, 02 Aug 2016 15:55:00 -0000 [thread overview]
Message-ID: <303085df-51ef-2575-464e-5d24d5b106e6@ericsson.com> (raw)
In-Reply-To: <83y44fmdjz.fsf@gnu.org>
On 16-08-02 10:49 AM, Eli Zaretskii wrote:
>> From: Simon Marchi <simon.marchi@ericsson.com>
>> CC: Simon Marchi <simon.marchi@ericsson.com>
>> Date: Mon, 1 Aug 2016 17:14:01 -0400
>>
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -26437,12 +26437,14 @@ group is added, it generally might not be associated with a running
>> process. When a thread group is removed, its id becomes invalid and
>> cannot be used in any way.
>>
>> -@item =thread-group-started,id="@var{id}",pid="@var{pid}"
>> +@item =thread-group-started,id="@var{id}",pid="@var{pid}",launch-type="@var{launch-type}"
>> A thread group became associated with a running program,
>> either because the program was just started or the thread group
>> was attached to a program. The @var{id} field contains the
>> @value{GDBN} identifier of the thread group. The @var{pid} field
>> -contains process identifier, specific to the operating system.
>> +contains process identifier, specific to the operating system. The
>> +@var{launch-type} field has the value @code{"run"} if the program was started
>> +by gdb and @code{"attach"} if it was attached.
> ^^^
> @value{GDBN}
>
> Also, @code{"foo"} looks bad in Info due to too many quotes. Suggest
> to use just @code{foo} instead.
>
> The documentation parts are okay with these fixed.
>
> Thanks.
>
Thanks! Updated locally.
next prev parent reply other threads:[~2016-08-02 15:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 21:14 [PATCH 0/2] Two MI changes related to separate UIs Simon Marchi
2016-08-01 21:15 ` [PATCH 1/2] mi: Restore original thread/frame when specifying --thread or --thread-group Simon Marchi
2016-08-02 14:49 ` Pedro Alves
2016-08-02 17:45 ` Simon Marchi
2016-08-02 22:32 ` Simon Marchi
2016-08-03 13:41 ` Pedro Alves
2016-08-03 22:24 ` Simon Marchi
2016-08-05 17:26 ` Pedro Alves
2016-08-05 21:01 ` Simon Marchi
2016-08-17 20:24 ` Simon Marchi
2016-08-01 21:15 ` [PATCH 2/2] mi: Add launch-type={run,attach} in =thread-group-started Simon Marchi
2016-08-02 14:49 ` Eli Zaretskii
2016-08-02 15:55 ` Simon Marchi [this message]
2016-08-17 20:17 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=303085df-51ef-2575-464e-5d24d5b106e6@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox