RE: [PATCH ] PowerPC: fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp

Carl Love via Gdb-patches
2023-02-28T16:19:46Z

Bruno:

Thanks for testing and reviewing the patch

On Tue, 2023-02-28 at 14:39 +0100, Bruno Larsen wrote:
> Hi Carl,
>
> Sorry about the delay. I've tested the series and see no regressions.
> In
> particular, the tests you called out all passed on my machine. I have
> a
> minor wording nit in one comment, but regardless, you can add to the
> tag:
>
> Reviewed-By: Bruno Larsen <blarsen@redhat.com>
>
> > -----------------------------------------------------
> >
> >
<snip>
> > - /* Set a step-resume at the function's entry point. Once
> > that's
> > - hit, we'll do one more step backwards. */
> > + if ((pc < alt_entry_point) || (pc > entry_point))
> > + {
> > + /* We are in the body of the function. Set a breakpoint to
> > backup to
>
> I would change backup for "return", or separate it to "back up",
> otherwise I personally think of data backups.

OK, I changed the line as follows in my copy of the patch

entry_point = gdbarch_skip_entrypoint (gdbarch, sal.pc);

if ((pc < alt_entry_point) || (pc > entry_point))
{
- /* We are in the body of the function. Set a breakpoint to backup to
+ /* We are in the body of the function. Set a breakpoint to go back to
the normal entry point. */
symtab_and_line sr_sal;

I think that addresses your concern. It is not worth resending the
patch at this point for this change but will include it in any future
posts or commits. Thanks for the feedback.

Carl