Re: [PATCH 1/2 version 3] fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp

Pedro Alves
2023-01-24T18:37:37Z

On 2023-01-24 3:51 p.m., Carl Love wrote:

> On Tue, 2023-01-24 at 14:08 +0000, Pedro Alves wrote:

>> Wait. That right there sounds bogus. The source line looks like:
>>
>> func1 (); func2 ();
>
> My bad, I didn't catch that you were implying func1 and func2 as being
> on the same source line. There is an existing bugzilla for the case of
> multiple executable statements on the same line.
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=28426
>
> I have worked with Luis Machado <luis.machado@arm.com> on a patch to
> address that issue. We have posted a few versions of the patch but it
> still needs some work for finish. I wanted to get back to that patch
> once the reverse-finish issue is done.
>
> I need to spend some more time looking at the rest of your response to
> understand everything you are talking about. That said, my first read
> looked like the issue in the bugzilla I mentioned. The patch Luis and
> I have for addressing multiple statements on the same line applies on
> top of the X86 and PowerPC reverse-finish patches.

You should fix the reverse-stepping multiple statements issue first, and
then the reverse-finish problems go away, you won't need that patch any more.