From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id O9cLBTNxBWBbGwAAWB0awg (envelope-from ) for ; Mon, 18 Jan 2021 06:29:55 -0500 Received: by simark.ca (Postfix, from userid 112) id B0E2B1EF80; Mon, 18 Jan 2021 06:29:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C6841E945 for ; Mon, 18 Jan 2021 06:29:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 283273846402; Mon, 18 Jan 2021 11:29:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 283273846402 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610969393; bh=cVmVAK2Y+wG+7MRLyFFXYTRu//FpN73xaBD74CqXwNs=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=J9UqVSfBpba2gxpTIUAMHkorBP8UnOUQvBLFCcOuexEsMDoC34UhGEr8VIO4igPuY bYlTZqUcQ8aXZ9mbt/0NiJd1lsJ84gdHHAjet0DuPCj5srgNnyD4K+RPKeFOzyGeyx Py91yoK6PY3+EoDqBkxHyPsYReYc/S3MAoLNCZHM= Received: from sonic307-53.consmr.mail.ir2.yahoo.com (sonic307-53.consmr.mail.ir2.yahoo.com [87.248.110.30]) by sourceware.org (Postfix) with ESMTPS id 01F31385B805 for ; Mon, 18 Jan 2021 11:29:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 01F31385B805 X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1610969387; bh=531A6J1tJ88444tWSbuSQjOexUzdIJ+7s1wyvFqwEtr=; h=Date:From:To:Subject:From:Subject:Reply-To; b=aS54DG61iV58oTNghMp6Tjg+MnhdzPkQByL0ySZvsPnn0weYUVRS5jY7DQLgDar/uOFGaav296n/TJ8GRcs5jODaSBZDzTt4SE4DOFqcU1ne2yOyahRPCSWJwJzEXS2rNBNRxRjvsN4cKBh5KYxkCRf3nxm+quRGm2WTBgdIlii9oGKPyAxlAUKrI4YzjTZEpSh6BeVde14djaPGld3q5JDd/e8BI21ePBaV/5r5qX4BlumNS++0Vv6JzD7USNstPzqYy4SsqKGP5xQWOo1Vh+AAwMqsTOoWL+VmVTr+NFxtUCGxWjcylU7wKvhErusXBXR7QBgcTqsKSNhowE31gA== X-YMail-OSG: 84Df0.oVM1moW2S4pUgIoxTrKiVpPODtALL4iofOTOLzgjk2HjhV5NE6VqW9vbT VXBAvP0KAtPkPI19Hn7en2NxAJ6AJjvPYzSB0ZYj2WxUO65kyCYOa9rGFy3A1mFAJUpAB5Kwgjzb ETgRigqFgZFBaTeXS7gW.VXiuxdYz5wgm06Qb50KKBO8q79ZtMMcLo_N2n_8QMrIeIIa5CcQy35z pJBbGIAbGQ1YVjPf8j5M97jkJ9zO1d.LdMHzLXn4j6dCNNTp6iTXcDP0fuXIyfI_Vra08D.WQqkC 5E356iLh2Y3_7rgHasnvJFQVkHQHIj44sheuSqMSIgF1GNSONV1Cru097YLeDonTFFUwapvNmss. kZPHMvIy1vK6V6zJ4GNWpARPZHQAPwHWKbkHIibJTgVzM0Iq2j4viZ88u9v9u.JvUSQP.JvN1L5F Oi_g_t43xEXISyxfUvThbaPC1cfNK4mcLyx56AERzOoYguriQ6ZA6kY5I.pZn4iHvUmn4EOhP_ey pVbem0aRzsWxsh.HwX76T5nXqR3Lyu2rE9ujKFahE3KTA1EBaEZoAaSObZgFg6LUOX3Fh5bEt4Va wW5WjOL6vgCLN_fnLF2NKlxY3nk2LpshOj9ixmyNG_Sm6a1ZS4hbpLQU_zTp_9TNSqvSOHipatMF skxgQf.Gkxj2cyk2IO6dnH4nlgvutcjppNO3YEf1JPlUqheuw3vvfaUjtNb5h4NYaEzySt40dyVp rmrjMBULV8.t74_mxd_rY0otBkewXKvJAwdWGzYynTpXKI4ND9CTkPBYuxtpExpobUyeXHbQCvR7 bN.rK2YtQU9NWwTVZKH92FrNVGjrm_ACKEgsklfNfHM.stCmoBESV1zvJACNOSYQH_4jJHlT6e8_ jRuJY.TdUK5U6TcwVUbVLPBST_PI53o7jt7HBisAOUTS8rli5orLRWtWjUk3xPfrxWU5p4YjOYDz izfriTulMBRxXn5zcRvp5gQpaT4OaRD_EssWeDQXr7mxYX8PZYpQnGgJ6x3ku4WiuRIkHaOUTBrJ rEtTp6Kq0b7E0VOL2yt6PzJ1V4w5ZCZo17BZ65vclZwGmtk52MvRq5VsFX.6lbjNmfoqt8HEcu0h vEXoEyfMYqqmBM6xbzw9SL_lmGxe7tg6HZVUIcplF4rpb132mOz3phWjtdjw.mn_6TSaorB8fdbg 3lNZY0N.Ynl0riT5fnMQ_hKmimOcJ.R9G6eJU.sMW3GsUHDhYeKvUxVAMzHD2ys6j.cxg1W41TJW fPZsmNfjMrl20wMCnFgjpRsZyBA_oE20WPHNOunqIjepoeKC6NZGAq5H.Po9WWmMwFHsH9_7GXZ9 w5Q9_5Yv2ouvQGdkgvT.4AgZtEXMRSHizPMlU1OImG4fLXdZsIQ.V3.vN817j2me3js.1petBbcQ 5_IfxtUaWlYFaTTuQmZTLHhfMkqGSIi6XLQu3QOm7VCdLH5PIw9soiBN90I_B7SLSEfZ1xdkdCfN AmufvaHnhuJl7GvnAgXYFcM5_NWKs4sRWo917ky0kB.3DOubnpl1l2hm2RE11acfq0k6K8zCDum6 TSgtxrttO.009EM1IxX9x8SLWlShUMRDw.cdfqPofVi6dUqwIGOWJzDYIONgNXPE61bbKL1NHLlD 7txTfWPjMMJ24fE1Tiv1bCmRT70yGWVkDKjaRhhnPbATSqVbb1slkn0X2hiWhjapIR6M4mJt99U1 r6YFwrdTbpAFymn7yzsw.xYffzoA4Ow6gzDLkOZwOyEOEEIPaiviJkPL99Ym_MmC59.RyXzK3oeY msr3VSPW0N4EYxutOs6swpeaf8t.Skxqq51gsmiMCGOttCyeeoFkePQmMObOEmukyzMUsmgjJ5MO I.xjmS36fZzr0zpflhQaZuQ15Yn8kl96SmKi2G06JIK.ziEYjkb0RvRdL3dcFixGAYzgCiUhhrOQ ZMK4ZiuRyCdIYwtlzfWi6tQo1kGg2xnz9.UEVWhYNd3RgTX5LAA0raEG3YfiCb2V8S_yUC0s3TqW MNEqoRmfbi_PAlcm5qpeOhab3FSc_dRIqdQSZHXK8yGgeq000YrJphoRpiXP4h0KIS.B5opLz_ER 8ZgqUnViMBcC4kjDcGHehsJtZ3kULYW.TWpCYiBLgCfK6taTN7oLnDAoAYRkRgHGwHihPi0ibuHm kyyZ5YDVHVt_RGD.tFEfCPglOIOVusKvGXvilt4xGVRqiOhZmalzypiH6wbgT3Ne8_8r44wA7JHN zq8hT0N6Rc8AvIv6wE3FjMq7iX6HW9fU4K8iQkfaPJbJb.RfBsLHunEKg.OQx6oM3A1wH0w0YKyP mwibnqex01rp6u5w76Soufw0NXHWUJ4yk2ky2wKavmKsod.mbofhiClj1SK36CJyqwUF4kJM5YAe LF0w4uWwF6PdPyYDccvN0kszv1RByEjn4jGfsGXQOZciqhHbo70gzBZpx8rIjPFDcNlvO4_2g.1i RzbMKzT0XaIosx8aUNq9mj9EZe12jb8uuMmmsdg_AbQYwlld2vgVqofVx3chEZlabwYmJAfoE8qT kupouzXyj0x65iEftyBPw9PdiT9775CMFGICgCiTwtOOk7YYR9dAa3c5D5tr9dc91Ss33y2IACob YZJqFC5CjUi.4QeIqtPAVpQR8fA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Mon, 18 Jan 2021 11:29:47 +0000 Date: Mon, 18 Jan 2021 11:29:43 +0000 (UTC) To: Andrew Burgess Message-ID: <301383083.5492027.1610969383170@mail.yahoo.com> In-Reply-To: <20210118103058.GR265215@embecosm.com> References: <20201229170227.821-1-ssbssa@yahoo.de> <20201229170227.821-2-ssbssa@yahoo.de> <20210115164811.GK265215@embecosm.com> <20210117113102.GM265215@embecosm.com> <2060671008.4946685.1610889581434@mail.yahoo.com> <20210118103058.GR265215@embecosm.com> Subject: Re: [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.17501 YMailNorrin Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Cc: Tom Tromey , "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Montag, 18. Januar 2021, 11:31:00 MEZ hat Andrew Burgess Folgendes geschrieben: > * Hannes Domani [2021-01-17 13:19:41 +0000]: > > >=C2=A0 Am Sonntag, 17. Januar 2021, 12:31:05 MEZ hat Andrew Burgess Folgendes geschrieben: > > > > > After further though I think there's an even better solution for this > > > issue.=C2=A0 See the patch below. > > > > This version crashes for me when I disable and then re-enable TUI, beca= use > > tui_windows and tui_win_list are empty, not filled again in tui_enable,= and the > > tui_update_gdb_sizes call at the end of tui_enable dereferences > > TUI_CMD_WIN. > > That's annoying.=C2=A0 I would have sworn I'd tested that.=C2=A0 Guess no= t. > I'll take a look at this later today.=C2=A0 I guess something that's > currently conditional will need to become unconditional so that the > windows are recreated when the tui is enabled. > > > > > Also, and I think your previous patch behaves the same, but I can no lo= nger use > > the TuiWindows variables width/height/title inside my Window.close func= tion, > > because at this point tui_active=3D=3Dfalse, so the assertion inside is= _valid > > fails. > > OK, I think this one should be easy enough to fix. > > Out of interest, what do you do with the width/height/title in the > close method?=C2=A0 Given the window is about to vanish I'd have thought > all you'd be doing at this point is internal object clean up? I have all my TUI windows in a dictionary, with the window title as key. And on Window.close I remove the window from the dictionary. > > This can be worked around by saving the values in some Window class mem= bers, > > but it is more inconvenient. > > I think my fix will mean you don't need to do this. Thanks. Hannes