From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id p+/5FXgm3V+MfwAAWB0awg (envelope-from ) for ; Fri, 18 Dec 2020 17:00:24 -0500 Received: by simark.ca (Postfix, from userid 112) id 4A4F81F0AA; Fri, 18 Dec 2020 17:00:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C897B1E552 for ; Fri, 18 Dec 2020 17:00:23 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E3FB384B806; Fri, 18 Dec 2020 22:00:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E3FB384B806 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608328823; bh=GFCPbtw9L81VWfAk67wXDzzcjf72MEg8GGhthA63ipU=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VX/zKu2RIW7SfCt1j+iF+Kf4o1fAnpjNveDkQUSHZFZYrtOcq7YVDWdQyuciGE7Pk /y5OKRKew81doKNsQIyEU1vKnAUq4NLj73pU3REpngIWbGDhuwRirjv3Vc/OrdE5Dc bpMOpfq4QN4/3LsESNuof376nzlM5+pCTdUsQ9qw= Received: from sonic310-12.consmr.mail.ir2.yahoo.com (sonic310-12.consmr.mail.ir2.yahoo.com [77.238.177.33]) by sourceware.org (Postfix) with ESMTPS id 64E2F3854809 for ; Fri, 18 Dec 2020 22:00:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 64E2F3854809 X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1608328819; bh=nGdG09+ZOty1SQOpa89GljlEFl28KHFLXdk2/QGVHbw=; h=Date:From:To:Subject:From:Subject; b=g5h5YUrrMtqEB202C66GN18eAINKnGZt1+QVX3aQzb1jmJa7aCuTO+ZW4pwJt8fbDUaoerDW++XVH5ANS60PJUlmtXotAoS8+IQda5CwHqxwr/CbbUYuRDBZwfeFxWySK26tYjoXi95LCOcXxrrlZLAlw0sm2oRYvmgjHpPA/cz1v2n05cA5aALulZV9J+dGQPG6fCP0WHkUzZEWdCDe+duABRSyWxpOK5InfbcS0RU0hqYpuIEdI9blu1OI302NfzfzcDzd0lFWhhgFiA0SIbKC8j8SbAclaBnB9ilZXRuYcJwYA6aA6pZgHrNAWuJpgOAEpacHVdPjdmSynu2UTg== X-YMail-OSG: IXmVyY8VM1nABWCka46RWbG66achK1viAoiI9V0bZhQbqB5w7LDO64QNU9H30Rw Rjti52KEamaG1Cj.8kkvXnmidUa.NXiwMDQ7A.umtXfQAsYT9N.8G4GdBgHBLCeTDHbrt_QsnUsZ GzokSzGK0KDDGbathcJBT.28Qro_L4P5y5EPtalFi870GVP4Mbt4sCCX.d5UQIGlFLugJ1jxxWG0 DPrLJRUDJTenOOWqG46nnIe64WCoh3oFNupAkG8xKnza6qhDFq6GtKgPEZCN5kYWaUvd73qSgjea J0EmgRLzLQRr3ZTWbOcP7lNolxIXdgc74p22_bGqUC5Oa7BmW3B4eO8szhPmJLB9JdicUQCU2GPx IqmxNgprCt6JhfRd5dJI55EkqGh59CrNzu9nhO.9qpWvyaO4qMDAxAvUufHPX_HruxCYCk53dvy0 cjzHogOVLImUxV7s9Jl9SiFXHKFtW7N.KeEE8tQwxKtRCIpbp98To7h93gqe649eXRw2y1v42EeS Sa5FOxlymbwE6j2Sc0EeVS5_dqm_2wq2uvJvqJfz_PFZiI6h7jlnm1bNarKntJolMr6lf1Dm1iLY iCnUK3mkvxOZz0dzF4WIkG4dihZiT45YZFe4oIPDnilmjA54oGUTvlE75LuIZ5VTLhGZmmncusJ5 tncV1E4eSbQBmJUiQtI0HN4y4Iq4MnK.vx4QdDLkIpSUYH6H7UFDrtqGQOLZjI089bayBEXCmxIQ 1Kr0_2pL7ULQpVXsv_YtHX5A3Td4VgaxTs6eMuRlZYU097_sdjL5WamlIq7fXzrVdKaP6_7_bY15 cm.Qno2Uga9bv3pqSkGDHataAv1ADstBybKDsuvVUHvdow4pqvb0VDTMVeqFGhgLYbX.jJZbRa1u ExogzBDEasaP3pnL8.4VQIN5NqW7YtWsQ975kxgUx8e3VWfpU3fXuBYXZW1fKlKefQH8t2yWuzON j41qyLZ2y1Gt1bdJOPdvi6Q_j57NrAwiDnf_9jBqdr80VSRat279bmygh.UDNQ6hDH4Z3pe2GS24 KwWRdq9FmGcADSHzvdUbrdFu8pPvyJV6GOJLLiFgODyvb.n7b4eqgls.V_zu7kdyKjFXt9nB1h5c ESRbLGRCqPn_.qcelxpLL9a0z5JF6M3i.h17ymCJrVrpDW4VaM3n2D.Db65DhTGeQpev1MWKFPYY qcRYa2S1ppvr23BVDynQmXUvsLo_K5mU6BzVJfwaj9LEHuntXakiG56w.UqROuxmMPhbL3T3kgG. a5cqbQgdcaYuXT0QmaOFiDHCqh7dRNCt3cuaN1W8SAzm1EexKrEh0vE0kgegbrC6eMLzu.g26ZMH es5t6PoS8Pw4_fCHgmgizM9Kgp6t7jF8ffVrT7zrLJmPH_1i6eRrCwati1rUbttc85_lR8vvC_ad qr9nl7ciD94COOF_hJQe7cwaA.7Lrry9unFEyPkg53FN7...N7yeOj3ZoiSkrl5xRzgmWwz7_AUy NBEtrk_Wg6XapyusUySchIiu9hUbmaOaeyCCyZErb.GNG4vCDI9cJVnUawhSl9TOtBtS_0vW2y8L QX7SHi50YS7f45QYBiDP3o4FvRMcndaWi4lIpWti2YbEpcBSxzLyaARj2m7fjwErFNOj2ClW63tG bomixP.ONlCxLqs3oHwGmIQqvPNYJHoQ2gVMS5d4LOR.8AfouL5p2Vsi.3Es.RsbX0nk5G03EWGZ 2yg6e7LLzFVgT3iBnW_R0Zg8TVEnZImqONG2KxRWGZQXxT8JiRhYOisOSZ19vRQk0q1D7CI6Ewqt Nwkiam_m8jMWmBf28Ux3406UxoX_4Ucn_myAyQbLdS8YI_tBUrIQkHpHxm1EOhjMXFts1JkH_ynC u9SUcnPFscyFxsyYmP1tBNfq0g9.pcMfb07JobqplHg6bM6AzeqB5eAmAuug30qZDhACLEBqhTfB P4hgM3xj72mm41sDhROo2d5DoIEiOA9n62HTCtKow1.O2n65ALZCvF2BCLqxXB3Bfq2yTmXjfclI lNB77g4v9iXavB28ASfdC5lQPHoxmf_1T5EuPBBOULo84eG5Ioc0SsXM4S.3LsVkaPClRpVUAbx0 OTe6wzsAsqmb9wRkgX.tcv.SWIVcj6qlBcLB2lx.Z4_9.E8JzF2y01fH4xx_3eSUv1LnemlNiyml EDHKAaC9X6OiX4tgHe_p8nW.LertHUbgzT5_SQFMqjagfJki76_s.sXqLQw4fWkcApQNtSfCIw0T Yd6eWGsoT37idm6L3AyIp1c_7fERf3P.AtTtL8HReihnnowmsRdZOTQz5GzbvL8nM04UPz8NpmM2 Ri27SCu.YCQmeac6W.tzIcUNNg2t5QaHRsSWn0VBlIZ8PO9aG_jo2dIVFR32htU6L59l55GYryYW _shh2xBpMEQX6wNf0HdpcAW74pnoMZwWGvKP0kll3VmFIg47K43ugM5psSaBcR8rBuqK7cLDALRj TdqerIa7l9QQw5sWG9aTMByHFBrvr.9WyS39m3iWyYvmBGbv7RI1c Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Fri, 18 Dec 2020 22:00:19 +0000 Date: Fri, 18 Dec 2020 22:00:18 +0000 (UTC) To: "gdb-patches@sourceware.org" , Simon Marchi Message-ID: <300236003.3696621.1608328818697@mail.yahoo.com> In-Reply-To: References: <20201217192912.1981-1-ssbssa.ref@yahoo.de> <20201217192912.1981-1-ssbssa@yahoo.de> Subject: Re: [PATCH v2] Don't compare types of enum fields MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.17278 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Freitag, 18. Dezember 2020, 22:28:06 MEZ hat Simon Marchi Folgendes geschrieben: > On 2020-12-17 2:29 p.m., Hannes Domani via Gdb-patches wrote: > > + > > +if { [skip_python_tests] } { continue } > > I suppose this can go earlier, to avoid compiling the program and startin= g GDB if > the test is going to be skipped anyway. It fails spectacularly when I try this: ERROR: tcl error sourcing /c/src/repos/gdb-testsuite/gdb/testsuite/gdb.base= /compare-enum-type.exp. ERROR: can't read "use_gdb_stub": no such variable =C2=A0=C2=A0=C2=A0 while executing "if {$use_gdb_stub =C2=A0=C2=A0 =C2=A0&& [regexp -nocase {^\s*(r|run|star|start|at|att|atta|at= tac|attach)\M}=C2=A0 $command]} { =C2=A0=C2=A0 =C2=A0error "gdbserver does not support $command wi..." =C2=A0=C2=A0=C2=A0 (procedure "gdb_test_multiple" line 47) =C2=A0=C2=A0=C2=A0 invoked from within "gdb_test_multiple "python print ('test')" "verify python support"=C2=A0 -p= rompt "$prompt_regexp" { =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 -re "not supported.*$prompt_regexp" { =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0unsupported..." =C2=A0=C2=A0=C2=A0 (procedure "skip_python_tests_prompt" line 4) =C2=A0=C2=A0=C2=A0 invoked from within "skip_python_tests_prompt "$gdb_prompt $"" =C2=A0=C2=A0=C2=A0 (procedure "skip_python_tests" line 3) =C2=A0=C2=A0=C2=A0 invoked from within "skip_python_tests" =C2=A0=C2=A0=C2=A0 (file "/c/src/repos/gdb-testsuite/gdb/testsuite/gdb.base= /compare-enum-type.exp" line 18) =C2=A0=C2=A0=C2=A0 invoked from within "source /c/src/repos/gdb-testsuite/gdb/testsuite/gdb.base/compare-enum-type= .exp" =C2=A0=C2=A0=C2=A0 ("uplevel" body line 1) =C2=A0=C2=A0=C2=A0 invoked from within "uplevel #0 source /c/src/repos/gdb-testsuite/gdb/testsuite/gdb.base/compar= e-enum-type.exp" =C2=A0=C2=A0=C2=A0 invoked from within "catch "uplevel #0 source $test_file_name"" testcase /c/src/repos/gdb-testsuite/gdb/testsuite/gdb.base/compare-enum-typ= e.exp completed in 0 seconds > > + > > +gdb_test "py print(gdb.parse_and_eval('e1').type =3D=3D gdb.parse_and_= eval('e2').type)" "True" > > > I think it would make sense to move this test to the gdb.python directory= . I wasn't sure about that, because even though I use python to test it, it's actually testing check_types_equal (a gdb base function). Hannes