From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28124 invoked by alias); 20 Oct 2002 21:55:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28117 invoked from network); 20 Oct 2002 21:55:01 -0000 Received: from unknown (HELO factorix.sdv.fr) (212.95.66.10) by sources.redhat.com with SMTP; 20 Oct 2002 21:55:01 -0000 Received: from pc-muller (ip-76-252.evc.net [212.95.76.252]) by factorix.sdv.fr (Postfix) with SMTP id 93BECDDDE7; Sun, 20 Oct 2002 23:55:00 +0200 (CEST) Message-Id: <3.0.6.32.20021020235330.00c24478@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Sun, 20 Oct 2002 14:55:00 -0000 To: Elena Zannoni From: muller@ics.u-strasbg.fr Subject: Re: [RFA] Fix an error in value_change_enclosing_type Cc: gdb-patches@sources.redhat.com In-Reply-To: <15792.30602.54384.850513@localhost.redhat.com> References: <5.0.2.1.2.20021007132114.01e66260@ics.u-strasbg.fr> <5.0.2.1.2.20021007132114.01e66260@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2002-10/txt/msg00326.txt.bz2 At 17:05 18/10/2002 -0400, Elena Zannoni wrote: >Pierre Muller writes: > > > > > > > > the function value_change_enclosing_type > > does not set the enlclosing_type field correctly if > > the new_encl_type has a bigger length that the value type. > > > > Its seems quite astonishing that this has not been noticed before, > > but I discovered it when trying to get > > the fpc-abi.c code to work correctly. > > > >The fix seems OK. However, do you have a small testcase? It would be >good to add it to the testsuite. Sorry, but I don't have any, because I really don't even know if this code is ever executed for C code. It is for Free Pascal generated code, that is how I discovered that bug. But I can't add tests with Free Pascal anyhow. >Does this fix changes the results for the already existing tests? Sorry, but I never worked with the testsuite, so I can't answer this question.