From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18022 invoked by alias); 9 Aug 2018 16:07:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17944 invoked by uid 89); 9 Aug 2018 16:07:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 16:07:46 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w79G7diF017337 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Aug 2018 12:07:44 -0400 Received: by simark.ca (Postfix, from userid 112) id 91AA41EF36; Thu, 9 Aug 2018 12:07:39 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 6E5681E012; Thu, 9 Aug 2018 12:07:38 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 09 Aug 2018 16:07:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Joel Brobecker , GDB Administrator , gdb-patches@sourceware.org Subject: Re: New ARI warning Wed Aug 8 01:55:57 UTC 2018 In-Reply-To: References: <20180808015557.GA64451@sourceware.org> <20180809143249.GA2452@adacore.com> Message-ID: <2fecf1cd2db153dd8e09f244ab111407@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00219.txt.bz2 On 2018-08-09 10:45, Pedro Alves wrote: > On 08/09/2018 03:32 PM, Joel Brobecker wrote: >>>> gdb/dwarf-index-write.c:1625: perror_with_name ("rename"); >>>>> gdb/dwarf-index-write.c:1640: gettext: _ markup: All messages >>>>> should >>>>> be marked up with _. >>>> gdb/dwarf-index-write.c:1640: perror_with_name ("rename"); >>> >>> I think these can be ignored, since these messages can't be >>> translated. >> >> Let's add an ARI marker to document this, and silence the ARI? >> Otherwise, someone looking at the ARI report for some easy things >> to improve might come upon this one and waste time figuring out >> that these cannot be translated. And also, it would prevent the >> report from containing too many false positive... > > The way we've been quieting the ARI in these cases is this is the wrap > in extra parens, without the "_": > > $ grep perror * | grep "((" > event-loop.c: perror_with_name (("poll")); > event-loop.c: perror_with_name (("select")); > fbsd-nat.c: perror_with_name (("ptrace")); > fbsd-nat.c: perror_with_name (("ptrace")); > fbsd-nat.c: perror_with_name (("ptrace")); > .... > > Thanks, > Pedro Alves Ok, I'll do that, thanks. Simon