From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77338 invoked by alias); 30 Jun 2017 11:30:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77138 invoked by uid 89); 30 Jun 2017 11:30:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Jun 2017 11:30:37 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 36BE0D557C; Fri, 30 Jun 2017 11:30:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 36BE0D557C Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 36BE0D557C Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85CDC60BE9; Fri, 30 Jun 2017 11:30:12 +0000 (UTC) Subject: Re: [PATCH] PR cli/21688: Fix multi-line/inline command differentiation To: Sergio Durigan Junior References: <20170629020527.468-1-sergiodj@redhat.com> <90d0a1563dea6893b5dbcd8df19d0285@polymtl.ca> <87d19mmv7q.fsf@redhat.com> <87fueil9jx.fsf@redhat.com> <6c2f659c-fba1-dcdf-becd-0e05d3d08636@redhat.com> <871sq1lnv4.fsf@redhat.com> Cc: Simon Marchi , GDB Patches , Jerome Guitton From: Pedro Alves Message-ID: <2f8ebe75-29a9-71bb-008a-d4272441acac@redhat.com> Date: Fri, 30 Jun 2017 11:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <871sq1lnv4.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00820.txt.bz2 On 06/30/2017 12:24 PM, Sergio Durigan Junior wrote: > Hm, no, it doesn't. I guess that the best approach would be to make > sure that lookup_cmd_1 advances the **text pointer past all the > whitespace chars after it matches a command, and then we could use > Simon's idea and check for *cmd_name != '\0'. I don't see the point of touching lookup_cmd_1, and then handling fallout of that. Simply do this after the lookup_cmd_1 call: lookup_cmd = skip_spaces_const (cmd_name); bool inline_cmd = *cmd_name != '\0'; and then you can do: else if (command_name_equals (cmd, "python") && !inline_cmd) ? > > I'll prepare a patch here and do some testings. > -- Thanks, Pedro Alves