From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9ar3E8GH2Weg8xMAWB0awg (envelope-from ) for ; Tue, 18 Mar 2025 10:48:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742309313; bh=EYMMthD9FRiMZwJ6VFX4F1zIsgTI7U8WhTw9xlj41SE=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gBhlLNyzROtr1G2XxeVauuUyZyTOkAGRNObzTVpNIEkFK0ES/BXEWfBinRrmZMUn3 LISS6Ad8FMGokYopjbYSqaMBkw6jzKFS3Vdu+ERUUcDQKkfLsWkya8+9x3tE0+pkeI ozuM6MI/sBWiyekdeSCW4+HpQVOBDsYbE+tk24yo= Received: by simark.ca (Postfix, from userid 112) id 40ADE1E100; Tue, 18 Mar 2025 10:48:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=HumahA44; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=T1wXpus+; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 88C951E0C0 for ; Tue, 18 Mar 2025 10:48:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 57BFB3857C78 for ; Tue, 18 Mar 2025 14:48:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57BFB3857C78 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=HumahA44; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=T1wXpus+ Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 34F5B3858433 for ; Tue, 18 Mar 2025 14:47:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34F5B3858433 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34F5B3858433 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742309269; cv=none; b=ZwLQsN/JaG9KaSk+pUm/mez6tocQHznbvgqMR1D0vah6xOM9NQJbPzW75YkGXj8VRd+K4/0+KPwZ6wBiZpdVtfb4Xhb78zd7qs/GQVvwfRwnODm0TYjqbHaIxts5OZVgpI0VvDO4rRgcIjy/XxzSWVUn82y+y962pyYg9JMAEr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742309269; c=relaxed/simple; bh=EYMMthD9FRiMZwJ6VFX4F1zIsgTI7U8WhTw9xlj41SE=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=eIbPC5VGs15ECqg68zwvTUbnfXBuAyHz/4Zo1QMU6debLJsJlOK1IKr5O8M3k0noOBjRzHkM6joNbcTmbqNcgMNjiXJqoRdCteqv0JmCRE6UFn8SPIfSndmAyjBpcvaBAQIEQJwQEmpFwrzJD5udlb07SAfHfRRg739aHjl/+cw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34F5B3858433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742309268; bh=EYMMthD9FRiMZwJ6VFX4F1zIsgTI7U8WhTw9xlj41SE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=HumahA44sKJz2ayLNkHFlK6B68QmwZbDEfjmZzZ/lchLWPNfq2pytYGncAGXga46I CzoxHUreAmugqR0Cfg/RAhPJQQAGLaW4LZLYnaMFrfJggroYj/kdJ2FvVqK+mYYTNc sEMoNEfGl2KAEH+5f3bi23rq0vJe82MiuMjA8oG4= Received: by simark.ca (Postfix, from userid 112) id 6237C1E100; Tue, 18 Mar 2025 10:47:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742309267; bh=EYMMthD9FRiMZwJ6VFX4F1zIsgTI7U8WhTw9xlj41SE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=T1wXpus+FHgurI2O5o+FcAfNDBtyx9Y36Yh/STLw5LMXtmmrvWuA4lrjzMAFY3gB/ +6MD35oqpsY06AsTosJ2SG5cDSkdzCFpvDanJ0eVna7fpbmVorywqbRgs0zNBdy119 IJv5/0+gvLefFyA66XOmYMz/a4qOpzR/N5nCukWY= Received: from [172.16.0.192] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2E8581E0C0; Tue, 18 Mar 2025 10:47:47 -0400 (EDT) Message-ID: <2f8b7602-d4d8-4c04-ba70-f141f7035247@simark.ca> Date: Tue, 18 Mar 2025 10:47:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/testsuite] Fix gdb.base/enum_cond.exp on arm-linux To: Tom de Vries , gdb-patches@sourceware.org References: <20250318072806.23981-1-tdevries@suse.de> <8675f079-170b-493b-8a06-338d334f30bb@simark.ca> <958bb09e-486d-48f1-9ad9-66b42842bd96@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <958bb09e-486d-48f1-9ad9-66b42842bd96@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/18/25 10:08 AM, Tom de Vries wrote: > On 3/18/25 14:46, Simon Marchi wrote: >> >> >> On 2025-03-18 03:28, Tom de Vries wrote: >>> On arm-linux, I run into: >>> ... >>> gdb compile failed, ld: warning: enum_cond.o uses variable-size enums yet \ >>> the output is to use 32-bit enums; use of enum values across objects may fail >>> UNTESTED: gdb.base/enum_cond.exp: failed to compile >>> ... >>> >>> Fix this by using -nostdlib. >>> >>> Tested on arm-linux and x86_64-linux. >>> --- >>> gdb/testsuite/gdb.base/enum_cond.c | 16 ++++++++++++++++ >>> gdb/testsuite/gdb.base/enum_cond.exp | 15 ++++++++++++++- >>> gdb/testsuite/lib/gdb.exp | 12 ++++++++++++ >>> 3 files changed, 42 insertions(+), 1 deletion(-) >>> >>> diff --git a/gdb/testsuite/gdb.base/enum_cond.c b/gdb/testsuite/gdb.base/enum_cond.c >>> index 35e126aed45..df8830f0c9e 100644 >>> --- a/gdb/testsuite/gdb.base/enum_cond.c >>> +++ b/gdb/testsuite/gdb.base/enum_cond.c >>> @@ -46,3 +46,19 @@ main (void) >>> return 0; >>> } >>> +void >>> +exit (int status) >>> +{ >>> +#if HAVE_BUILTIN_TRAP >>> + __builtin_trap (); >>> +#endif >>> + while (1) >>> + ; >> >> Huh, it would be nice to find something that works everywhere. >> We do >> have "my_exit" in lib/my-syscalls.h, which we could call, but we would >> need to provide a syscall implementation for all arches we want to test >> (not too hard, but still). >> >> What about having a global: >> >> volatile int *dummy = nullptr; >> >> and then do: >> >> *dummy = 1; >> >> Would that successfully stop the program on all known platforms? > > AFAIU that's undefined behaviour, so a valid implementation might just skip the store. > > I can submit a v3 using this (note NULL instead of nullptr since this is C, not C++): > ... > void > exit (int status) > { > #if HAVE_BUILTIN_TRAP > __builtin_trap (); > #endif > > { > volatile int *dummy = NULL; > *dummy = 1; > } > > while (1) > ; > ... > but AFAIC I'm fine with this v2. > > Thanks, > - Tom Ok, fair enough, that's a very edgy case anyway. Approved-By: Simon Marchi Simon