From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13358 invoked by alias); 22 Nov 2016 18:06:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13346 invoked by uid 89); 22 Nov 2016 18:06:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Nov 2016 18:06:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 478F03F208; Tue, 22 Nov 2016 18:06:36 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAMI6Zai032584; Tue, 22 Nov 2016 13:06:35 -0500 Subject: Re: [PATCH 3/3] Restrict value_has_address To: Yao Qi , gdb-patches@sourceware.org References: <1479829721-22162-1-git-send-email-yao.qi@linaro.org> <1479829721-22162-4-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <2f899953-a38a-5c3f-0ee3-017e5dce3b70@redhat.com> Date: Tue, 22 Nov 2016 18:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479829721-22162-4-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00648.txt.bz2 On 11/22/2016 03:48 PM, Yao Qi wrote: > gdb: > > 2016-11-21 Yao Qi > > * value.c (value_has_address): Return true if lval is > either lval_memory or lval_register. > --- > gdb/value.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/value.c b/gdb/value.c > index a093a9a..5ac9123 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -1540,14 +1540,14 @@ value_lval_const (const struct value *value) > return value->lval; > } > > -/* Return true if VALUE has address, otherwise return false. */ > +/* Return true if VALUE->location.address is valid, otherwise return > + false. */ I think it'd be clearer to say: /* Return true if the VALUE's lval uses the value.location.address union member as location. False otherwise. */ > > static int BTW, this could be bool (in patch #1). Thanks, Pedro Alves