Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Carl Bordum Hansen <carl@bordum.dk>, gdb-patches@sourceware.org
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 1/2] etc/texi2pod.pl: convert @t{} to C<>
Date: Tue, 17 Sep 2019 03:22:00 -0000	[thread overview]
Message-ID: <2f88be7d-49dc-f567-f168-f18e3de3f253@simark.ca> (raw)
In-Reply-To: <f4311436-b021-970c-0c64-01f156e39912@simark.ca>

On 2019-09-16 9:40 p.m., Simon Marchi wrote:
> On 2019-09-16 6:04 p.m., Carl Bordum Hansen wrote:
>> Both are intended to be stylized in a typewriter font.
>> ---
>>
>> I noticed that this was missing when I was looking into the man page
>> rendering issue.
> 
> [adding binutils, since it's concerns shared files]
> 
> Hi Carl,
> 
> With this patch applied, the result in the man page is:
> 
>   ...programs written in C, C"++"...
> 
> There are two ways I can see to get rid of those quotes:
> 
> 1. Substitute @t{...} with the content as-is, not C<...>
> 2. Use the option "--quotes none" of pod2man
> 
> This file happens to be present in the gcc repo as well [1], and the gcc version should
> probably be considered the upstream.  If you diff the binutils-gdb version with
> the gcc version, you'll see that the gcc version seems to have received additional
> fixes compared to the binutils-gdb version.  And there's one fix [2] that happens to be
> for the @t{...} issue, that's same as solution #1.
> 
> Since it's preferable to stay as close as possible to the gcc version, I suggest we
> instead sync our version with the gcc one.
> 
> Simon
> 
> [1] https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=contrib/texi2pod.pl;h=91bdbb5cea933d0381f2924ab94490fca31d5800;hb=HEAD
> [2] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=6be49d577254ca021cf0904f920d9785d5fc74c8
> 

I have submitted the following patch to this effect:

https://sourceware.org/ml/gdb-patches/2019-09/msg00305.html

Simon


  reply	other threads:[~2019-09-17  3:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 22:04 Carl Bordum Hansen
2019-09-17  1:40 ` Simon Marchi
2019-09-17  3:22   ` Simon Marchi [this message]
2019-09-17 18:33 ` Tom Tromey
2019-09-17 19:03   ` Simon Marchi
2019-09-17 19:22     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f88be7d-49dc-f567-f168-f18e3de3f253@simark.ca \
    --to=simark@simark.ca \
    --cc=binutils@sourceware.org \
    --cc=carl@bordum.dk \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox