Re: [PATCH] gdb: fix gdbarch_tdep ODR violation

[Simon Marchi <simark@simark.ca>]

On 2021-11-15 11:47 a.m., Pedro Alves wrote:
> On 2021-11-12 20:42, Simon Marchi via Gdb-patches wrote:
>> +      aarch64_gdbarch_tdep *tdep
>> +	= (aarch64_gdbarch_tdep *) gdbarch_tdep (gdbarch);
> 
> I'd think it would be nicer if we added a small wrapper function to each module, like:
> 
> static aarch64_gdbarch_tdep *
> aarch64_gdbarch_tdep (struct gdbarch *gdbarch)
> {
>    return (aarch64_gdbarch_tdep *) gdbarch_tdep (gdbarch);
> }
> 
> and then we we'd get rid of all the casts and duplicated type names at the callers, like:
> 
>      auto *tdep = aarch64_gdbarch_tdep (gdbarch);
> 
> That'd essentially require touching again most lines you already touched, so, yeah, for some
> other rainy day...
> 

Hmm good idea.  Perhaps with some sed commands it might not be so bad, I'll see.

Simon