From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SDckD5PELWXmvC8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 19:17:39 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=LECfZHYW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 34D2B1E0C1; Mon, 16 Oct 2023 19:17:39 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EA4DE1E091 for ; Mon, 16 Oct 2023 19:17:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F1FE385800C for ; Mon, 16 Oct 2023 23:17:36 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 91D333858423 for ; Mon, 16 Oct 2023 23:17:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91D333858423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 91D333858423 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697498246; cv=pass; b=ltnt1KpaJPTAVee7muPhiTqT3SquQ/e/r4wu/s2MZrwplzyePUuU3+Mb3iF7ma+clggUeKGaIjk7JUV9xgf4tMYn44d35OEw1m5TcBywxcWDNIoJ6KAq4rxlKmF1P1I9meMri5lloH9CNAVHLs0vqYgVjFTw4snIBfJhqrdOyio= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697498246; c=relaxed/simple; bh=M12cdYJXlIebQyBosOvy28RTzDqwQxrepM4UZH6czjg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xqfwf99+CJZWNjiN/jplxsXaAe+P6eJhvRcJx9jYDPSp4zpTnVU2nOpaZXMbg+bJBJKDdbQ76JE5wBrc9guMzSxNUyOzAu+riyUAJ5eG6MbZ6cuTd45wejjuC3L1tKU3EHN7sfsIAax7sfJ1qUbGm7a1FRUOFa8XdgZBQthZ8BY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4S8Y112LcWz3NhY; Mon, 16 Oct 2023 23:17:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S8Y111KP0z3CY6; Mon, 16 Oct 2023 23:17:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697498245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=83GcZCT54zuMIxZIm4sj1qC7irY66nWU0BEMzGl3wtw=; b=LECfZHYWsMdk4R35ewj0GR5WxyvQFDxOe11Tx6h7B9ENiORxHWbCCWSzluMHJpsSZqOZ7E ZyEQzpsi/e93a8UmLhYI+vhjdcTzZTt597WU9idRZaO5kjXOg1G5KK9ZhAxFeUyDdWNYDw lxbcBBczqxijbxe24PfNd+PcJe7GBtwVffrUNWbfYI6KzHITk8HkYitrFLwLiO7oXKSnFk oztv9dAIp8Uo5VZD1j7HmuPIPS/Vpx4G4ukK7I3IXdzTM4TSgNRNKrXmLH8X+ZtEsSaNI+ gABmSS1loClk+NS5YUMuTBHX3KRGjroBwaY0F/BSDckVEIGFF81EKM1QrQpy5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697498245; a=rsa-sha256; cv=none; b=gJT4RRnXJy1YXDPNVRoEF0e6wBLIutU7ak68lVtRtLobyKJzSACZlhUaySemOUjnHnxZXX yTW7C/A/wokVSHJMJ97IotLyvvH4YxfdXH3/7Axr3ZS0z3VPbyiL9eg5pykrlch/pW4Kr2 WaVfNOW4k/Nqv7b6q3HDT+DecKCx/3ygInhskBj7gOGxz9UUySM26c6XLiec7wT0QR0vz7 KEObtnduO0JLWhovyu4FfRQ3rK4cOAU/MZ+fjbw6BElXNVuFxXklWxeZF5D8hFklO5GvTs 0OC51MkHfC+DNvKlywLrJoyJJ+FE9b2kvtJxNQIQLwfKFiE1BTvn2Ac4Ololew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697498245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=83GcZCT54zuMIxZIm4sj1qC7irY66nWU0BEMzGl3wtw=; b=OhZlIXDnZgSBnUCAER46a/6VhiywOpeEVlNeAJt2osnz51ijjmICKi9y17Gm74nyL24NpQ XOEFWO0J1y70xCmQlqIPrM36iX0C9e442ILunTSTf2Eog0xWLulJGW1X+GsTdCaylWnRNE 9q+SNppX/RwL29puTt1hvPlRsEXrsT91PrIC74S0I4KQ53zaYf0qPPuzaJvYtj2tkxD4gI 7DTRaigdynwVfjjRGOHNkWQLwxkk8e6c6xzFPTdN8qeQKYr5I7LwOgvlTcSK2yZL7gsbf3 INDT7//qR7i2T3hePr+JOcYW7yXpM4EDn8G2Q7bp92AqRh74xKAcz2GtCoSjpw== Received: from [IPV6:2601:648:8683:39a0:f055:f679:76c4:bebe] (unknown [IPv6:2601:648:8683:39a0:f055:f679:76c4:bebe]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S8Y105bdkztNQ; Mon, 16 Oct 2023 23:17:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <2f6cedab-d96e-8646-01e6-ceb63b772b35@FreeBSD.org> Date: Mon, 16 Oct 2023 16:17:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/7] Use C++17 [[fallthrough]] attribute Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20231016230527.1820819-1-tom@tromey.com> <20231016230527.1820819-2-tom@tromey.com> From: John Baldwin In-Reply-To: <20231016230527.1820819-2-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 10/16/23 4:02 PM, Tom Tromey wrote: > This changes gdb to use the C++17 [[fallthrough]] attribute rather > than special comments. > > This was mostly done by script, but I neglected a few spellings and so > also fixed it up by hand. > > I suspect this fixes the bug mentioned below, by switching to a > standard approach that, presumably, clang supports. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=23159 The fbsd-nat.c change is explicitly ok with me. The series in general seems ok to me though I didn't thorougly review all of this patch in particular. -- John Baldwin