From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23278 invoked by alias); 8 Aug 2018 19:18:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23268 invoked by uid 89); 8 Aug 2018 19:18:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Aug 2018 19:18:26 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w78JIKlh019614 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 8 Aug 2018 15:18:25 -0400 Received: by simark.ca (Postfix, from userid 112) id 419571EF36; Wed, 8 Aug 2018 15:18:20 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 61E2F1E183; Wed, 8 Aug 2018 15:18:15 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 08 Aug 2018 19:18:00 -0000 From: Simon Marchi To: Jim Wilson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] RISC-V: Make riscv_isa_xlen a global function. In-Reply-To: <20180808021406.7587-1-jimw@sifive.com> References: <20180808021406.7587-1-jimw@sifive.com> Message-ID: <2f1fa8863630b3edba841905776882a6@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00181.txt.bz2 On 2018-08-07 22:14, Jim Wilson wrote: > This allows the function to be used from riscv OS files, which also > need to > depend on XLEN size. > > gdb/ > * riscv-tdep.c (riscv_isa_xlen): Drop static. > * riscv-tdep.h (riscv_isa_xlen): Add extern declaration. > --- > gdb/riscv-tdep.c | 2 +- > gdb/riscv-tdep.h | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c > index abcac98016..20181896c5 100644 > --- a/gdb/riscv-tdep.c > +++ b/gdb/riscv-tdep.c > @@ -346,7 +346,7 @@ riscv_has_feature (struct gdbarch *gdbarch, char > feature) > Possible return values are 4, 8, or 16 for RiscV variants RV32, > RV64, or > RV128. */ > > -static int > +int > riscv_isa_xlen (struct gdbarch *gdbarch) > { > switch (gdbarch_tdep (gdbarch)->abi.fields.base_len) Just a note for further patches (you can fix this instance as an obvious patch if you want): when a function is extern, put the documentation in the .h, and /* See riscv-tdep.h. */ in the header file. This way, the two comments won't diverge over time. Simon