From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3615 invoked by alias); 13 Apr 2017 18:29:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3588 invoked by uid 89); 13 Apr 2017 18:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Thursday, thursday X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 18:29:55 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cyjVD-0003dy-P1 from Luis_Gustavo@mentor.com ; Thu, 13 Apr 2017 11:29:55 -0700 Received: from [172.30.1.10] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 13 Apr 2017 11:29:53 -0700 Reply-To: Luis Machado Subject: Re: [PATCH] Make environ.exp run on all platforms (and create info-program.exp) References: <20170331172901.23402-1-sergiodj@redhat.com> <87d1cgtb8a.fsf@redhat.com> To: Sergio Durigan Junior CC: GDB Patches From: Luis Machado Message-ID: <2f1c6f83-5cb0-a1a4-3db2-6b0b9b4b0597@codesourcery.com> Date: Thu, 13 Apr 2017 18:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87d1cgtb8a.fsf@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00447.txt.bz2 On 04/13/2017 01:26 PM, Sergio Durigan Junior wrote: > Thanks for the review, Luis. > > On Thursday, April 13 2017, Luis Machado wrote: > >> On 03/31/2017 12:29 PM, Sergio Durigan Junior wrote: >>> This has been on my TODO list for a while. There's a really old bug >>> about this (PR testsuite/8595), and there was no reason for >>> environ.exp to be specific for hppa* targets. So this patch removes >>> this constraint, modernizes the testcase, and cleans up some things. >>> Most of the tests remained, and some were rewritten (especially the >>> one that checks if "show environment" works, which is something kind >>> of hard to do). >>> >>> As a bonus, I'm adding a separated info-program.exp file containing >>> all the tests related to "info program" that were present on >>> environ.exp. >>> >>> Tested locally, everything still passes. >> >> I haven't gone through the entire patch, but i have a question. Was >> this exercised for bare-metal? > > Nope, I haven't had the chance to test this on bare-metal. > >> If not, please make sure this test works correctly on bare-metal >> targets before assuming it does just because it passes on Linux-hosted >> tests. Otherwise we may have spurious failures due to tests that are >> not supposed to be executed in a bare-metal environment. >> >> If you don't have access to bare-metal testing, i could give this a >> try (it may take a couple days though) and report back. > > I don't think I have access to a bare-metal easily; if you could test > this, I'd really appreciate. Got it. I'll let you know what i see (likely next week). Thanks, Luis