From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id AE17D394848E for ; Fri, 28 Aug 2020 17:00:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AE17D394848E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EBAB61E599; Fri, 28 Aug 2020 13:00:32 -0400 (EDT) Subject: Re: [PATCH 06/13] Use gdb_bfd_sections in symfile.c To: Tom Tromey , gdb-patches@sourceware.org References: <20200828162349.987-1-tom@tromey.com> <20200828162349.987-7-tom@tromey.com> From: Simon Marchi Message-ID: <2effff49-df01-d0fa-1844-afd75453da9f@simark.ca> Date: Fri, 28 Aug 2020 13:00:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200828162349.987-7-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 17:00:34 -0000 On 2020-08-28 12:23 p.m., Tom Tromey wrote: > @@ -500,7 +488,8 @@ addr_info_make_relative (section_addr_info *addrs, bfd *abfd) > /* Find lowest loadable section to be used as starting point for > contiguous sections. */ > lower_sect = NULL; > - bfd_map_over_sections (abfd, find_lowest_section, &lower_sect); > + for (asection *iter : gdb_bfd_sections (abfd)) > + find_lowest_section (iter, &lower_sect); > if (lower_sect == NULL) > { > warning (_("no loadable sections found in added symbol-file %s"), FYI: I've been taught by Pedro [1] that we don't actually need curly braces in this case, and I've been misleading people about this for a while :(. For future code I write like this, I won't use the curly braces. [1] https://sourceware.org/pipermail/gdb-patches/2020-August/171532.html Simon