From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 781AF385DC14 for ; Thu, 4 Jun 2020 18:04:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 781AF385DC14 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 665311E791; Thu, 4 Jun 2020 14:04:10 -0400 (EDT) Subject: Re: [PATCH v2 00/42] Share DWARF partial symtabs between objfiles To: Tom de Vries , Simon Marchi , Pedro Alves , Tom Tromey , Simon Marchi via Gdb-patches References: <20200512210913.5593-1-simon.marchi@efficios.com> <875zcn1xwp.fsf@tromey.com> <5032927f-877b-100b-c3a7-55c78d3a7d7a@redhat.com> <058f6a56-4690-cfd8-ede4-a9bbafc85e1a@efficios.com> <28656eeb-c0b3-c601-f05c-14cfe5493a7e@redhat.com> <63f4d428-b0ec-26de-0265-31002b61f4dd@simark.ca> From: Simon Marchi Message-ID: <2eefe6e4-567b-9742-0d66-e5a76771203d@simark.ca> Date: Thu, 4 Jun 2020 14:04:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 18:04:12 -0000 On 2020-06-04 1:55 p.m., Tom de Vries wrote: > I've also tested this with the gdb_cmd_file-twice patch with these two > target boards, and everything looks good. Thanks for testing. > [ FWIW, the gdb.base/index-cache.exp with the gdb_cmd_file-twice patch > and native is still there. ] I'll take a look at that now. > That looks more elaborate than necessary, how about: > ... > diff --git a/gdb/testsuite/gdb.base/share-psymtabs-bt.exp > b/gdb/testsuite/gdb.base/share-psymtabs-bt.exp > index f4ca58e30b..65ea728f66 100644 > --- a/gdb/testsuite/gdb.base/share-psymtabs-bt.exp > +++ b/gdb/testsuite/gdb.base/share-psymtabs-bt.exp > @@ -25,20 +25,14 @@ > # 3. Check that this frame's information is complete in the "backtrace" > # output. > > -standard_testfile share-psymtabs-bt.c share-psymtabs-bt-2.c > +standard_testfile .c share-psymtabs-bt-2.c > > -set sources [list \ > - "${srcdir}/${subdir}/${srcfile}" \ > - "${srcdir}/${subdir}/${srcfile2}" \ > -] > - > -if { [gdb_compile $sources $binfile executable {debug}] != "" } { > +if { [prepare_for_testing "failed to prepare" $testfile "$srcfile > $srcfile2" \ > + {debug}] } { > untested "failed to compile" > return -1 > } > > -clean_restart $binfile > - > # Load $binfile a second time. The second created objfile will re-use the > # partial symtabs created by the first one. > if { [gdb_file_cmd $binfile] != 0 } { > ... > ? Thanks, I pushed the patch after integrating your suggestion. Simon