From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id F19333857807 for ; Tue, 25 Aug 2020 14:49:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F19333857807 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id AD1A825D053; Tue, 25 Aug 2020 10:49:25 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XzMYe7w6ulcD; Tue, 25 Aug 2020 10:49:25 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 766B825D052; Tue, 25 Aug 2020 10:49:25 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 766B825D052 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zsG9tC9nBtHi; Tue, 25 Aug 2020 10:49:25 -0400 (EDT) Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) by mail.efficios.com (Postfix) with ESMTPSA id 5F7D225CDCF; Tue, 25 Aug 2020 10:49:25 -0400 (EDT) Subject: Re: [PATCH] gdb/testsuite: fix gdb.base/ui-redirect.exp pattern (gdb/26532) To: Tom de Vries , gdb-patches@sourceware.org References: <20200825132750.15105-1-simon.marchi@efficios.com> From: Simon Marchi Message-ID: <2ee8506c-2464-01a3-efa4-c5ec12786b2e@efficios.com> Date: Tue, 25 Aug 2020 10:49:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 14:49:27 -0000 On 2020-08-25 10:35 a.m., Tom de Vries wrote: > On 8/25/20 3:27 PM, Simon Marchi wrote: >> Commit 1eb8556f5a8b ("gdb: add infrun_debug_printf macro") changed the >> debug output format for `set debug infrun 1`. It broke test >> gdb.base/ui-redirect.exp, which I missed: >> >> FAIL: gdb.base/ui-redirect.exp: debugging: continue >> > > How about the other fail: > ... > FAIL: gdb.threads/stepi-random-signal.exp: stepi (no random signal) > ... > > ? Oh, I missed your second message. Damn, I updated this test, changed the output format later and forgot to update the test again. See patch below. >From fc6c77211da34d18c2285347b6e400a3cd055b9f Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 25 Aug 2020 10:41:56 -0400 Subject: [PATCH] gdb/testsuite: fix gdb.threads/stepi-random-signal.exp pattern Commit 1eb8556f5a8b ("gdb: add infrun_debug_printf macro") changed the debug output format for `set debug infrun 1`. The test gdb.threads/stepi-random-signal.exp uses that debug output, and was updated, but not correctly. It results in this failure: FAIL: gdb.threads/stepi-random-signal.exp: stepi (no random signal) Fix it by adjusting the pattern in the test. gdb/testsuite/ChangeLog: * gdb.threads/stepi-random-signal.exp: Update pattern. Change-Id: If5fa525e9545e32a286effe6a6184358374bd37c --- gdb/testsuite/gdb.threads/stepi-random-signal.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.threads/stepi-random-signal.exp b/gdb/testsuite/gdb.threads/stepi-random-signal.exp index fa20f38ba61e..9a8b38c2acf5 100644 --- a/gdb/testsuite/gdb.threads/stepi-random-signal.exp +++ b/gdb/testsuite/gdb.threads/stepi-random-signal.exp @@ -87,7 +87,7 @@ set seen 0 set test "stepi" if {[gdb_test_multiple "stepi" "$test" { - -re "infrun: handle_signal_stop: random signal" { + -re {\[infrun\] handle_signal_stop: random signal} { set seen 1 exp_continue } -- 2.28.0