From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61333 invoked by alias); 29 Aug 2018 17:46:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61102 invoked by uid 89); 29 Aug 2018 17:45:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ftp X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 17:45:50 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 299ED40216E8; Wed, 29 Aug 2018 17:45:49 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15A432026D6D; Wed, 29 Aug 2018 17:45:47 +0000 (UTC) Subject: Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue To: Tom Tromey , Simon Marchi References: <56c5911c-e0ba-5a17-64bb-3634af60a07d@gmail.com> <18eaf339-ca0a-061c-4a17-b837e6ef81a2@redhat.com> <83wosa2yos.fsf@gnu.org> <56153263-c5e6-45ce-8629-c5a77cf17f5b@gmail.com> <87va7t3zuk.fsf@tromey.com> Cc: SiZiOUS , Eli Zaretskii , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <2ec5e4ef-ecc8-5eaa-6437-c1d29a6ff079@redhat.com> Date: Wed, 29 Aug 2018 17:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87va7t3zuk.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00758.txt.bz2 On 08/29/2018 05:24 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > >>> And I know, the MinGW/MSYS original project is maintained but almost >>> deprecated in favour of MinGW-w64/MSYS2 project. But I really need XP >>> support for my needs. >>> I proposed this patch because it's really simple and not intrusive, >>> but you're right, how many people uses that old MinGW/MSYS project? > > Simon> If the missing definition is indeed a mingw bug, but there is really > Simon> no way of getting a new mingw release with that fixed because the > Simon> project is unmaintained (but still useful to some people), I would not > Simon> be against a patch like what you proposed. I would however add a > Simon> clear comment for why this is needed, so that if some day we > Simon> officially decide not to support this mingw, we can remove it. > > Also, is there any downside to the original patch? > If not then I think we might as well accept it, subject to Simon's > request here. AFAICT, we don't know for sure whether it's necessary on the master branch. The issue reported at seems similar, but the patch will not fix it, making it pointless on its own. It's possible that identifying a fix for the gnulib side may reveal a different fix for the gdb side accordingly. SiZiOUS can you try building the git master branch, or a recent snapshot? See: https://sourceware.org/gdb/current/ For example: ftp://sourceware.org/pub/gdb/snapshots/current/gdb-8.2.50.20180829.tar.xz The best would be current git master (or wait for a snapshot tomorrow), because we just updated the gnulib copy in our tree. Also, why do we need the #ifndef? Would unconditionally include winerr.h cause problems? Thanks, Pedro Alves