From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id N73nNhB9X2jaIiMAWB0awg (envelope-from ) for ; Sat, 28 Jun 2025 01:26:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1751088400; bh=OvHPwt7SMclRnmNPNr1HXRqwF1fJoPZZKRC7iJgUnvs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nfW2xLpqWnaQi1Zyq6bWdq2DjgXNR4EPk7R/Wohedf1toKG78WmVYHaw6jq+vO5hR 0h43FCUtPsiXbv5UhcuveIC21ouV8Ua9LtgHhZARoAd8yE/4ukZtR1SORfujLz2tCf UZzK6hRdXGiwwKkV4qBqW7fSdNPpgZep4f800Ezk= Received: by simark.ca (Postfix, from userid 112) id D01421E11E; Sat, 28 Jun 2025 01:26:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=D/ltKCyF; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=qHPjU/0c; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 23E351E089 for ; Sat, 28 Jun 2025 01:26:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AA16C3854AAE for ; Sat, 28 Jun 2025 05:26:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA16C3854AAE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=D/ltKCyF; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=qHPjU/0c Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 76DCD38560BC for ; Sat, 28 Jun 2025 05:26:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 76DCD38560BC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 76DCD38560BC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751088361; cv=none; b=jBnOecx/Y08qO94RLrRnE8PAvqZl1A5kfhO0zwnAFmJ8ENggcCi8aE4q6UrfEksjbeCrt9SEE6NiOv2wWpxHVB+j3/y4LNEbC2BwxqciCScSucGLzQ606kgttblyWQlaJqz0S8yDYkWgTIsx6gGfOyInazvA4KWHpZ8cGmlrtjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751088361; c=relaxed/simple; bh=OvHPwt7SMclRnmNPNr1HXRqwF1fJoPZZKRC7iJgUnvs=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=bqJ3HG46Rrj8e7w4CpWHJRzc7EIgMOkR3kFKrAfJtmlY5O8JFN7Aoey/2RIHK9NzjO7ogsvr687GgNg3fucQmS7qB1hF83pWB87v/u9HeQQSqJ5BGrmv2CisB0GiYGGuviq61gA3wBC7LG/4qPfdm+eC+T+iQUP+yhzaAzZFal4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76DCD38560BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1751088360; bh=OvHPwt7SMclRnmNPNr1HXRqwF1fJoPZZKRC7iJgUnvs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D/ltKCyF/Qertk4ecYoNU8BMyiTgaz0JKk3buywP7iptdg4nfQBhTmVmsnWEb0nfC JMfnSS/JebxeCBL5LY5d/d5gZTRidRCKNRk/FY6DXiJ3O8MVoUVD+2UAEpqtYxChuK UOhqmu4fZPSMHdgjyFDm7dmmRyMwjOGgso2IKthc= Received: by simark.ca (Postfix, from userid 112) id 8EB5E1E11E; Sat, 28 Jun 2025 01:26:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1751088358; bh=OvHPwt7SMclRnmNPNr1HXRqwF1fJoPZZKRC7iJgUnvs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qHPjU/0coUhHUwpZbXNsdVmB4V7/QrV4BXLHs85SXdzW+5Kbo9HWAIxbeHxgmF/nl z19pvYRbahL1DNnHP58Aqhfa0McVMWQYiGa/o0k0V3Us4Z/WT506y7MaMrujIbgcGh WTWM59aV+KdXtQZBO1fZWbiGSWQkvqfeHpIok6Kc= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BA1D11E089; Sat, 28 Jun 2025 01:25:57 -0400 (EDT) Message-ID: <2eb0f5ea-b11d-4e9d-8f94-e85a74a47bf9@simark.ca> Date: Sat, 28 Jun 2025 01:25:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/6] gdb/solib: C++ify solib_ops To: Thiago Jung Bauermann , Tom de Vries Cc: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20250616193443.16703-1-simon.marchi@efficios.com> <20250616193443.16703-6-simon.marchi@efficios.com> <06dd119d-2789-4928-a651-9a8ca0567d84@simark.ca> <3cac674f-75fc-4674-a9e6-21447aabbea6@suse.de> <87ldpcby67.fsf@linaro.org> Content-Language: en-US From: Simon Marchi In-Reply-To: <87ldpcby67.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-06-27 18:46, Thiago Jung Bauermann wrote: > Tom de Vries writes: > >> On 6/26/25 20:04, Simon Marchi wrote: >>> I will push the series shortly, when I'm done >>> addressing these comments. >> >> I did a mingw cross build from trunk, and ran into: >> ... >> /usr/lib64/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld: >> arch-utils.o:arch-utils.c:(.rdata$.refptr._Z21make_target_solib_opsv[.refptr._Z21make_target_solib_opsv]+0x0): >> undefined reference to `make_target_solib_ops()' >> collect2: error: ld returned 1 exit status >> make[1]: *** [Makefile:2253: gdb.exe] Error 1 >> make[1]: Leaving directory '/data/vries/w/build/gdb' >> make: *** [Makefile:11391: all-gdb] Error 2 >> $ >> ... >> >> I suppose due to this commit. > > I'm also seeing it on a native build with FreeBSD on aarch64: > > CXXLD gdb > ld: error: undefined symbol: make_target_solib_ops() >>>> referenced by dicos-tdep.c:30 (/home/bauermann/src/binutils-gdb-wt/gdb/dicos-tdep.c:30) >>>> dicos-tdep.o:(dicos_init_abi(gdbarch*)) >>>> referenced by dicos-tdep.c:30 (/home/bauermann/src/binutils-gdb-wt/gdb/dicos-tdep.c:30) >>>> dicos-tdep.o:(dicos_init_abi(gdbarch*)) >>>> referenced by gdbarch-gen.c:160 (/home/bauermann/src/binutils-gdb-wt/gdb/gdbarch-gen.c:160) >>>> arch-utils.o:(gdbarch::gdbarch()) >>>> referenced 1 more times > c++: error: linker command failed with exit code 1 (use -v to see invocation) > gmake[2]: *** [Makefile:2253: gdb] Error 1 > Sorry about that. Unfortunately, I didn't manage to reproduce. I tried: - a native build on FreeBSD/amd64 - a native build on FreeBSD/amd64 --enable-targets=all - a cross-build for mingw64 on Linux What I don't understand from your logs is that make_target_solib_ops is defined in solib-target.c, which is always included in the build (solib-target.c is specified in COMMON_SFILES, in gdb/Makefile.in). Do you see solib-target.c being compiled in these builds? Simon