From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63390 invoked by alias); 21 Jun 2017 21:36:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62353 invoked by uid 89); 21 Jun 2017 21:36:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=*c X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 21:36:16 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56F1E7F40E; Wed, 21 Jun 2017 21:36:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 56F1E7F40E Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 56F1E7F40E Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0A9A61F20; Wed, 21 Jun 2017 21:36:14 +0000 (UTC) Subject: Re: [PATCH 3/4] dtrace-probe: Put semicolon after while on its own line To: Simon Marchi , gdb-patches@sourceware.org References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> <1498076108-29914-4-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <2ea4d9d1-5434-6b87-91d0-924ef6e0fb90@redhat.com> Date: Wed, 21 Jun 2017 21:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1498076108-29914-4-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00619.txt.bz2 On 06/21/2017 09:15 PM, Simon Marchi wrote: > /* Use strtab_size as a sentinel. */ > - while (*p++ != '\0' && p - strtab < strtab_size); > + while (*p++ != '\0' && p - strtab < strtab_size) > + ; /* Silence clang's -Wempty-body warning. */ I'd must put the ; on its own line (there's probably something in the coding conventions about this already), and without the comment. It's quite common to write for/while loop like that, see e.g.,: $ grep "^[ |\t]*;[ |\t]*$" *.c -C 2 Sure the comment makes sense in the context of the patch, but when reading the code without considering the patch's context, it just looks like noise to me. Thanks, Pedro Alves